* [PATCH net] net: phy: meson-gxl: Use the genphy_soft_reset callback
@ 2019-01-13 0:22 Timotej Lazar
2019-01-13 5:11 ` Florian Fainelli
2019-01-16 6:28 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Timotej Lazar @ 2019-01-13 0:22 UTC (permalink / raw)
To: David S. Miller
Cc: Andrew Lunn, Florian Fainelli, netdev, linux-kernel,
Timotej Lazar, Kevin Hilman, linux-amlogic, linux-arm-kernel,
Heiner Kallweit
Since the referenced commit, Ethernet fails to come up at boot on the
board meson-gxl-s905x-libretech-cc. Fix this by re-enabling the
genphy_soft_reset callback for the Amlogic Meson GXL PHY driver.
Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
Signed-off-by: Timotej Lazar <timotej.lazar@araneo.si>
---
drivers/net/phy/meson-gxl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c
index b03bcf2c388a..3ddaf9595697 100644
--- a/drivers/net/phy/meson-gxl.c
+++ b/drivers/net/phy/meson-gxl.c
@@ -233,6 +233,7 @@ static struct phy_driver meson_gxl_phy[] = {
.name = "Meson GXL Internal PHY",
.features = PHY_BASIC_FEATURES,
.flags = PHY_IS_INTERNAL,
+ .soft_reset = genphy_soft_reset,
.config_init = meson_gxl_config_init,
.aneg_done = genphy_aneg_done,
.read_status = meson_gxl_read_status,
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: phy: meson-gxl: Use the genphy_soft_reset callback
2019-01-13 0:22 [PATCH net] net: phy: meson-gxl: Use the genphy_soft_reset callback Timotej Lazar
@ 2019-01-13 5:11 ` Florian Fainelli
2019-01-16 6:28 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2019-01-13 5:11 UTC (permalink / raw)
To: Timotej Lazar, David S. Miller
Cc: Andrew Lunn, netdev, linux-kernel, Kevin Hilman, linux-amlogic,
linux-arm-kernel, Heiner Kallweit
On January 12, 2019 4:22:55 PM PST, Timotej Lazar <timotej.lazar@araneo.si> wrote:
>Since the referenced commit, Ethernet fails to come up at boot on the
>board meson-gxl-s905x-libretech-cc. Fix this by re-enabling the
>genphy_soft_reset callback for the Amlogic Meson GXL PHY driver.
>
>Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
>Signed-off-by: Timotej Lazar <timotej.lazar@araneo.si>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: phy: meson-gxl: Use the genphy_soft_reset callback
2019-01-13 0:22 [PATCH net] net: phy: meson-gxl: Use the genphy_soft_reset callback Timotej Lazar
2019-01-13 5:11 ` Florian Fainelli
@ 2019-01-16 6:28 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-01-16 6:28 UTC (permalink / raw)
To: timotej.lazar
Cc: andrew, f.fainelli, netdev, linux-kernel, khilman, linux-amlogic,
linux-arm-kernel, hkallweit1
From: Timotej Lazar <timotej.lazar@araneo.si>
Date: Sun, 13 Jan 2019 01:22:55 +0100
> Since the referenced commit, Ethernet fails to come up at boot on the
> board meson-gxl-s905x-libretech-cc. Fix this by re-enabling the
> genphy_soft_reset callback for the Amlogic Meson GXL PHY driver.
>
> Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
> Signed-off-by: Timotej Lazar <timotej.lazar@araneo.si>
Applied and queued up for -stable.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-16 6:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-13 0:22 [PATCH net] net: phy: meson-gxl: Use the genphy_soft_reset callback Timotej Lazar
2019-01-13 5:11 ` Florian Fainelli
2019-01-16 6:28 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).