* [PATCH v2] dt-bindings: aspeed-lpc: Make parameter optional
@ 2019-01-18 20:15 Vijay Khemka
2019-01-29 12:30 ` Lee Jones
0 siblings, 1 reply; 3+ messages in thread
From: Vijay Khemka @ 2019-01-18 20:15 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Mark Rutland, Joel Stanley,
Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed,
linux-kernel
Cc: openbmc @ lists . ozlabs . org, vijaykhemka
Memory-region and flash phandle is not a required parameter, it is
optional to describe in device tree and needed only use basis.
Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
---
Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
index 34dd89087cff..d28c4e117611 100644
--- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
+++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
@@ -135,6 +135,9 @@ Required properties:
- clocks: contains a phandle to the syscon node describing the clocks.
There should then be one cell representing the clock to use
+Optional properties:
+These below properties are optional to define.
+
- memory-region: A phandle to a reserved_memory region to be used for the LPC
to AHB mapping
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: aspeed-lpc: Make parameter optional
2019-01-18 20:15 [PATCH v2] dt-bindings: aspeed-lpc: Make parameter optional Vijay Khemka
@ 2019-01-29 12:30 ` Lee Jones
2019-01-29 23:00 ` Vijay Khemka
0 siblings, 1 reply; 3+ messages in thread
From: Lee Jones @ 2019-01-29 12:30 UTC (permalink / raw)
To: Vijay Khemka
Cc: Mark Rutland, devicetree, linux-aspeed, Andrew Jeffery,
openbmc @ lists . ozlabs . org, linux-kernel, Rob Herring,
Joel Stanley, linux-arm-kernel
On Fri, 18 Jan 2019, Vijay Khemka wrote:
> Memory-region and flash phandle is not a required parameter, it is
> optional to describe in device tree and needed only use basis.
>
> Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
> ---
> Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
> index 34dd89087cff..d28c4e117611 100644
> --- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
> +++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
> @@ -135,6 +135,9 @@ Required properties:
> - clocks: contains a phandle to the syscon node describing the clocks.
> There should then be one cell representing the clock to use
>
> +Optional properties:
> +These below properties are optional to define.
This line is superfluous. Please remove it.
> +
> - memory-region: A phandle to a reserved_memory region to be used for the LPC
> to AHB mapping
>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: aspeed-lpc: Make parameter optional
2019-01-29 12:30 ` Lee Jones
@ 2019-01-29 23:00 ` Vijay Khemka
0 siblings, 0 replies; 3+ messages in thread
From: Vijay Khemka @ 2019-01-29 23:00 UTC (permalink / raw)
To: Lee Jones
Cc: Mark Rutland, devicetree, linux-aspeed, Andrew Jeffery,
openbmc @ lists . ozlabs . org, linux-kernel, Rob Herring,
Joel Stanley, linux-arm-kernel
Thanks Lee,
On 1/29/19, 4:30 AM, "Lee Jones" <lee.jones@linaro.org> wrote:
On Fri, 18 Jan 2019, Vijay Khemka wrote:
> Memory-region and flash phandle is not a required parameter, it is
> optional to describe in device tree and needed only use basis.
>
> Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
> ---
> Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
> index 34dd89087cff..d28c4e117611 100644
> --- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
> +++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
> @@ -135,6 +135,9 @@ Required properties:
> - clocks: contains a phandle to the syscon node describing the clocks.
> There should then be one cell representing the clock to use
>
> +Optional properties:
> +These below properties are optional to define.
This line is superfluous. Please remove it.
I will remove it. I am assuming only 1 line to remove.
> +
> - memory-region: A phandle to a reserved_memory region to be used for the LPC
> to AHB mapping
>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-29 23:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-18 20:15 [PATCH v2] dt-bindings: aspeed-lpc: Make parameter optional Vijay Khemka
2019-01-29 12:30 ` Lee Jones
2019-01-29 23:00 ` Vijay Khemka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).