* [PATCH v2 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy
@ 2019-01-25 16:20 Lucas Stach
2019-01-25 16:20 ` [PATCH v2 2/2] arm64: imx8mq: select GPCv2 irqchip driver Lucas Stach
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Lucas Stach @ 2019-01-25 16:20 UTC (permalink / raw)
To: Shawn Guo
Cc: Fabio Estevam, patchwork-lst, NXP Linux Team,
Pengutronix Kernel Team, linux-arm-kernel
The GPCv2 sits between most of the peripherals and the GIC and
functions as a wakeup controller for the CPU cores.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 5bd1f106ed84..af2584d51fa2 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -11,8 +11,7 @@
#include "imx8mq-pinfunc.h"
/ {
- /* This should really be the GPC, but we need a driver for this first */
- interrupt-parent = <&gic>;
+ interrupt-parent = <&gpc>;
#address-cells = <2>;
#size-cells = <2>;
@@ -257,6 +256,9 @@
gpc: gpc@303a0000 {
compatible = "fsl,imx8mq-gpc";
reg = <0x303a0000 0x10000>;
+ interrupt-parent = <&gic>;
+ interrupt-controller;
+ #interrupt-cells = <3>;
pgc {
#address-cells = <1>;
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] arm64: imx8mq: select GPCv2 irqchip driver
2019-01-25 16:20 [PATCH v2 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy Lucas Stach
@ 2019-01-25 16:20 ` Lucas Stach
2019-01-25 16:45 ` Fabio Estevam
2019-01-25 16:44 ` [PATCH v2 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy Fabio Estevam
2019-02-01 7:03 ` Shawn Guo
2 siblings, 1 reply; 6+ messages in thread
From: Lucas Stach @ 2019-01-25 16:20 UTC (permalink / raw)
To: Shawn Guo
Cc: Fabio Estevam, patchwork-lst, NXP Linux Team,
Pengutronix Kernel Team, linux-arm-kernel
The system is unable to boot without this driver being present,
as most of the peripherals are connected to this IRQ controller.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
arch/arm64/Kconfig.platforms | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index 251ecf34cb02..f4e45c52aea4 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -146,6 +146,7 @@ config ARCH_MXC
bool "ARMv8 based NXP i.MX SoC family"
select ARM64_ERRATUM_843419
select ARM64_ERRATUM_845719
+ select IMX_GPCV2
help
This enables support for the ARMv8 based SoCs in the
NXP i.MX family.
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy
2019-01-25 16:20 [PATCH v2 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy Lucas Stach
2019-01-25 16:20 ` [PATCH v2 2/2] arm64: imx8mq: select GPCv2 irqchip driver Lucas Stach
@ 2019-01-25 16:44 ` Fabio Estevam
2019-02-01 6:49 ` Shawn Guo
2019-02-01 7:03 ` Shawn Guo
2 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2019-01-25 16:44 UTC (permalink / raw)
To: Lucas Stach
Cc: patchwork-lst, NXP Linux Team, Pengutronix Kernel Team,
Fabio Estevam, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Hi Lucas,
On Fri, Jan 25, 2019 at 2:21 PM Lucas Stach <l.stach@pengutronix.de> wrote:
>
> The GPCv2 sits between most of the peripherals and the GIC and
> functions as a wakeup controller for the CPU cores.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
In order to avoid boot issues during bisection, please invert the
order of the patches in the series, then you can add:
Reviewed-by: Fabio Estevam <festevam@gmail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] arm64: imx8mq: select GPCv2 irqchip driver
2019-01-25 16:20 ` [PATCH v2 2/2] arm64: imx8mq: select GPCv2 irqchip driver Lucas Stach
@ 2019-01-25 16:45 ` Fabio Estevam
0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2019-01-25 16:45 UTC (permalink / raw)
To: Lucas Stach
Cc: patchwork-lst, NXP Linux Team, Pengutronix Kernel Team,
Fabio Estevam, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Fri, Jan 25, 2019 at 2:20 PM Lucas Stach <l.stach@pengutronix.de> wrote:
>
> The system is unable to boot without this driver being present,
> as most of the peripherals are connected to this IRQ controller.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Putting this one as the first patch in this series:
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy
2019-01-25 16:44 ` [PATCH v2 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy Fabio Estevam
@ 2019-02-01 6:49 ` Shawn Guo
0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2019-02-01 6:49 UTC (permalink / raw)
To: Fabio Estevam
Cc: patchwork-lst, NXP Linux Team, Pengutronix Kernel Team,
Fabio Estevam,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Lucas Stach
On Fri, Jan 25, 2019 at 02:44:24PM -0200, Fabio Estevam wrote:
> Hi Lucas,
>
> On Fri, Jan 25, 2019 at 2:21 PM Lucas Stach <l.stach@pengutronix.de> wrote:
> >
> > The GPCv2 sits between most of the peripherals and the GIC and
> > functions as a wakeup controller for the CPU cores.
> >
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
>
> In order to avoid boot issues during bisection, please invert the
> order of the patches in the series, then you can add:
Two patches will go via different branches, i.e. imx/soc and imx/dt64.
Since we always send imx/soc before imx/dt64, so it should be fine.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy
2019-01-25 16:20 [PATCH v2 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy Lucas Stach
2019-01-25 16:20 ` [PATCH v2 2/2] arm64: imx8mq: select GPCv2 irqchip driver Lucas Stach
2019-01-25 16:44 ` [PATCH v2 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy Fabio Estevam
@ 2019-02-01 7:03 ` Shawn Guo
2 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2019-02-01 7:03 UTC (permalink / raw)
To: Lucas Stach
Cc: Fabio Estevam, patchwork-lst, NXP Linux Team,
Pengutronix Kernel Team, linux-arm-kernel
On Fri, Jan 25, 2019 at 05:20:33PM +0100, Lucas Stach wrote:
> The GPCv2 sits between most of the peripherals and the GIC and
> functions as a wakeup controller for the CPU cores.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Applied both, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-01 7:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-25 16:20 [PATCH v2 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy Lucas Stach
2019-01-25 16:20 ` [PATCH v2 2/2] arm64: imx8mq: select GPCv2 irqchip driver Lucas Stach
2019-01-25 16:45 ` Fabio Estevam
2019-01-25 16:44 ` [PATCH v2 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy Fabio Estevam
2019-02-01 6:49 ` Shawn Guo
2019-02-01 7:03 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).