Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
	Shawn Guo <shawnguo@kernel.org>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 04/15] ARM: dts: imx6qdl-phytec-pbab01/pfla02: Use explicit swpad values
Date: Tue, 12 Feb 2019 09:24:34 +0100
Message-ID: <20190212082433.zuxowda75huzewxc@pengutronix.de> (raw)
In-Reply-To: <20190212081545.z2dwoddnm2idsvne@pengutronix.de>

On Tue, Feb 12, 2019 at 09:15:45AM +0100, Marco Felsch wrote:
> Hi Uwe,
> 
> On 19-02-11 15:13, Uwe Kleine-König wrote:
> > Instead of relying on reset defaults or a bootloader to configure
> > use explicit values for the swpad configuration. Here the reset
> > defaults of the i.MX6dl are used owing to lack of other evidence. (They
> > differ from the i.MX6q defaults for GPIO_0 and KEY_ROW4.)
> 
> Rely on the reset/bootloader values isn't that good at all. Since the
> bootloader use case can be different. I've checked your patch against a
> vanilla barebox (bootloader) which includes this devicetree. My test
> setup was a imx6q pfla02 SoM and a pbab01 baseboard. Please look my
> comment below.
> 
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> >  arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 20 ++++++++++----------
> >  1 file changed, 10 insertions(+), 10 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> > index 1b50b01e9bac..8e04ab7df2d7 100644
> > --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> > @@ -211,11 +211,11 @@
> >  	imx6q-phytec-pfla02 {
> >  		pinctrl_hog: hoggrp {
> >  			fsl,pins = <
> > -				MX6QDL_PAD_EIM_D23__GPIO3_IO23 0x80000000
> > -				MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24 0x80000000 /* SPI NOR chipselect */
> > -				MX6QDL_PAD_SD4_DAT1__GPIO2_IO09  0x80000000 /* PMIC interrupt */
> > -				MX6QDL_PAD_ENET_TXD0__GPIO1_IO30 0x80000000 /* Green LED */
> > -				MX6QDL_PAD_EIM_EB3__GPIO2_IO31 0x80000000 /* Red LED */
> > +				MX6QDL_PAD_EIM_D23__GPIO3_IO23		0x1b0b0
> > +				MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24	0x1b0b0 /* SPI NOR chipselect */
> > +				MX6QDL_PAD_SD4_DAT1__GPIO2_IO09		0x1b0b0 /* PMIC interrupt */
> > +				MX6QDL_PAD_ENET_TXD0__GPIO1_IO30	0x1b0b0 /* Green LED */
> > +				MX6QDL_PAD_EIM_EB3__GPIO2_IO31		0x1b0b1 /* Red LED */
> 
> Don't wanna nitpick, the MX6QDL_PAD_EIM_EB3__GPIO2_IO31 pad should be
> configured to 0x1b0b0 too, but I don't know the default imx6dl
> behaviour as you mentioned above. So I'm fine with the patch.

This is a bug in my linter's data table. EIM_EB3 should use 0x1b0b0 on
both imx6q and imx6dl.

I will wait a bit more for feedback, and then probably respin with this
fixed. Thanks for your input.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply index

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-11 14:13 [PATCH 01/15] ARM: dts: imx6qdl-fdi-fs700-m60: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 02/15] ARM: dts: imx6qdl-cubox-i: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 03/15] ARM: dts: imx6qdl-hummingboard: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 04/15] ARM: dts: imx6qdl-phytec-pbab01/pfla02: " Uwe Kleine-König
2019-02-12  8:15   ` Marco Felsch
2019-02-12  8:24     ` Uwe Kleine-König [this message]
2019-02-11 14:13 ` [PATCH 05/15] ARM: dts: imx6qdl-rex-*: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 06/15] ARM: dts: imx6qdl-sabreauto: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 07/15] ARM: dts: imx6qdl-udoo: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 08/15] ARM: dts: imx6qdl-wandboard-*: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 09/15] ARM: dts: imx6q-arm2: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 10/15] ARM: dts: imx6q-mccmon6: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 11/15] ARM: dts: imx6q-dmo-edmqmx6: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 12/15] ARM: dts: imx6qdl-aristainetos2: fix swpad values for reserved values Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 13/15] ARM: dts: imx6qdl-aristainetos: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 14/15] ARM: dts: imx6qdl-colibri: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 15/15] ARM: dts: imx6qdl-ts7970: " Uwe Kleine-König
2019-02-28  2:47 ` [PATCH 01/15] ARM: dts: imx6qdl-fdi-fs700-m60: Use explicit swpad values Shawn Guo

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190212082433.zuxowda75huzewxc@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=m.felsch@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org infradead-linux-arm-kernel@archiver.kernel.org
	public-inbox-index linux-arm-kernel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox