From: Mark Brown <broonie@kernel.org>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
DTML <devicetree@vger.kernel.org>, arm-soc <arm@kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Lyra Zhang <zhang.lyra@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Olof Johansson <olof@lixom.net>,
Orson Zhai <orsonzhai@gmail.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 0/4] Add new device nodes for Spreadtrum SC9860 platform
Date: Tue, 12 Feb 2019 12:20:35 +0000 [thread overview]
Message-ID: <20190212122035.GA20635@sirena.org.uk> (raw)
In-Reply-To: <CAMz4kuJdPts31Ak-H=VAivvoqqPtxO5M1RdqrNPwTLT5d1h_7w@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1099 bytes --]
On Tue, Feb 12, 2019 at 04:40:10PM +0800, Baolin Wang wrote:
> On Fri, 1 Feb 2019 at 21:05, Mark Brown <broonie@kernel.org> wrote:
> > You can just list all the individual device names in the of_match_table
> > for the MFD and then it can bind to any of them. You can always map
> > them onto the same behaviour in the MFD driver if they are identical
> > from a software point of view.
> If I understood correctly, as you suggested, we should add new
> mfd_cell groups to list all different PMICs' device names. Something
> like:
I do think this is a good idea (registering the components of the MFD
using mfd_cell), though it wasn't quite the point I was making. Having
individual device names matters less for Linux-internal names like this.
> But from my point, they are just some meaningless duplication, and
> will waste lots of code there.
I was more thinking of the of_match table that has the IDs that appear
in DT - they're the one that's the ABI. Look at something like wm8994
where the driver has several IDs listed in the main table then selects
function drivers based on that.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-12 12:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 7:38 [PATCH 0/4] Add new device nodes for Spreadtrum SC9860 platform Baolin Wang
2019-01-21 7:38 ` [PATCH 1/4] arm64: dts: sprd: Remove PMIC INTC irq trigger type Baolin Wang
2019-01-21 7:38 ` [PATCH 2/4] arm64: dts: sprd: Add ADC calibration support Baolin Wang
2019-01-21 7:38 ` [PATCH 3/4] arm64: dts: sprd: Add SC2731 charger device Baolin Wang
2019-01-30 16:45 ` Arnd Bergmann
2019-01-21 7:38 ` [PATCH 4/4] arm64: dts: sprd: Add SC27XX fuel gauge device Baolin Wang
2019-01-30 16:46 ` [PATCH 0/4] Add new device nodes for Spreadtrum SC9860 platform Arnd Bergmann
2019-02-01 12:05 ` Baolin Wang
2019-02-01 13:05 ` Mark Brown
2019-02-12 8:40 ` Baolin Wang
2019-02-12 12:20 ` Mark Brown [this message]
2019-02-13 5:45 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212122035.GA20635@sirena.org.uk \
--to=broonie@kernel.org \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=baolin.wang@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).