From: Arnd Bergmann <arnd@arndb.de>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
DTML <devicetree@vger.kernel.org>, arm-soc <arm@kernel.org>,
Lyra Zhang <zhang.lyra@gmail.com>,
Mark Brown <broonie@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Olof Johansson <olof@lixom.net>,
Orson Zhai <orsonzhai@gmail.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/4] arm64: dts: sprd: Add SC2731 charger device
Date: Wed, 30 Jan 2019 17:45:43 +0100 [thread overview]
Message-ID: <CAK8P3a2+N9-uLi0GS07JEt3H5hwoku6DWZr+e2DXP-nYHEcOyw@mail.gmail.com> (raw)
In-Reply-To: <1f57f120e915ea9af75a45f48c8ef2f446d10486.1548052878.git.baolin.wang@linaro.org>
On Mon, Jan 21, 2019 at 8:39 AM Baolin Wang <baolin.wang@linaro.org> wrote:
>
> Add charger device node and related battery node for SC2731 PMIC.
>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> ---
> arch/arm64/boot/dts/sprd/sc2731.dtsi | 6 ++++++
> arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 16 ++++++++++++++++
> 2 files changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/sprd/sc2731.dtsi b/arch/arm64/boot/dts/sprd/sc2731.dtsi
> index a2edc25..b52eaf0 100644
> --- a/arch/arm64/boot/dts/sprd/sc2731.dtsi
> +++ b/arch/arm64/boot/dts/sprd/sc2731.dtsi
> @@ -17,6 +17,12 @@
> #address-cells = <1>;
> #size-cells = <0>;
>
> + charger@0 {
> + compatible = "sprd,sc27xx-charger", "sprd,sc2731-charger";
> + reg = <0x0>;
> + monitored-battery = <&bat>;
> + };
I see some of these have already slipped through, but we should probably
fix those and not add new ones: "sprd,sc27xx-charger" is not an appropriate
compatible string, because it has a 'xx' wildcard.
What you should have instead is to list compatibility with specific older
models. You also need to have the more generic string as the last one,
not the first.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-30 16:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 7:38 [PATCH 0/4] Add new device nodes for Spreadtrum SC9860 platform Baolin Wang
2019-01-21 7:38 ` [PATCH 1/4] arm64: dts: sprd: Remove PMIC INTC irq trigger type Baolin Wang
2019-01-21 7:38 ` [PATCH 2/4] arm64: dts: sprd: Add ADC calibration support Baolin Wang
2019-01-21 7:38 ` [PATCH 3/4] arm64: dts: sprd: Add SC2731 charger device Baolin Wang
2019-01-30 16:45 ` Arnd Bergmann [this message]
2019-01-21 7:38 ` [PATCH 4/4] arm64: dts: sprd: Add SC27XX fuel gauge device Baolin Wang
2019-01-30 16:46 ` [PATCH 0/4] Add new device nodes for Spreadtrum SC9860 platform Arnd Bergmann
2019-02-01 12:05 ` Baolin Wang
2019-02-01 13:05 ` Mark Brown
2019-02-12 8:40 ` Baolin Wang
2019-02-12 12:20 ` Mark Brown
2019-02-13 5:45 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a2+N9-uLi0GS07JEt3H5hwoku6DWZr+e2DXP-nYHEcOyw@mail.gmail.com \
--to=arnd@arndb.de \
--cc=arm@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).