From: Andrew Lunn <andrew@lunn.ch>
To: Christophe Roullier <christophe.roullier@st.com>
Cc: mark.rutland@arm.com, robh@kernel.org, alexandre.torgue@st.com,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com, joabreu@synopsys.com,
mcoquelin.stm32@gmail.com, peppe.cavallaro@st.com,
davem@davemloft.net, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/8] net: ethernet: stmmac: update to support all PHY config for stm32mp157c.
Date: Thu, 14 Feb 2019 14:40:40 +0100 [thread overview]
Message-ID: <20190214134040.GA5699@lunn.ch> (raw)
In-Reply-To: <1550126763-22669-3-git-send-email-christophe.roullier@st.com>
On Thu, Feb 14, 2019 at 07:45:57AM +0100, Christophe Roullier wrote:
> @@ -131,19 +185,19 @@ static int stm32mp1_set_mode(struct plat_stmmacenet_data *plat_dat)
> case PHY_INTERFACE_MODE_RGMII:
> val = SYSCFG_PMCR_ETH_SEL_RGMII;
> - if (dwmac->int_phyclk)
> + if (dwmac->eth_clk_sel_reg)
> val |= SYSCFG_PMCR_ETH_CLK_SEL;
> pr_debug("SYSCFG init : PHY_INTERFACE_MODE_RGMII\n");
> break;
Hi Christophe
This code should handle all 4 PHY_INTERFACE_MODE_RGMII* values.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-14 13:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 6:45 [PATCH 0/8] stmmac: add some fixes for stm32 Christophe Roullier
2019-02-14 6:45 ` [PATCH 1/8] net: ethernet: stmmac: manage Ethernet WoL for stm32mp157c Christophe Roullier
2019-02-14 6:45 ` [PATCH 2/8] net: ethernet: stmmac: update to support all PHY config " Christophe Roullier
2019-02-14 13:40 ` Andrew Lunn [this message]
2019-02-14 14:48 ` Christophe ROULLIER
2019-02-14 15:00 ` Christophe ROULLIER
2019-02-14 15:15 ` Andrew Lunn
2019-02-14 15:51 ` Christophe ROULLIER
2019-02-14 6:45 ` [PATCH 3/8] dt-bindings: net: stmmac: add phys config properties Christophe Roullier
2019-02-14 6:45 ` [PATCH 4/8] net: ethernet: stmmac: add management of clk_csr property Christophe Roullier
2019-02-14 6:46 ` [PATCH 5/8] net: ethernet: stmmac: update to be compatible with MCU family (stm32f4, stm32h7) Christophe Roullier
2019-02-14 6:46 ` [PATCH 6/8] dt-bindings: net: stmmac: add syscfg clock property Christophe Roullier
2019-02-14 6:46 ` [PATCH 7/8] ARM: dts: stm32: Add Ethernet support on stm32h7 SOC and activate it for eval and disco boards Christophe Roullier
2019-02-14 13:44 ` Andrew Lunn
2019-02-14 14:55 ` Christophe ROULLIER
2019-02-14 6:46 ` [PATCH 8/8] ARM: dts: stm32: add syscfg clock support for Ethernet on STM32F429 SoC Christophe Roullier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214134040.GA5699@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@st.com \
--cc=christophe.roullier@st.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=joabreu@synopsys.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).