From: Will Deacon <will.deacon@arm.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: mark.rutland@arm.com, Steve.Capper@arm.com, marc.zyngier@arm.com,
Catalin.Marinas@arm.com, suzuki.poulose@arm.com,
james.morse@arm.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/6] arm64/mm: Call pgtable_page_dtor() for both PMD and PUD page table pages
Date: Thu, 14 Feb 2019 17:11:08 +0000 [thread overview]
Message-ID: <20190214171108.GE2475@fuggles.cambridge.arm.com> (raw)
In-Reply-To: <1548307220-19756-6-git-send-email-anshuman.khandual@arm.com>
On Thu, Jan 24, 2019 at 10:50:19AM +0530, Anshuman Khandual wrote:
> TLB flush during PMD and PUD level page table page tear down currently does
> not call pgtable_page_dtor() like that for PTE page table pages. Now that
> all the page table pages which are allocated from the buddy allocator must
> have been initialized through pgtable_page_ctor() they must be freed back
> only after being called into pgtable_page_dtor() destructor. Else these
> pages might run into bad page state errors while getting freed into buddy
> allocator.
>
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> arch/arm64/include/asm/tlb.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/include/asm/tlb.h b/arch/arm64/include/asm/tlb.h
> index 106fdc9..de46ba0 100644
> --- a/arch/arm64/include/asm/tlb.h
> +++ b/arch/arm64/include/asm/tlb.h
> @@ -62,6 +62,7 @@ static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte,
> static inline void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmdp,
> unsigned long addr)
> {
> + pgtable_page_dtor(virt_to_page(pmdp));
> tlb_remove_table(tlb, virt_to_page(pmdp));
> }
> #endif
> @@ -70,6 +71,7 @@ static inline void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmdp,
> static inline void __pud_free_tlb(struct mmu_gather *tlb, pud_t *pudp,
> unsigned long addr)
> {
> + pgtable_page_dtor(virt_to_page(pudp));
> tlb_remove_table(tlb, virt_to_page(pudp));
This would be cleaner if you assigned to a temporary struct page * variable.
With that:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-14 17:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 5:20 [PATCH 0/6] arm64/mm: Enable accounting for page table pages Anshuman Khandual
2019-01-24 5:20 ` [PATCH 1/6] KVM: ARM: Remove pgtable standard functions from stage-2 page tables Anshuman Khandual
2019-01-24 5:20 ` [PATCH 2/6] arm64/mm: Ensure PGD kmem cache object is actually allocated Anshuman Khandual
2019-01-24 15:16 ` Catalin Marinas
2019-01-25 4:59 ` Anshuman Khandual
2019-01-24 5:20 ` [PATCH 3/6] arm64/mm: Make pgd_pgtable_alloc() call pte_alloc_one() always Anshuman Khandual
2019-02-14 17:11 ` Will Deacon
2019-02-19 4:33 ` Anshuman Khandual
2019-01-24 5:20 ` [PATCH 4/6] arm64/mm: Make all page table pages cycles through standard constructs Anshuman Khandual
2019-01-24 5:20 ` [PATCH 5/6] arm64/mm: Call pgtable_page_dtor() for both PMD and PUD page table pages Anshuman Khandual
2019-02-14 17:11 ` Will Deacon [this message]
2019-02-19 4:34 ` Anshuman Khandual
2019-01-24 5:20 ` [PATCH 6/6] arm64/mm: Enable page table page accounting for user space Anshuman Khandual
2019-02-14 17:11 ` Will Deacon
2019-02-19 4:49 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214171108.GE2475@fuggles.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=Steve.Capper@arm.com \
--cc=anshuman.khandual@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).