From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: mark.rutland@arm.com, suzuki.poulose@arm.com,
marc.zyngier@arm.com, Steve.Capper@arm.com, will.deacon@arm.com,
james.morse@arm.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/6] arm64/mm: Ensure PGD kmem cache object is actually allocated
Date: Fri, 25 Jan 2019 10:29:47 +0530 [thread overview]
Message-ID: <30550513-697f-1fd1-70c9-03d376368a67@arm.com> (raw)
In-Reply-To: <20190124151655.GH253679@arrakis.emea.arm.com>
On 01/24/2019 08:46 PM, Catalin Marinas wrote:
> On Thu, Jan 24, 2019 at 10:50:16AM +0530, Anshuman Khandual wrote:
>> 'pgd_cache' is created for allocating non PAGE_SIZE based PGD pointers. In
>> such cases ensure that the kmem cache object is allocated before proceeding
>> further with boot.
>>
>> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
>> ---
>> arch/arm64/mm/pgd.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/mm/pgd.c b/arch/arm64/mm/pgd.c
>> index 289f911..8cb4e39 100644
>> --- a/arch/arm64/mm/pgd.c
>> +++ b/arch/arm64/mm/pgd.c
>> @@ -62,4 +62,5 @@ void __init pgd_cache_init(void)
>> */
>> pgd_cache = kmem_cache_create("pgd_cache", PGD_SIZE, PGD_SIZE,
>> SLAB_PANIC, NULL);
>> + BUG_ON(!pgd_cache);
>
> Isn't SLAB_PANIC sufficient here?
It should be sufficient as it calls panic(). Please drop this patch from consideration.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-25 5:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 5:20 [PATCH 0/6] arm64/mm: Enable accounting for page table pages Anshuman Khandual
2019-01-24 5:20 ` [PATCH 1/6] KVM: ARM: Remove pgtable standard functions from stage-2 page tables Anshuman Khandual
2019-01-24 5:20 ` [PATCH 2/6] arm64/mm: Ensure PGD kmem cache object is actually allocated Anshuman Khandual
2019-01-24 15:16 ` Catalin Marinas
2019-01-25 4:59 ` Anshuman Khandual [this message]
2019-01-24 5:20 ` [PATCH 3/6] arm64/mm: Make pgd_pgtable_alloc() call pte_alloc_one() always Anshuman Khandual
2019-02-14 17:11 ` Will Deacon
2019-02-19 4:33 ` Anshuman Khandual
2019-01-24 5:20 ` [PATCH 4/6] arm64/mm: Make all page table pages cycles through standard constructs Anshuman Khandual
2019-01-24 5:20 ` [PATCH 5/6] arm64/mm: Call pgtable_page_dtor() for both PMD and PUD page table pages Anshuman Khandual
2019-02-14 17:11 ` Will Deacon
2019-02-19 4:34 ` Anshuman Khandual
2019-01-24 5:20 ` [PATCH 6/6] arm64/mm: Enable page table page accounting for user space Anshuman Khandual
2019-02-14 17:11 ` Will Deacon
2019-02-19 4:49 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30550513-697f-1fd1-70c9-03d376368a67@arm.com \
--to=anshuman.khandual@arm.com \
--cc=Steve.Capper@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).