From: Darren Hart <dvhart@infradead.org>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
platform-driver-x86@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Andy Shevchenko <andy@infradead.org>
Subject: Re: [PATCH v5 06/10] Platform: OLPC: Add XO-1.75 EC driver
Date: Wed, 20 Feb 2019 17:22:31 -0800 [thread overview]
Message-ID: <20190221012231.GC5838@wrath> (raw)
In-Reply-To: <20190110175845.1203986-7-lkundrak@v3.sk>
On Thu, Jan 10, 2019 at 06:58:41PM +0100, Lubomir Rintel wrote:
> It's based off the driver from the OLPC kernel sources. Somewhat
> modernized and cleaned up, for better or worse.
>
> Modified to plug into the olpc-ec driver infrastructure (so that battery
> interface and debugfs could be reused) and the SPI slave framework.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
>
> ---
> Changes since v4:
> - Chop off the reboot handler. Will be added back once it's clear how.
>
> Changes since v3:
> - Introduce CONFIG_OLPC_EC symbol to enable parts common to this driver
> and the X86 OLPC EC machinery.
>
> Changes since v1:
> - Cosmetic style changes; whitespace, ordering of declarations and
> #includes, remoted extra comas from sentinels
> - Count the terminating NUL in LOG_BUF_SIZE
> - Make olpc_xo175_ec_is_valid_cmd() return -EINVAL instead of -1
> on error
> - Spell keyboard/touchpad in full for CHAN_KEYBOARD/TOUCHPAD messages
> - Use a #define for PM wakeup processing time
> - Log a message on unknown event
> - Escape logging payload with %*pE
> - Replace an open-coded min()
> - Correct an error code on short read
> - replaced PM callback #ifdefs with __maybe_unusedm SET_RUNTIME_PM_OPS
> and SET_NOIRQ_SYSTEM_SLEEP_PM_OPS
> - dev_get_drvdata() instead of a round-trip through platform device
> - s/unsigned char x/u8 x/ in olpc_xo175_ec_resume()
> - Use GENMASK() instead of 0xffff for the event mask
> - Replace cmd tx/resp rx buffers with structures
> - Turned suspend hint arguments into a struct, and tidied up the comment
>
> Basically all of the above is based on the review by Andy Shevchenko.
Andy, I am happy to merge this series - but this patch includes a lot of changes
driven by your feedback. Are you satisfied with the changes, would you like to
add your Reviewed-by?
--
Darren Hart
VMware Open Source Technology Center
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-21 1:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 17:58 [PATCH v5 0/10] Add support for OLPC XO 1.75 Embedded Controller Lubomir Rintel
2019-01-10 17:58 ` [PATCH v5 01/10] dt-bindings: olpc, xo1.75-ec: Add OLPC XO-1.75 EC bindings Lubomir Rintel
2019-01-11 14:36 ` [PATCH v5 01/10] dt-bindings: olpc,xo1.75-ec: " Rob Herring
2019-02-21 1:21 ` Darren Hart
2019-01-10 17:58 ` [PATCH v5 02/10] Platform: OLPC: Remove an unused include Lubomir Rintel
2019-01-10 17:58 ` [PATCH v5 03/10] Platform: OLPC: Move EC-specific functionality out from x86 Lubomir Rintel
2019-01-10 17:58 ` [PATCH v5 04/10] Platform: OLPC: Avoid a warning if the EC didn't register yet Lubomir Rintel
2019-01-10 17:58 ` [PATCH v5 05/10] Platform: OLPC: Use BIT() and GENMASK() for event masks Lubomir Rintel
2019-01-10 17:58 ` [PATCH v5 06/10] Platform: OLPC: Add XO-1.75 EC driver Lubomir Rintel
2019-02-21 1:22 ` Darren Hart [this message]
2019-02-21 13:28 ` Andy Shevchenko
2019-01-10 17:58 ` [PATCH v5 07/10] Platform: OLPC: Add a regulator for the DCON Lubomir Rintel
2019-01-10 17:58 ` [PATCH v5 08/10] power: supply: olpc_battery: Allow building the driver on non-x86 Lubomir Rintel
2019-02-19 23:17 ` Sebastian Reichel
2019-01-10 17:58 ` [PATCH v5 09/10] ARM: export arm_pm_restart Lubomir Rintel
2019-01-10 17:58 ` [PATCH v5 10/10] Platform: OLPC: Add restart support to XO-1.75 EC driver Lubomir Rintel
2019-02-11 11:46 ` [PATCH v5 0/10] Add support for OLPC XO 1.75 Embedded Controller Lubomir Rintel
2019-02-11 11:49 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221012231.GC5838@wrath \
--to=dvhart@infradead.org \
--cc=andy@infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lkundrak@v3.sk \
--cc=mark.rutland@arm.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).