linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* Regression in Linux next with dma cma changes
@ 2019-02-26 20:01 Tony Lindgren
  2019-02-26 20:15 ` Nicolin Chen
  0 siblings, 1 reply; 2+ messages in thread
From: Tony Lindgren @ 2019-02-26 20:01 UTC (permalink / raw)
  To: Nicolin Chen, Christoph Hellwig
  Cc: linux-kernel, dri-devel, Sebastian Reichel, Tomi Valkeinen,
	Laurent Pinchart, linux-omap, linux-arm-kernel, Marek Szyprowski

Hi,

Looks like commit d222e42e8816 ("dma-contiguous: do not allocate a
single page from CMA area") caused a regression at least for
omap dss where we now get the following error on init:

omapdss_dispc 58001000.dispc:
dispc_errata_i734_wa_init: dma_alloc_writecombine failed

Any ideas what might be going wrong?

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Regression in Linux next with dma cma changes
  2019-02-26 20:01 Regression in Linux next with dma cma changes Tony Lindgren
@ 2019-02-26 20:15 ` Nicolin Chen
  0 siblings, 0 replies; 2+ messages in thread
From: Nicolin Chen @ 2019-02-26 20:15 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: linux-kernel, dri-devel, Sebastian Reichel, Tomi Valkeinen,
	Laurent Pinchart, linux-omap, Christoph Hellwig,
	linux-arm-kernel, Marek Szyprowski

On Tue, Feb 26, 2019 at 12:01:55PM -0800, Tony Lindgren wrote:
> Looks like commit d222e42e8816 ("dma-contiguous: do not allocate a
> single page from CMA area") caused a regression at least for
> omap dss where we now get the following error on init:
> 
> omapdss_dispc 58001000.dispc:
> dispc_errata_i734_wa_init: dma_alloc_writecombine failed
> 
> Any ideas what might be going wrong?

It's probably because the dma_alloc_from_contiguous() call in
this path doesn't rebound to allocate a normal single page.

And I guess we should have left the change within dma-direct.

Christoph, do you agree?

I am submitting a revert first.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-02-26 20:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-26 20:01 Regression in Linux next with dma cma changes Tony Lindgren
2019-02-26 20:15 ` Nicolin Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).