[PATCH v2 0/2] arm64: dts: renesas: ebisu: support S2RAM

[PATCH v2 0/2] arm64: dts: renesas: ebisu: support S2RAM

[Simon Horman]

Hi,

this short series supports S2RAM on R-Car E3 (r8a77990) / Ebisu by:

* Upporting description of  BD9571 PMIC in DT from BSP v3.9.2
* Adding DDR0 backpo power configuration to that description

Simon Horman (1):
  arm64: dts: renesas: ebisu: Add PMIC DDR0 Backup Power config

Takeshi Kihara (1):
  arm64: dts: renesas: r8a77990-ebisu: Add BD9571 PMIC

 arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 27 ++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

Tested using the following procedure with patches applied
on renesas-devel-20190308-v5.0 and kernel compiled using
renesas_defconfig.

1. Add no_console_suspend to kernel command line
2. Boot system
3. # echo on > /sys/bus/i2c/drivers/bd9571mwv/8-0030/bd9571mwv-regulator.0.auto/backup_mode
4. Toggle SW23 to off position
   System suspends with following displayed on console

   [   91.486537] PM: suspend entry (deep)
   [   91.490281] PM: Syncing filesystems ... done.
   [   91.500460] Freezing user space processes ... (elapsed 0.001 seconds)
   done.
   [   91.509392] OOM killer disabled.
   [   91.512679] Freezing remaining freezable tasks ... (elapsed 0.001
   seconds) done.
   [   91.531235] ravb e6800000.ethernet eth0: Link is Down
   [   91.670747] Disabling non-boot CPUs ...
   [   91.676106] CPU1: shutdown
   [   91.678932] psci: CPU1 killed.

5. Toggle SW23 to on position
   System resumes with the following output to the console

   INFO:    ARM GICv2 driver initialized
   NOTICE:  BL2: R-Car Gen3 Initial Program Loader(CA53) Rev.2.0.1
   NOTICE:  BL2: PRR is R-Car E3 Ver.1.0
   NOTICE:  BL2: PLL1 nonSSCG Clock select
   NOTICE:  BL2: Board is Ebisu-4D Rev.1.0
   NOTICE:  BL2: Boot device is HyperFlash(80MHz)
   NOTICE:  BL2: LCM state is CM
   NOTICE:  BL2: DDR1856(rev.0.11)
   NOTICE:  BL2: [WARM_BOOT]
   NOTICE:  BL2: DRAM Split is OFF
   NOTICE:  BL2: QoS is default setting(rev.0.05)
   NOTICE:  BL2: DRAM refresh interval 3.9 usec
   NOTICE:  BL2: CH0: 400000000 - 47fffffff, 2 GiB
   NOTICE:  BL2: FDT at 0xe63145d8
   NOTICE:  BL2: v2.0(release):v2.0-986-gc48d02bade88-dirty
   NOTICE:  BL2: Built : 09:27:42, Mar 11 2019
   NOTICE:  BL2: Normal boot
   INFO:    BL2: Doing platform setup
   [   91.683834] Enabling non-boot CPUs ...
   [   91.688141] Detected VIPT I-cache on CPU1
   [   91.688231] CPU1: Booted secondary processor 0x0000000001 [0x410fd034]
   [   91.689094]  cache: parent cpu1 should not be sleeping
   [   91.705420] CPU1 is up
   [   91.840419] usb usb2: root hub lost power or was reset
   [   91.845755] usb usb1: root hub lost power or was reset
   [   91.973264] Micrel KSZ9031 Gigabit PHY e6800000.ethernet-ffffffff:00: attached PHY driver [Micrel KSZ9031 Gigabit PHY] (mii_bus:phy_addr=e6800000.ethernet-ffffffff:00, irq=169)
   [   92.064085] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
   [   92.070904] OOM killer enabled.
   [   92.074096] Restarting tasks ...
   [   92.074158] [drm] No driver support for vblank timestamp query.
   [   92.085011] done.
   [   92.089628] PM: suspend exit
   [   92.096382] thc63lvd1024 lvds-decoder: Linked as a consumer to regulator.2
   [   92.103645] thc63lvd1024 lvds-decoder: Dropping the link to regulator.2
   [   97.553658] ravb e6800000.ethernet eth0: Link is Up - 1Gbps/Full - flow control off

-- 
2.11.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v2 1/2] arm64: dts: renesas: r8a77990-ebisu: Add BD9571 PMIC

[Simon Horman]

From: Takeshi Kihara <takeshi.kihara.df@renesas.com>

This patch adds the regulator definition required for operation of
S2RAM.

Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
index fb50f4fa8b9d..18a99d2e1ea5 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
@@ -449,6 +449,26 @@
 	};
 };
 
+&i2c_dvfs {
+	status = "okay";
+
+	clock-frequency = <400000>;
+
+	pmic: pmic@30 {
+		pinctrl-0 = <&irq0_pins>;
+		pinctrl-names = "default";
+
+		compatible = "rohm,bd9571mwv";
+		reg = <0x30>;
+		interrupt-parent = <&intc_ex>;
+		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-controller;
+		#interrupt-cells = <2>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+};
+
 &lvds0 {
 	status = "okay";
 
@@ -511,6 +531,11 @@
 		function = "du";
 	};
 
+	irq0_pins: irq0 {
+		groups = "intc_ex_irq0";
+		function = "intc_ex";
+	};
+
 	pwm3_pins: pwm3 {
 		groups = "pwm3_b";
 		function = "pwm3";
-- 
2.11.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v2 2/2] arm64: dts: renesas: ebisu: Add PMIC DDR0 Backup Power config

[Simon Horman]

On Ebisu the DDR0 power rail needs to be kept powered when backup mode is
enabled.  Reflect this in the "rohm,ddr-backup-power" property for the
BD9571MWV PMIC node.

The accessory power switch (SW23) is a toggle switch, hence specify
"rohm,rstbmode-level".

Based on advice from Geert Uytterhoeven.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
index 18a99d2e1ea5..0e873ccfd9e5 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
@@ -466,6 +466,8 @@
 		#interrupt-cells = <2>;
 		gpio-controller;
 		#gpio-cells = <2>;
+		rohm,ddr-backup-power = <0x1>;
+		rohm,rstbmode-level;
 	};
 };
 
-- 
2.11.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 0/2] arm64: dts: renesas: ebisu: support S2RAM

[Geert Uytterhoeven]

Hi Simon,

On Wed, Mar 13, 2019 at 11:58 AM Simon Horman
<horms+renesas@verge.net.au> wrote:
> this short series supports S2RAM on R-Car E3 (r8a77990) / Ebisu by:
>
> * Upporting description of  BD9571 PMIC in DT from BSP v3.9.2
> * Adding DDR0 backpo power configuration to that description
>
> Simon Horman (1):
>   arm64: dts: renesas: ebisu: Add PMIC DDR0 Backup Power config
>
> Takeshi Kihara (1):
>   arm64: dts: renesas: r8a77990-ebisu: Add BD9571 PMIC
>
>  arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 27 ++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> Tested using the following procedure with patches applied
> on renesas-devel-20190308-v5.0 and kernel compiled using
> renesas_defconfig.
>
> 1. Add no_console_suspend to kernel command line
> 2. Boot system
> 3. # echo on > /sys/bus/i2c/drivers/bd9571mwv/8-0030/bd9571mwv-regulator.0.auto/backup_mode
> 4. Toggle SW23 to off position

I think one step is missing here:

    # echo mem > /sys/power/state

>    System suspends with following displayed on console
>
>    [   91.486537] PM: suspend entry (deep)
>    [   91.490281] PM: Syncing filesystems ... done.
>    [   91.500460] Freezing user space processes ... (elapsed 0.001 seconds)
>    done.
>    [   91.509392] OOM killer disabled.
>    [   91.512679] Freezing remaining freezable tasks ... (elapsed 0.001
>    seconds) done.
>    [   91.531235] ravb e6800000.ethernet eth0: Link is Down
>    [   91.670747] Disabling non-boot CPUs ...
>    [   91.676106] CPU1: shutdown
>    [   91.678932] psci: CPU1 killed.
>
> 5. Toggle SW23 to on position
>    System resumes with the following output to the console

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 1/2] arm64: dts: renesas: r8a77990-ebisu: Add BD9571 PMIC

[Geert Uytterhoeven]

On Wed, Mar 13, 2019 at 11:59 AM Simon Horman
<horms+renesas@verge.net.au> wrote:
> From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>
> This patch adds the regulator definition required for operation of
> S2RAM.
>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 2/2] arm64: dts: renesas: ebisu: Add PMIC DDR0 Backup Power config

[Geert Uytterhoeven]

On Wed, Mar 13, 2019 at 11:58 AM Simon Horman
<horms+renesas@verge.net.au> wrote:
> On Ebisu the DDR0 power rail needs to be kept powered when backup mode is
> enabled.  Reflect this in the "rohm,ddr-backup-power" property for the
> BD9571MWV PMIC node.
>
> The accessory power switch (SW23) is a toggle switch, hence specify
> "rohm,rstbmode-level".
>
> Based on advice from Geert Uytterhoeven.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 0/2] arm64: dts: renesas: ebisu: support S2RAM

[Simon Horman]

On Wed, Mar 13, 2019 at 01:14:33PM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Wed, Mar 13, 2019 at 11:58 AM Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > this short series supports S2RAM on R-Car E3 (r8a77990) / Ebisu by:
> >
> > * Upporting description of  BD9571 PMIC in DT from BSP v3.9.2
> > * Adding DDR0 backpo power configuration to that description
> >
> > Simon Horman (1):
> >   arm64: dts: renesas: ebisu: Add PMIC DDR0 Backup Power config
> >
> > Takeshi Kihara (1):
> >   arm64: dts: renesas: r8a77990-ebisu: Add BD9571 PMIC
> >
> >  arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 27 ++++++++++++++++++++++++++
> >  1 file changed, 27 insertions(+)
> >
> > Tested using the following procedure with patches applied
> > on renesas-devel-20190308-v5.0 and kernel compiled using
> > renesas_defconfig.
> >
> > 1. Add no_console_suspend to kernel command line
> > 2. Boot system
> > 3. # echo on > /sys/bus/i2c/drivers/bd9571mwv/8-0030/bd9571mwv-regulator.0.auto/backup_mode
> > 4. Toggle SW23 to off position
> 
> I think one step is missing here:
> 
>     # echo mem > /sys/power/state

Yes, indeed.

> >    System suspends with following displayed on console
> >
> >    [   91.486537] PM: suspend entry (deep)
> >    [   91.490281] PM: Syncing filesystems ... done.
> >    [   91.500460] Freezing user space processes ... (elapsed 0.001 seconds)
> >    done.
> >    [   91.509392] OOM killer disabled.
> >    [   91.512679] Freezing remaining freezable tasks ... (elapsed 0.001
> >    seconds) done.
> >    [   91.531235] ravb e6800000.ethernet eth0: Link is Down
> >    [   91.670747] Disabling non-boot CPUs ...
> >    [   91.676106] CPU1: shutdown
> >    [   91.678932] psci: CPU1 killed.
> >
> > 5. Toggle SW23 to on position
> >    System resumes with the following output to the console
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 1/2] arm64: dts: renesas: r8a77990-ebisu: Add BD9571 PMIC

[Simon Horman]

On Wed, Mar 13, 2019 at 01:16:57PM +0100, Geert Uytterhoeven wrote:
> On Wed, Mar 13, 2019 at 11:59 AM Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> >
> > This patch adds the regulator definition required for operation of
> > S2RAM.
> >
> > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, applied for v5.2.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 2/2] arm64: dts: renesas: ebisu: Add PMIC DDR0 Backup Power config

[Simon Horman]

On Wed, Mar 13, 2019 at 01:17:30PM +0100, Geert Uytterhoeven wrote:
> On Wed, Mar 13, 2019 at 11:58 AM Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > On Ebisu the DDR0 power rail needs to be kept powered when backup mode is
> > enabled.  Reflect this in the "rohm,ddr-backup-power" property for the
> > BD9571MWV PMIC node.
> >
> > The accessory power switch (SW23) is a toggle switch, hence specify
> > "rohm,rstbmode-level".
> >
> > Based on advice from Geert Uytterhoeven.
> >
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, applied for v5.2.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel