[PATCH v3 0/2] spi: pxa2xx: Adjust DMA burst size per platform

[PATCH v3 0/2] spi: pxa2xx: Adjust DMA burst size per platform

[Andy Shevchenko]

On some platforms DMA burst size is not the same as hard coded default
Fix the driver to support them.

In v4:
- fix s/master/controller/g

In v3:
- drop threshold print since it's easy to calculate constant (Jarkko)
- split one more unrelated change to a separate patch,
  but independent from this series (Jarkko)

In v2:
- drop unrelated changes (Jarkko, Robert)
- don't include Robert's tag due to changes in the patch

Andy Shevchenko (2):
  spi: pxa2xx: Debug print DMA burst size
  spi: pxa2xx-pci: Drop unused header inclusion

 drivers/spi/spi-pxa2xx-pci.c | 1 -
 drivers/spi/spi-pxa2xx.c     | 3 +++
 2 files changed, 3 insertions(+), 1 deletion(-)

-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v4 1/2] spi: pxa2xx: Debug print DMA burst size

[Andy Shevchenko]

It's useful during debug to see what DMA burst size is.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/spi/spi-pxa2xx.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
index 461c6b796b8f..f008836f7e27 100644
--- a/drivers/spi/spi-pxa2xx.c
+++ b/drivers/spi/spi-pxa2xx.c
@@ -1333,6 +1333,9 @@ static int setup(struct spi_device *spi)
 			dev_warn(&spi->dev,
 				 "in setup: DMA burst size reduced to match bits_per_word\n");
 		}
+		dev_dbg(&spi->dev,
+			"in setup: DMA burst size set to %u\n",
+			chip->dma_burst_size);
 	}
 
 	switch (drv_data->ssp_type) {
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v4 2/2] spi: pxa2xx-pci: Drop unused header inclusion

[Andy Shevchenko]

There is nothing in the driver which requires OF specific header
to be included.

Remove it for good.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/spi/spi-pxa2xx-pci.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/spi/spi-pxa2xx-pci.c b/drivers/spi/spi-pxa2xx-pci.c
index 33029ca0687a..d456c5251b5d 100644
--- a/drivers/spi/spi-pxa2xx-pci.c
+++ b/drivers/spi/spi-pxa2xx-pci.c
@@ -5,7 +5,6 @@
  */
 #include <linux/clk-provider.h>
 #include <linux/module.h>
-#include <linux/of_device.h>
 #include <linux/pci.h>
 #include <linux/platform_device.h>
 #include <linux/spi/pxa2xx_spi.h>
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v3 0/2] spi: pxa2xx: Adjust DMA burst size per platform

[Andy Shevchenko]

On Tue, Mar 19, 2019 at 04:43:50PM +0200, Andy Shevchenko wrote:
> On some platforms DMA burst size is not the same as hard coded default
> Fix the driver to support them.

Oops, nor subject nor patches are correct in this series. I have sent v5
corrected.

Sorry for the noise.

> 
> In v4:
> - fix s/master/controller/g
> 
> In v3:
> - drop threshold print since it's easy to calculate constant (Jarkko)
> - split one more unrelated change to a separate patch,
>   but independent from this series (Jarkko)
> 
> In v2:
> - drop unrelated changes (Jarkko, Robert)
> - don't include Robert's tag due to changes in the patch
> 
> Andy Shevchenko (2):
>   spi: pxa2xx: Debug print DMA burst size
>   spi: pxa2xx-pci: Drop unused header inclusion
> 
>  drivers/spi/spi-pxa2xx-pci.c | 1 -
>  drivers/spi/spi-pxa2xx.c     | 3 +++
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> -- 
> 2.20.1
> 

-- 
With Best Regards,
Andy Shevchenko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v3 0/2] spi: pxa2xx: Adjust DMA burst size per platform

[Andy Shevchenko]

On Mon, Mar 18, 2019 at 04:41:42PM +0200, Andy Shevchenko wrote:
> On some platforms DMA burst size is not the same as hard coded default.
> Fix the driver to support them.
> 
> In v3:
> - drop threshold print since it's easy to calculate constant (Jarkko)
> - split one more unrelated change to a separate patch,
>   but independent from this series  (Jarkko)

Forgot to rebase.
It will not compile on v5.1-rc1 due to s/master/controller/g changes.

> 
> In v2:
> - drop unrelated changes (Jarkko, Robert)
> - don't include Robert's tag due to changes in the patch
> 
> Andy Shevchenko (2):
>   spi: pxa2xx: Introduce DMA burst size support
>   spi: pxa2xx: Debug print DMA burst size
> 
>  drivers/spi/spi-pxa2xx-dma.c   | 4 +++-
>  drivers/spi/spi-pxa2xx-pci.c   | 4 ++++
>  drivers/spi/spi-pxa2xx.c       | 4 ++++
>  include/linux/spi/pxa2xx_spi.h | 1 +
>  4 files changed, 12 insertions(+), 1 deletion(-)
> 
> -- 
> 2.20.1
> 

-- 
With Best Regards,
Andy Shevchenko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v3 0/2] spi: pxa2xx: Adjust DMA burst size per platform

[Andy Shevchenko]

On some platforms DMA burst size is not the same as hard coded default.
Fix the driver to support them.

In v3:
- drop threshold print since it's easy to calculate constant (Jarkko)
- split one more unrelated change to a separate patch,
  but independent from this series  (Jarkko)

In v2:
- drop unrelated changes (Jarkko, Robert)
- don't include Robert's tag due to changes in the patch

Andy Shevchenko (2):
  spi: pxa2xx: Introduce DMA burst size support
  spi: pxa2xx: Debug print DMA burst size

 drivers/spi/spi-pxa2xx-dma.c   | 4 +++-
 drivers/spi/spi-pxa2xx-pci.c   | 4 ++++
 drivers/spi/spi-pxa2xx.c       | 4 ++++
 include/linux/spi/pxa2xx_spi.h | 1 +
 4 files changed, 12 insertions(+), 1 deletion(-)

-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel