* [PATCH] arm64: dts: imx8mq: Move the opp table out of bus node
@ 2019-03-20 20:05 Fabio Estevam
2019-03-22 2:29 ` Shawn Guo
2019-03-25 18:07 ` Guido Günther
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2019-03-20 20:05 UTC (permalink / raw)
To: shawnguo; +Cc: linux-arm-kernel, Fabio Estevam, linux-imx, kernel, abel.vesa
Move opp-table node from soc node to root node.
opp-table node does not have any register properties and thus
shouldn't be placed inside the bus.
This fixes the following build warnings with W=1:
arch/arm64/boot/dts/freescale/imx8mq.dtsi:687.28-703.5: Warning (simple_bus_reg): /soc@0/opp-table: missing or empty reg/ranges property
Fixes: 64d26f8c1dde ("arm64: dts: imx8mq: Add the opp table and cores opp properties")
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 37 +++++++++++------------
1 file changed, 18 insertions(+), 19 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 32a02027df92..e02ef059bba0 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -132,6 +132,24 @@
};
};
+ a53_opp_table: opp-table {
+ compatible = "operating-points-v2";
+ opp-shared;
+
+ opp-800000000 {
+ opp-hz = /bits/ 64 <800000000>;
+ opp-microvolt = <900000>;
+ clock-latency-ns = <150000>;
+ };
+
+ opp-1000000000 {
+ opp-hz = /bits/ 64 <1000000000>;
+ opp-microvolt = <1000000>;
+ clock-latency-ns = <150000>;
+ opp-suspend;
+ };
+ };
+
pmu {
compatible = "arm,cortex-a53-pmu";
interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
@@ -683,25 +701,6 @@
status = "disabled";
};
-
- a53_opp_table: opp-table {
- compatible = "operating-points-v2";
- opp-shared;
-
- opp-800000000 {
- opp-hz = /bits/ 64 <800000000>;
- opp-microvolt = <900000>;
- clock-latency-ns = <150000>;
- };
-
- opp-1000000000 {
- opp-hz = /bits/ 64 <1000000000>;
- opp-microvolt = <1000000>;
- clock-latency-ns = <150000>;
- opp-suspend;
- };
- };
-
gic: interrupt-controller@38800000 {
compatible = "arm,gic-v3";
reg = <0x38800000 0x10000>, /* GIC Dist */
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq: Move the opp table out of bus node
2019-03-20 20:05 [PATCH] arm64: dts: imx8mq: Move the opp table out of bus node Fabio Estevam
@ 2019-03-22 2:29 ` Shawn Guo
2019-03-25 18:07 ` Guido Günther
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2019-03-22 2:29 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linux-arm-kernel, linux-imx, kernel, abel.vesa
On Wed, Mar 20, 2019 at 05:05:19PM -0300, Fabio Estevam wrote:
> Move opp-table node from soc node to root node.
>
> opp-table node does not have any register properties and thus
> shouldn't be placed inside the bus.
>
> This fixes the following build warnings with W=1:
>
> arch/arm64/boot/dts/freescale/imx8mq.dtsi:687.28-703.5: Warning (simple_bus_reg): /soc@0/opp-table: missing or empty reg/ranges property
>
> Fixes: 64d26f8c1dde ("arm64: dts: imx8mq: Add the opp table and cores opp properties")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq: Move the opp table out of bus node
2019-03-20 20:05 [PATCH] arm64: dts: imx8mq: Move the opp table out of bus node Fabio Estevam
2019-03-22 2:29 ` Shawn Guo
@ 2019-03-25 18:07 ` Guido Günther
1 sibling, 0 replies; 3+ messages in thread
From: Guido Günther @ 2019-03-25 18:07 UTC (permalink / raw)
To: Fabio Estevam; +Cc: kernel, shawnguo, linux-imx, linux-arm-kernel, abel.vesa
Hi,
On Wed, Mar 20, 2019 at 05:05:19PM -0300, Fabio Estevam wrote:
> Move opp-table node from soc node to root node.
>
> opp-table node does not have any register properties and thus
> shouldn't be placed inside the bus.
>
> This fixes the following build warnings with W=1:
>
> arch/arm64/boot/dts/freescale/imx8mq.dtsi:687.28-703.5: Warning (simple_bus_reg): /soc@0/opp-table: missing or empty reg/ranges property
>
> Fixes: 64d26f8c1dde ("arm64: dts: imx8mq: Add the opp table and cores opp properties")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 37 +++++++++++------------
> 1 file changed, 18 insertions(+), 19 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 32a02027df92..e02ef059bba0 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -132,6 +132,24 @@
> };
> };
>
> + a53_opp_table: opp-table {
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + opp-800000000 {
> + opp-hz = /bits/ 64 <800000000>;
> + opp-microvolt = <900000>;
> + clock-latency-ns = <150000>;
> + };
> +
> + opp-1000000000 {
> + opp-hz = /bits/ 64 <1000000000>;
> + opp-microvolt = <1000000>;
> + clock-latency-ns = <150000>;
> + opp-suspend;
> + };
> + };
> +
> pmu {
> compatible = "arm,cortex-a53-pmu";
> interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
> @@ -683,25 +701,6 @@
> status = "disabled";
> };
>
> -
> - a53_opp_table: opp-table {
> - compatible = "operating-points-v2";
> - opp-shared;
> -
> - opp-800000000 {
> - opp-hz = /bits/ 64 <800000000>;
> - opp-microvolt = <900000>;
> - clock-latency-ns = <150000>;
> - };
> -
> - opp-1000000000 {
> - opp-hz = /bits/ 64 <1000000000>;
> - opp-microvolt = <1000000>;
> - clock-latency-ns = <150000>;
> - opp-suspend;
> - };
> - };
> -
> gic: interrupt-controller@38800000 {
> compatible = "arm,gic-v3";
> reg = <0x38800000 0x10000>, /* GIC Dist */
Just noticed the very same, in case that still matters:
Tested-by: Guido Gúnther <agx@sigxcpu.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-25 18:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-20 20:05 [PATCH] arm64: dts: imx8mq: Move the opp table out of bus node Fabio Estevam
2019-03-22 2:29 ` Shawn Guo
2019-03-25 18:07 ` Guido Günther
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).