* [PATCH v2] arm64/vdso: don't leak kernel addresses
@ 2019-04-01 10:44 Matteo Croce
2019-04-03 12:27 ` Will Deacon
0 siblings, 1 reply; 5+ messages in thread
From: Matteo Croce @ 2019-04-01 10:44 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Mark Rutland, Catalin Marinas, Will Deacon
Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"),
two obfuscated kernel pointer are printed at every boot:
vdso: 2 pages (1 code @ (____ptrval____), 1 data @ (____ptrval____))
Remove the the print completely, as it's useless without the addresses.
Fixes: ad67b74d2469d9b8 ("printk: hash addresses printed with %p")
Acked-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Matteo Croce <mcroce@redhat.com>
---
arch/arm64/kernel/vdso.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/kernel/vdso.c b/arch/arm64/kernel/vdso.c
index 2d419006ad43..9fb0c0c95a85 100644
--- a/arch/arm64/kernel/vdso.c
+++ b/arch/arm64/kernel/vdso.c
@@ -146,8 +146,6 @@ static int __init vdso_init(void)
}
vdso_pages = (vdso_end - vdso_start) >> PAGE_SHIFT;
- pr_info("vdso: %ld pages (%ld code @ %p, %ld data @ %p)\n",
- vdso_pages + 1, vdso_pages, vdso_start, 1L, vdso_data);
/* Allocate the vDSO pagelist, plus a page for the data. */
vdso_pagelist = kcalloc(vdso_pages + 1, sizeof(struct page *),
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64/vdso: don't leak kernel addresses
2019-04-01 10:44 [PATCH v2] arm64/vdso: don't leak kernel addresses Matteo Croce
@ 2019-04-03 12:27 ` Will Deacon
2019-04-03 13:32 ` Marc Gonzalez
0 siblings, 1 reply; 5+ messages in thread
From: Will Deacon @ 2019-04-03 12:27 UTC (permalink / raw)
To: Matteo Croce; +Cc: Mark Rutland, Catalin Marinas, linux-arm-kernel
On Mon, Apr 01, 2019 at 12:44:47PM +0200, Matteo Croce wrote:
> Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"),
> two obfuscated kernel pointer are printed at every boot:
>
> vdso: 2 pages (1 code @ (____ptrval____), 1 data @ (____ptrval____))
>
> Remove the the print completely, as it's useless without the addresses.
>
> Fixes: ad67b74d2469d9b8 ("printk: hash addresses printed with %p")
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Matteo Croce <mcroce@redhat.com>
Cheers, I'll pick this up.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64/vdso: don't leak kernel addresses
2019-04-03 12:27 ` Will Deacon
@ 2019-04-03 13:32 ` Marc Gonzalez
2019-04-03 13:34 ` Matteo Croce
0 siblings, 1 reply; 5+ messages in thread
From: Marc Gonzalez @ 2019-04-03 13:32 UTC (permalink / raw)
To: Will Deacon, Matteo Croce; +Cc: Mark Rutland, Catalin Marinas, Linux ARM
On 03/04/2019 14:27, Will Deacon wrote:
> On Mon, Apr 01, 2019 at 12:44:47PM +0200, Matteo Croce wrote:
>
>> Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"),
>> two obfuscated kernel pointer are printed at every boot:
>>
>> vdso: 2 pages (1 code @ (____ptrval____), 1 data @ (____ptrval____))
>>
>> Remove the the print completely, as it's useless without the addresses.
>>
>> Fixes: ad67b74d2469d9b8 ("printk: hash addresses printed with %p")
>> Acked-by: Mark Rutland <mark.rutland@arm.com>
>> Signed-off-by: Matteo Croce <mcroce@redhat.com>
>
> Cheers, I'll pick this up.
Maybe you can fixup the dupe in: "Remove the the print completely"
Regards.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64/vdso: don't leak kernel addresses
2019-04-03 13:32 ` Marc Gonzalez
@ 2019-04-03 13:34 ` Matteo Croce
2019-04-03 13:36 ` Will Deacon
0 siblings, 1 reply; 5+ messages in thread
From: Matteo Croce @ 2019-04-03 13:34 UTC (permalink / raw)
To: Marc Gonzalez; +Cc: Mark Rutland, Catalin Marinas, Will Deacon, Linux ARM
On Wed, Apr 3, 2019 at 3:32 PM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote:
>
> On 03/04/2019 14:27, Will Deacon wrote:
>
> > On Mon, Apr 01, 2019 at 12:44:47PM +0200, Matteo Croce wrote:
> >
> >> Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"),
> >> two obfuscated kernel pointer are printed at every boot:
> >>
> >> vdso: 2 pages (1 code @ (____ptrval____), 1 data @ (____ptrval____))
> >>
> >> Remove the the print completely, as it's useless without the addresses.
> >>
> >> Fixes: ad67b74d2469d9b8 ("printk: hash addresses printed with %p")
> >> Acked-by: Mark Rutland <mark.rutland@arm.com>
> >> Signed-off-by: Matteo Croce <mcroce@redhat.com>
> >
> > Cheers, I'll pick this up.
>
> Maybe you can fixup the dupe in: "Remove the the print completely"
>
> Regards.
Oops, please remove it, I didn't notice in time.
Nice catch, thanks
--
Matteo Croce
per aspera ad upstream
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64/vdso: don't leak kernel addresses
2019-04-03 13:34 ` Matteo Croce
@ 2019-04-03 13:36 ` Will Deacon
0 siblings, 0 replies; 5+ messages in thread
From: Will Deacon @ 2019-04-03 13:36 UTC (permalink / raw)
To: Matteo Croce; +Cc: Mark Rutland, Catalin Marinas, Linux ARM, Marc Gonzalez
On Wed, Apr 03, 2019 at 03:34:09PM +0200, Matteo Croce wrote:
> On Wed, Apr 3, 2019 at 3:32 PM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote:
> >
> > On 03/04/2019 14:27, Will Deacon wrote:
> >
> > > On Mon, Apr 01, 2019 at 12:44:47PM +0200, Matteo Croce wrote:
> > >
> > >> Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"),
> > >> two obfuscated kernel pointer are printed at every boot:
> > >>
> > >> vdso: 2 pages (1 code @ (____ptrval____), 1 data @ (____ptrval____))
> > >>
> > >> Remove the the print completely, as it's useless without the addresses.
> > >>
> > >> Fixes: ad67b74d2469d9b8 ("printk: hash addresses printed with %p")
> > >> Acked-by: Mark Rutland <mark.rutland@arm.com>
> > >> Signed-off-by: Matteo Croce <mcroce@redhat.com>
> > >
> > > Cheers, I'll pick this up.
> >
> > Maybe you can fixup the dupe in: "Remove the the print completely"
> >
> > Regards.
>
> Oops, please remove it, I didn't notice in time.
> Nice catch, thanks
Damn, I already pushed this out, so I'm afraid it's stuck there now.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-03 13:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-01 10:44 [PATCH v2] arm64/vdso: don't leak kernel addresses Matteo Croce
2019-04-03 12:27 ` Will Deacon
2019-04-03 13:32 ` Marc Gonzalez
2019-04-03 13:34 ` Matteo Croce
2019-04-03 13:36 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).