From: Sudeep Holla <sudeep.holla@arm.com>
To: Kangjie Lu <kjlu@umn.edu>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, pakki001@umn.edu
Subject: Re: [PATCH] firmware: arm_scmi: check return value of idr_find
Date: Wed, 10 Apr 2019 17:25:37 +0100 [thread overview]
Message-ID: <20190410162537.GF3952@e107155-lin> (raw)
In-Reply-To: <20190309040239.32431-1-kjlu@umn.edu>
On Fri, Mar 08, 2019 at 10:02:39PM -0600, Kangjie Lu wrote:
> idr_find may return NULL, so check its return value and return an
> error code.
>
I can't imagine a scenario leading to this. Steven has already explained
why, so I won't repeat the same here. Did you hit this issue ?
If so I would like to know details, so that we can bail out much earlier
where the failure occurs than proceed until this point.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-04-10 16:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-09 4:02 [PATCH] firmware: arm_scmi: check return value of idr_find Kangjie Lu
2019-03-23 2:18 ` Kangjie Lu
2019-03-25 11:54 ` Steven Price
2019-03-25 20:48 ` Kangjie Lu
2019-03-26 11:34 ` Steven Price
2019-04-10 16:31 ` Sudeep Holla
2019-04-10 16:25 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410162537.GF3952@e107155-lin \
--to=sudeep.holla@arm.com \
--cc=kjlu@umn.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pakki001@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).