From: Shawn Guo <shawnguo@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: andrew@lunn.ch, baruch@tkos.co.il, ken.lin@advantech.com,
smoch@web.de, stwiss.opensource@diasemi.com, linux-imx@nxp.com,
kernel@pengutronix.de, Marc Kleine-Budde <mkl@pengutronix.de>,
aford173@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] ARM: dts: imx: Fix the AR803X phy-mode
Date: Thu, 11 Apr 2019 10:58:20 +0800 [thread overview]
Message-ID: <20190411025818.GM26817@dragon> (raw)
In-Reply-To: <20190403221241.4753-1-festevam@gmail.com>
On Wed, Apr 03, 2019 at 07:12:41PM -0300, Fabio Estevam wrote:
> Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode")
> exposed an issue on imx DTS files using AR8031/AR8035 PHYs.
>
> The end result is that the boards can no longer obtain an IP address
> via UDHCP, for example.
>
> Quoting Andrew Lunn:
>
> "The problem here is, all the DTs were broken since day 0. However,
> because the PHY driver was also broken, nobody noticed and it
> worked. Now that the PHY driver has been fixed, all the bugs in the
> DTs now become an issue"
>
> To fix this problem, the phy-mode property needs to be "rgmii-id", which
> has the following meaning as per
> Documentation/devicetree/bindings/net/ethernet.txt:
>
> "RGMII with internal RX and TX delays provided by the PHY, the MAC should
> not add the RX or TX delays in this case)"
>
> Tested on imx6-sabresd, imx6sx-sdb and imx7d-pico boards with
> successfully restored networking.
>
> Based on the initial submission from Steve Twiss for the
> imx6qdl-sabresd.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Tested-by: Baruch Siach <baruch@tkos.co.il>
> Tested-by: Soeren Moch <smoch@web.de>
> Tested-by: Steve Twiss <stwiss.opensource@diasemi.com>
> Tested-by: Adam Thomson <Adam.Thomson@diasemi.com>
> Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
> Tested-by: Marc Kleine-Budde <mkl@pengutronix.de>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-11 2:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 22:12 [PATCH v3] ARM: dts: imx: Fix the AR803X phy-mode Fabio Estevam
2019-04-11 2:58 ` Shawn Guo [this message]
2019-05-13 17:18 ` George G. Davis
2019-05-14 0:45 ` Sasha Levin
2019-05-14 1:06 ` Florian Fainelli
2019-05-14 1:16 ` George G. Davis
2019-05-14 2:07 ` Sasha Levin
2019-05-14 15:22 ` George G. Davis
2019-05-17 22:25 ` George G. Davis
2019-05-18 6:38 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411025818.GM26817@dragon \
--to=shawnguo@kernel.org \
--cc=aford173@gmail.com \
--cc=andrew@lunn.ch \
--cc=baruch@tkos.co.il \
--cc=festevam@gmail.com \
--cc=ken.lin@advantech.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=mkl@pengutronix.de \
--cc=smoch@web.de \
--cc=stwiss.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).