[PATCH] arm64: dts: allwinner: h6: add PIO VCC bank supplies for Pine H64

[PATCH] arm64: dts: allwinner: h6: add PIO VCC bank supplies for Pine H64

[Icenowy Zheng]

The Allwinner H6 SoC features tweakable VCC for PC, PD, PG, PL and PM
banks.

This patch adds supplies for PC and PD banks on Pine H64 board. PG and
PM banks are used for Wi-Fi and should be added when Wi-Fi is added; PL
bank is where PMIC is attached, and currently if a PMIC regulator is
added for it a dependency loop will happen.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
 arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
index 4802902e128f..d586a51c657d 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
@@ -127,6 +127,11 @@
 	status = "okay";
 };
 
+&pio {
+	vcc-pc-supply = <&reg_bldo2>;
+	vcc-pd-supply = <&reg_cldo1>;
+};
+
 &r_i2c {
 	status = "okay";
 
-- 
2.18.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm64: dts: allwinner: h6: add PIO VCC bank supplies for Pine H64

[Maxime Ripard]

[-- Attachment #1.1: Type: text/plain, Size: 699 bytes --]

Hi,

On Wed, Apr 24, 2019 at 02:25:43PM +0800, Icenowy Zheng wrote:
> The Allwinner H6 SoC features tweakable VCC for PC, PD, PG, PL and PM
> banks.
>
> This patch adds supplies for PC and PD banks on Pine H64 board. PG and
> PM banks are used for Wi-Fi and should be added when Wi-Fi is added

Not really. The regulator is still there, whether we use it or not. If
it's not used, then it will be left disabled so it doesn't really
change anything.

> PL bank is where PMIC is attached, and currently if a PMIC regulator
> is added for it a dependency loop will happen.

I guess we should fix that somehow

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm64: dts: allwinner: h6: add PIO VCC bank supplies for Pine H64

[Icenowy Zheng]

于 2019年5月2日 GMT+08:00 下午3:43:03, Maxime Ripard <maxime.ripard@bootlin.com> 写到:
>Hi,
>
>On Wed, Apr 24, 2019 at 02:25:43PM +0800, Icenowy Zheng wrote:
>> The Allwinner H6 SoC features tweakable VCC for PC, PD, PG, PL and PM
>> banks.
>>
>> This patch adds supplies for PC and PD banks on Pine H64 board. PG
>and
>> PM banks are used for Wi-Fi and should be added when Wi-Fi is added
>
>Not really. The regulator is still there, whether we use it or not. If
>it's not used, then it will be left disabled so it doesn't really
>change anything.

Okay, I will include them in the next revision.

>
>> PL bank is where PMIC is attached, and currently if a PMIC regulator
>> is added for it a dependency loop will happen.
>
>I guess we should fix that somehow

But this patch is needed for eMMC to be functional again in HS200 mode, so I hope
it can get applied before this get fixed.

>
>Maxime
>
>--
>Maxime Ripard, Bootlin
>Embedded Linux and Kernel engineering
>https://bootlin.com

-- 
使用 K-9 Mail 发送自我的Android设备。

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm64: dts: allwinner: h6: add PIO VCC bank supplies for Pine H64

[Maxime Ripard]

[-- Attachment #1.1: Type: text/plain, Size: 1149 bytes --]

On Thu, May 02, 2019 at 03:46:17PM +0800, Icenowy Zheng wrote:
>
>
> 于 2019年5月2日 GMT+08:00 下午3:43:03, Maxime Ripard <maxime.ripard@bootlin.com> 写到:
> >Hi,
> >
> >On Wed, Apr 24, 2019 at 02:25:43PM +0800, Icenowy Zheng wrote:
> >> The Allwinner H6 SoC features tweakable VCC for PC, PD, PG, PL and PM
> >> banks.
> >>
> >> This patch adds supplies for PC and PD banks on Pine H64 board. PG
> >and
> >> PM banks are used for Wi-Fi and should be added when Wi-Fi is added
> >
> >Not really. The regulator is still there, whether we use it or not. If
> >it's not used, then it will be left disabled so it doesn't really
> >change anything.
>
> Okay, I will include them in the next revision.
>
> >
> >> PL bank is where PMIC is attached, and currently if a PMIC regulator
> >> is added for it a dependency loop will happen.
> >
> >I guess we should fix that somehow
>
> But this patch is needed for eMMC to be functional again in HS200 mode, so I hope
> it can get applied before this get fixed.

Yep, sure

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel