* [PATCH] pwm: imx27: use devm_platform_ioremap_resource() to simplify code
@ 2019-04-01 5:24 Anson Huang
2019-04-01 7:00 ` Uwe Kleine-König
` (4 more replies)
0 siblings, 5 replies; 7+ messages in thread
From: Anson Huang @ 2019-04-01 5:24 UTC (permalink / raw)
To: thierry.reding, shawnguo, s.hauer, kernel, festevam, linux-pwm,
linux-arm-kernel, linux-kernel
Cc: dl-linux-imx
Use the new helper devm_platform_ioremap_resource() which wraps the
platform_get_resource() and devm_ioremap_resource() together, to
simplify the code.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
drivers/pwm/pwm-imx27.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c
index 8061306..434a351 100644
--- a/drivers/pwm/pwm-imx27.c
+++ b/drivers/pwm/pwm-imx27.c
@@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids);
static int pwm_imx27_probe(struct platform_device *pdev)
{
struct pwm_imx27_chip *imx;
- struct resource *r;
imx = devm_kzalloc(&pdev->dev, sizeof(*imx), GFP_KERNEL);
if (imx == NULL)
@@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct platform_device *pdev)
imx->chip.of_xlate = of_pwm_xlate_with_flags;
imx->chip.of_pwm_n_cells = 3;
- r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- imx->mmio_base = devm_ioremap_resource(&pdev->dev, r);
+ imx->mmio_base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(imx->mmio_base))
return PTR_ERR(imx->mmio_base);
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] pwm: imx27: use devm_platform_ioremap_resource() to simplify code
2019-04-01 5:24 [PATCH] pwm: imx27: use devm_platform_ioremap_resource() to simplify code Anson Huang
@ 2019-04-01 7:00 ` Uwe Kleine-König
2019-04-01 7:45 ` Mukesh Ojha
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Uwe Kleine-König @ 2019-04-01 7:00 UTC (permalink / raw)
To: Anson Huang
Cc: linux-pwm, shawnguo, s.hauer, linux-kernel, thierry.reding,
dl-linux-imx, kernel, festevam, linux-arm-kernel
On Mon, Apr 01, 2019 at 05:24:02AM +0000, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] pwm: imx27: use devm_platform_ioremap_resource() to simplify code
2019-04-01 5:24 [PATCH] pwm: imx27: use devm_platform_ioremap_resource() to simplify code Anson Huang
2019-04-01 7:00 ` Uwe Kleine-König
@ 2019-04-01 7:45 ` Mukesh Ojha
2019-04-01 8:00 ` Mukesh Ojha
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Mukesh Ojha @ 2019-04-01 7:45 UTC (permalink / raw)
To: Anson Huang, thierry.reding, shawnguo, s.hauer, kernel, festevam,
linux-pwm, linux-arm-kernel, linux-kernel
Cc: dl-linux-imx
On 4/1/2019 10:54 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> drivers/pwm/pwm-imx27.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c
> index 8061306..434a351 100644
> --- a/drivers/pwm/pwm-imx27.c
> +++ b/drivers/pwm/pwm-imx27.c
> @@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids);
> static int pwm_imx27_probe(struct platform_device *pdev)
> {
> struct pwm_imx27_chip *imx;
> - struct resource *r;
>
> imx = devm_kzalloc(&pdev->dev, sizeof(*imx), GFP_KERNEL);
> if (imx == NULL)
> @@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct platform_device *pdev)
> imx->chip.of_xlate = of_pwm_xlate_with_flags;
> imx->chip.of_pwm_n_cells = 3;
>
> - r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - imx->mmio_base = devm_ioremap_resource(&pdev->dev, r);
> + imx->mmio_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(imx->mmio_base))
> return PTR_ERR(imx->mmio_base);
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] pwm: imx27: use devm_platform_ioremap_resource() to simplify code
2019-04-01 5:24 [PATCH] pwm: imx27: use devm_platform_ioremap_resource() to simplify code Anson Huang
2019-04-01 7:00 ` Uwe Kleine-König
2019-04-01 7:45 ` Mukesh Ojha
@ 2019-04-01 8:00 ` Mukesh Ojha
2019-04-01 8:01 ` Mukesh Ojha
2019-05-09 14:55 ` Thierry Reding
4 siblings, 0 replies; 7+ messages in thread
From: Mukesh Ojha @ 2019-04-01 8:00 UTC (permalink / raw)
To: Anson Huang, thierry.reding, shawnguo, s.hauer, kernel, festevam,
linux-pwm, linux-arm-kernel, linux-kernel
Cc: dl-linux-imx
On 4/1/2019 10:54 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> drivers/pwm/pwm-imx27.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c
> index 8061306..434a351 100644
> --- a/drivers/pwm/pwm-imx27.c
> +++ b/drivers/pwm/pwm-imx27.c
> @@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids);
> static int pwm_imx27_probe(struct platform_device *pdev)
> {
> struct pwm_imx27_chip *imx;
> - struct resource *r;
>
> imx = devm_kzalloc(&pdev->dev, sizeof(*imx), GFP_KERNEL);
> if (imx == NULL)
> @@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct platform_device *pdev)
> imx->chip.of_xlate = of_pwm_xlate_with_flags;
> imx->chip.of_pwm_n_cells = 3;
>
> - r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - imx->mmio_base = devm_ioremap_resource(&pdev->dev, r);
> + imx->mmio_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(imx->mmio_base))
> return PTR_ERR(imx->mmio_base);
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] pwm: imx27: use devm_platform_ioremap_resource() to simplify code
2019-04-01 5:24 [PATCH] pwm: imx27: use devm_platform_ioremap_resource() to simplify code Anson Huang
` (2 preceding siblings ...)
2019-04-01 8:00 ` Mukesh Ojha
@ 2019-04-01 8:01 ` Mukesh Ojha
2019-04-28 6:29 ` Anson Huang
2019-05-09 14:55 ` Thierry Reding
4 siblings, 1 reply; 7+ messages in thread
From: Mukesh Ojha @ 2019-04-01 8:01 UTC (permalink / raw)
To: Anson Huang, thierry.reding, shawnguo, s.hauer, kernel, festevam,
linux-pwm, linux-arm-kernel, linux-kernel
Cc: dl-linux-imx
On 4/1/2019 10:54 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> drivers/pwm/pwm-imx27.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c
> index 8061306..434a351 100644
> --- a/drivers/pwm/pwm-imx27.c
> +++ b/drivers/pwm/pwm-imx27.c
> @@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids);
> static int pwm_imx27_probe(struct platform_device *pdev)
> {
> struct pwm_imx27_chip *imx;
> - struct resource *r;
>
> imx = devm_kzalloc(&pdev->dev, sizeof(*imx), GFP_KERNEL);
> if (imx == NULL)
> @@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct platform_device *pdev)
> imx->chip.of_xlate = of_pwm_xlate_with_flags;
> imx->chip.of_pwm_n_cells = 3;
>
> - r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - imx->mmio_base = devm_ioremap_resource(&pdev->dev, r);
> + imx->mmio_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(imx->mmio_base))
> return PTR_ERR(imx->mmio_base);
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] pwm: imx27: use devm_platform_ioremap_resource() to simplify code
2019-04-01 8:01 ` Mukesh Ojha
@ 2019-04-28 6:29 ` Anson Huang
0 siblings, 0 replies; 7+ messages in thread
From: Anson Huang @ 2019-04-28 6:29 UTC (permalink / raw)
To: Mukesh Ojha, thierry.reding, shawnguo, s.hauer, kernel, festevam,
linux-pwm, linux-arm-kernel, linux-kernel
Cc: dl-linux-imx
Ping...
> -----Original Message-----
> From: Mukesh Ojha [mailto:mojha@codeaurora.org]
> Sent: Monday, April 1, 2019 4:01 PM
> To: Anson Huang <anson.huang@nxp.com>; thierry.reding@gmail.com;
> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> festevam@gmail.com; linux-pwm@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Cc: dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH] pwm: imx27: use devm_platform_ioremap_resource()
> to simplify code
>
>
> On 4/1/2019 10:54 AM, Anson Huang wrote:
> > Use the new helper devm_platform_ioremap_resource() which wraps the
> > platform_get_resource() and devm_ioremap_resource() together, to
> > simplify the code.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
>
>
> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
>
> Cheers,
> -Mukesh
>
> > ---
> > drivers/pwm/pwm-imx27.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c index
> > 8061306..434a351 100644
> > --- a/drivers/pwm/pwm-imx27.c
> > +++ b/drivers/pwm/pwm-imx27.c
> > @@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids);
> > static int pwm_imx27_probe(struct platform_device *pdev)
> > {
> > struct pwm_imx27_chip *imx;
> > - struct resource *r;
> >
> > imx = devm_kzalloc(&pdev->dev, sizeof(*imx), GFP_KERNEL);
> > if (imx == NULL)
> > @@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct
> platform_device *pdev)
> > imx->chip.of_xlate = of_pwm_xlate_with_flags;
> > imx->chip.of_pwm_n_cells = 3;
> >
> > - r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - imx->mmio_base = devm_ioremap_resource(&pdev->dev, r);
> > + imx->mmio_base = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(imx->mmio_base))
> > return PTR_ERR(imx->mmio_base);
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] pwm: imx27: use devm_platform_ioremap_resource() to simplify code
2019-04-01 5:24 [PATCH] pwm: imx27: use devm_platform_ioremap_resource() to simplify code Anson Huang
` (3 preceding siblings ...)
2019-04-01 8:01 ` Mukesh Ojha
@ 2019-05-09 14:55 ` Thierry Reding
4 siblings, 0 replies; 7+ messages in thread
From: Thierry Reding @ 2019-05-09 14:55 UTC (permalink / raw)
To: Anson Huang
Cc: linux-pwm, shawnguo, s.hauer, linux-kernel, dl-linux-imx, kernel,
festevam, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 405 bytes --]
On Mon, Apr 01, 2019 at 05:24:02AM +0000, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/pwm/pwm-imx27.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-05-09 14:55 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-01 5:24 [PATCH] pwm: imx27: use devm_platform_ioremap_resource() to simplify code Anson Huang
2019-04-01 7:00 ` Uwe Kleine-König
2019-04-01 7:45 ` Mukesh Ojha
2019-04-01 8:00 ` Mukesh Ojha
2019-04-01 8:01 ` Mukesh Ojha
2019-04-28 6:29 ` Anson Huang
2019-05-09 14:55 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).