From: Will Deacon <will.deacon@arm.com>
To: Zhi Li <lznuaa@gmail.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
"festevam@gmail.com" <festevam@gmail.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
Frank Li <frank.li@nxp.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V12 2/4] drivers/perf: imx_ddr: Add ddr performance counter support
Date: Tue, 14 May 2019 15:55:41 +0100 [thread overview]
Message-ID: <20190514145541.GC2825@fuggles.cambridge.arm.com> (raw)
In-Reply-To: <CAHrpEqQKyH0+vXJfWf0fuUDvQnSCKjrBmU8megsUWX1mHdbfrw@mail.gmail.com>
On Tue, May 14, 2019 at 08:53:18AM -0500, Zhi Li wrote:
> On Tue, May 7, 2019 at 2:30 PM Andrey Smirnov <andrew.smirnov@gmail.com> wrote:
> >
> > On Wed, May 1, 2019 at 11:43 AM Frank Li <frank.li@nxp.com> wrote:
> > >
> > > Add ddr performance monitor support for iMX8QXP
> > >
> > > There are 4 counters for ddr perfomance events.
> > > counter 0 is dedicated for cycles.
> > > you choose any up to 3 no cycles events.
> > >
> > > for example:
> > >
> > > perf stat -a -e imx8_ddr0/read-cycles/,imx8_ddr0/write-cycles/,imx8_ddr0/precharge/ ls
> > > perf stat -a -e imx8_ddr0/cycles/,imx8_ddr0/read-access/,imx8_ddr0/write-access/ ls
> > >
> > > Support below events.
> > >
> > > imx8_ddr0/activate/ [Kernel PMU event]
> > > imx8_ddr0/axid-read/ [Kernel PMU event]
> > > imx8_ddr0/axid-write/ [Kernel PMU event]
> > > imx8_ddr0/cycles/ [Kernel PMU event]
> > > imx8_ddr0/hp-read-credit-cnt/ [Kernel PMU event]
> > > imx8_ddr0/hp-read/ [Kernel PMU event]
> > > imx8_ddr0/hp-req-nodcredit/ [Kernel PMU event]
> > > imx8_ddr0/hp-xact-credit/ [Kernel PMU event]
> > > imx8_ddr0/load-mode/ [Kernel PMU event]
> > > imx8_ddr0/lp-read-credit-cnt/ [Kernel PMU event]
> > > imx8_ddr0/lp-req-nocredit/ [Kernel PMU event]
> > > imx8_ddr0/lp-xact-credit/ [Kernel PMU event]
> > > imx8_ddr0/mwr/ [Kernel PMU event]
> > > imx8_ddr0/precharge/ [Kernel PMU event]
> > > imx8_ddr0/raw-hazard/ [Kernel PMU event]
> > > imx8_ddr0/read-access/ [Kernel PMU event]
> > > imx8_ddr0/read-activate/ [Kernel PMU event]
> > > imx8_ddr0/read-command/ [Kernel PMU event]
> > > imx8_ddr0/read-cycles/ [Kernel PMU event]
> > > imx8_ddr0/read-modify-write-command/ [Kernel PMU event]
> > > imx8_ddr0/read-queue-depth/ [Kernel PMU event]
> > > imx8_ddr0/read-write-transition/ [Kernel PMU event]
> > > imx8_ddr0/read/ [Kernel PMU event]
> > > imx8_ddr0/refresh/ [Kernel PMU event]
> > > imx8_ddr0/selfresh/ [Kernel PMU event]
> > > imx8_ddr0/wr-xact-credit/ [Kernel PMU event]
> > > imx8_ddr0/write-access/ [Kernel PMU event]
> > > imx8_ddr0/write-command/ [Kernel PMU event]
> > > imx8_ddr0/write-credit-cnt/ [Kernel PMU event]
> > > imx8_ddr0/write-cycles/ [Kernel PMU event]
> > > imx8_ddr0/write-queue-depth/ [Kernel PMU event]
> > > imx8_ddr0/write/
> > >
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> >
> > Don't really have anything to suggest, that I already haven't. LGTM, so:
> >
> > Reviewed-by: Andrey Smirnov <andrew.smirnov@gmail.com>
>
>
> Will Deacon:
> Is it okay to pick up these patches? Andrey always acked.
It's the merge window at the moment, so it's too late for 5.2. I'll have a
look at these in a couple of weeks as candidates for 5.3.
Thanks,
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-14 14:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 18:43 [PATCH V12 1/4] dt-bindings: perf: imx8-ddr: add imx8qxp ddr performance monitor Frank Li
2019-05-01 18:43 ` [PATCH V12 2/4] drivers/perf: imx_ddr: Add ddr performance counter support Frank Li
2019-05-07 19:30 ` Andrey Smirnov
2019-05-14 13:53 ` Zhi Li
2019-05-14 14:55 ` Will Deacon [this message]
2019-06-13 11:23 ` Will Deacon
2019-06-13 17:04 ` Zhi Li
2019-06-13 17:44 ` Will Deacon
2019-06-13 19:13 ` Zhi Li
2019-06-14 10:23 ` Will Deacon
2019-06-18 17:24 ` Zhi Li
2019-06-18 17:58 ` Will Deacon
2019-05-01 18:43 ` [PATCH V12 3/4] arm64: dts: imx8qxp: added ddr performance monitor nodes Frank Li
2019-06-18 6:37 ` Shawn Guo
2019-05-01 18:43 ` [PATCH V12 4/4] MAINTAINERS: Added imx DDR performonitor driver maintainer information Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514145541.GC2825@fuggles.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=aisheng.dong@nxp.com \
--cc=andrew.smirnov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frank.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=lznuaa@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).