From: Jonathan Cameron <jic23@kernel.org>
To: Chun-Hung Wu <chun-hung.wu@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
wsd_upstream@mediatek.com, linux-iio@vger.kernel.org,
kuohong.wang@mediatek.com, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org, peter.wang@mediatek.com,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Hartmut Knaack <knaack.h@gmx.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
jg_poxu@mediatek.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] iio: auxadc: mediatek: change to subsys_initcall
Date: Sat, 18 May 2019 11:36:43 +0100 [thread overview]
Message-ID: <20190518113643.53a42976@archlinux> (raw)
In-Reply-To: <1557994247-16739-5-git-send-email-chun-hung.wu@mediatek.com>
On Thu, 16 May 2019 16:10:47 +0800
Chun-Hung Wu <chun-hung.wu@mediatek.com> wrote:
> Move auxadc platform_driver_register() from module_init
> to subsys_initcall because auxadc user drivers
> are all moudle drivers, need to gurantee
> auxadc driver ready before module_init.
>
Is it not possible to make them use deferred handling to come
back later if this isn't yet available?
subsys_initcall often ends up being a more fragile approach.
Thanks,
Jonathan
> Signed-off-by: Chun-Hung Wu <chun-hung.wu@mediatek.com>
> ---
> drivers/iio/adc/mt6577_auxadc.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c
> index 58d7cb2..cb8e3dd 100644
> --- a/drivers/iio/adc/mt6577_auxadc.c
> +++ b/drivers/iio/adc/mt6577_auxadc.c
> @@ -350,7 +350,19 @@ static int mt6577_auxadc_remove(struct platform_device *pdev)
> .probe = mt6577_auxadc_probe,
> .remove = mt6577_auxadc_remove,
> };
> -module_platform_driver(mt6577_auxadc_driver);
> +
> +static int __init mt6577_auxadc_init(void)
> +{
> + return platform_driver_register(&mt6577_auxadc_driver);
> +}
> +
> +static void __exit mt6577_auxadc_exit(void)
> +{
> + platform_driver_unregister(&mt6577_auxadc_driver);
> +}
> +
> +subsys_initcall(mt6577_auxadc_init);
> +module_exit(mt6577_auxadc_exit);
>
> MODULE_AUTHOR("Zhiyong Tao <zhiyong.tao@mediatek.com>");
> MODULE_DESCRIPTION("MTK AUXADC Device Driver");
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-18 10:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 8:10 [PATCH 0/4] iio: adc: mediatek: add mt6765 driver support Chun-Hung Wu
2019-05-16 8:10 ` [PATCH 1/4] dt-bindings: iio: adc: mediatek: Add document for mt6765 Chun-Hung Wu
2019-05-18 10:33 ` Jonathan Cameron
2019-05-20 6:47 ` Chun-Hung Wu
2019-05-16 8:10 ` [PATCH 2/4] iio: adc: mediatek: mt6765 upstream driver Chun-Hung Wu
2019-05-18 10:33 ` Jonathan Cameron
2019-05-16 8:10 ` [PATCH 3/4] iio: adc: mediatek: SET_LATE_SYSTEM_SLEEP_PM_OPS support Chun-Hung Wu
2019-05-18 10:35 ` Jonathan Cameron
2019-05-20 6:03 ` Chun-Hung Wu
2019-05-22 16:28 ` Matthias Brugger
2019-05-28 10:59 ` Chun-Hung Wu
2019-06-06 15:46 ` Jonathan Cameron
2019-05-16 8:10 ` [PATCH 4/4] iio: auxadc: mediatek: change to subsys_initcall Chun-Hung Wu
2019-05-18 10:36 ` Jonathan Cameron [this message]
2019-05-20 6:06 ` Chun-Hung Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190518113643.53a42976@archlinux \
--to=jic23@kernel.org \
--cc=chun-hung.wu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=jg_poxu@mediatek.com \
--cc=knaack.h@gmx.de \
--cc=kuohong.wang@mediatek.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).