* [PATCH v4 0/5] cpufreq: Add imx-cpufreq-dt driver for speed grading
@ 2019-05-13 11:01 Leonard Crestez
2019-05-13 11:01 ` [PATCH v4 1/5] cpufreq: Add imx-cpufreq-dt driver Leonard Crestez
` (5 more replies)
0 siblings, 6 replies; 13+ messages in thread
From: Leonard Crestez @ 2019-05-13 11:01 UTC (permalink / raw)
To: Viresh Kumar, Shawn Guo, Rob Herring
Cc: Mark Rutland, Aisheng Dong, Jacky Bai, Anson Huang, linux-pm,
Rafael J. Wysocki, devicetree, dl-linux-imx, kernel,
Fabio Estevam, Lucas Stach, linux-arm-kernel, Abel Vesa
Right now in upstream imx8m cpufreq support just lists a common subset
of OPPs because the higher ones should only be attempted after checking
speed grading in fuses.
Driver reads from nvmem and calls dev_pm_opp_set_supported_hw before
registering cpufreq-dt.
Changes since v3:
* Drop default m entirely (Viresh)
Link to v3: https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=114685
Changes since v2:
* Minor reformatting in Kconfig (Viresh)
* Open-code imx_cpufreq_dt_match_node (Viresh)
* Add mkt_segment bits to supported_hw and update .dtsi to match after
reviewing latest datasheets.
* Add devicetree list (keep forgetting dts needs to be reviewed)
Link to v2: https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=113163
Link to v1 (RFC): https://patchwork.kernel.org/patch/10916769/
Driver is built as a module. It depends on nvmem-imx which can also be a
module.
I never noticed anything wrong with going above the fused speed grading
however it's technically unsafe so the cpufreq code changes should go in
before DT changes.
Leonard Crestez (5):
cpufreq: Add imx-cpufreq-dt driver
dt-bindings: imx-cpufreq-dt: Document opp-supported-hw usage
arm64: dts: imx8mm: Add cpu speed grading and all OPPs
arm64: dts: imx8mq: Add cpu speed grading and all OPPs
arm64: defconfig: ARM_IMX_CPUFREQ_DT=m
.../bindings/cpufreq/imx-cpufreq-dt.txt | 37 +++++++
arch/arm64/boot/dts/freescale/imx8mm.dtsi | 17 +++-
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 26 ++++-
arch/arm64/configs/defconfig | 1 +
drivers/cpufreq/Kconfig.arm | 9 ++
drivers/cpufreq/Makefile | 1 +
drivers/cpufreq/cpufreq-dt-platdev.c | 3 +
drivers/cpufreq/imx-cpufreq-dt.c | 96 +++++++++++++++++++
drivers/soc/imx/soc-imx8.c | 3 +
9 files changed, 191 insertions(+), 2 deletions(-)
create mode 100644 Documentation/devicetree/bindings/cpufreq/imx-cpufreq-dt.txt
create mode 100644 drivers/cpufreq/imx-cpufreq-dt.c
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v4 1/5] cpufreq: Add imx-cpufreq-dt driver
2019-05-13 11:01 [PATCH v4 0/5] cpufreq: Add imx-cpufreq-dt driver for speed grading Leonard Crestez
@ 2019-05-13 11:01 ` Leonard Crestez
2019-05-13 11:01 ` [PATCH v4 2/5] dt-bindings: imx-cpufreq-dt: Document opp-supported-hw usage Leonard Crestez
` (4 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: Leonard Crestez @ 2019-05-13 11:01 UTC (permalink / raw)
To: Viresh Kumar, Shawn Guo, Rob Herring
Cc: Mark Rutland, Aisheng Dong, Jacky Bai, Anson Huang, linux-pm,
Rafael J. Wysocki, devicetree, dl-linux-imx, kernel,
Fabio Estevam, Lucas Stach, linux-arm-kernel, Abel Vesa
Right now in upstream imx8m cpufreq support just lists a common subset
of OPPs because the higher ones should only be attempted after checking
speed grading in fuses.
Add a small driver which checks speed grading from nvmem cells before
registering cpufreq-dt.
This driver allows unlocking all frequencies for imx8mm and imx8mq and
could be applied to other chips like imx7d
Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
---
drivers/cpufreq/Kconfig.arm | 9 +++
drivers/cpufreq/Makefile | 1 +
drivers/cpufreq/cpufreq-dt-platdev.c | 3 +
drivers/cpufreq/imx-cpufreq-dt.c | 96 ++++++++++++++++++++++++++++
drivers/soc/imx/soc-imx8.c | 3 +
5 files changed, 112 insertions(+)
create mode 100644 drivers/cpufreq/imx-cpufreq-dt.c
diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index 179a1d302f48..982efdf9c7e5 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -90,10 +90,19 @@ config ARM_IMX6Q_CPUFREQ
help
This adds cpufreq driver support for Freescale i.MX6 series SoCs.
If in doubt, say N.
+config ARM_IMX_CPUFREQ_DT
+ tristate "Freescale i.MX8M cpufreq support"
+ depends on ARCH_MXC && CPUFREQ_DT
+ help
+ This adds cpufreq driver support for Freescale i.MX8M series SoCs,
+ based on cpufreq-dt.
+
+ If in doubt, say N.
+
config ARM_KIRKWOOD_CPUFREQ
def_bool MACH_KIRKWOOD
help
This adds the CPUFreq driver for Marvell Kirkwood
SoCs.
diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
index 689b26c6f949..7bcda2273d0c 100644
--- a/drivers/cpufreq/Makefile
+++ b/drivers/cpufreq/Makefile
@@ -54,10 +54,11 @@ obj-$(CONFIG_ARM_ARMADA_8K_CPUFREQ) += armada-8k-cpufreq.o
obj-$(CONFIG_ARM_BRCMSTB_AVS_CPUFREQ) += brcmstb-avs-cpufreq.o
obj-$(CONFIG_ACPI_CPPC_CPUFREQ) += cppc_cpufreq.o
obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o
obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o
obj-$(CONFIG_ARM_IMX6Q_CPUFREQ) += imx6q-cpufreq.o
+obj-$(CONFIG_ARM_IMX_CPUFREQ_DT) += imx-cpufreq-dt.o
obj-$(CONFIG_ARM_KIRKWOOD_CPUFREQ) += kirkwood-cpufreq.o
obj-$(CONFIG_ARM_MEDIATEK_CPUFREQ) += mediatek-cpufreq.o
obj-$(CONFIG_MACH_MVEBU_V7) += mvebu-cpufreq.o
obj-$(CONFIG_ARM_OMAP2PLUS_CPUFREQ) += omap-cpufreq.o
obj-$(CONFIG_ARM_PXA2xx_CPUFREQ) += pxa2xx-cpufreq.o
diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
index 47729a22c159..19c1aad57e26 100644
--- a/drivers/cpufreq/cpufreq-dt-platdev.c
+++ b/drivers/cpufreq/cpufreq-dt-platdev.c
@@ -106,10 +106,13 @@ static const struct of_device_id whitelist[] __initconst = {
*/
static const struct of_device_id blacklist[] __initconst = {
{ .compatible = "calxeda,highbank", },
{ .compatible = "calxeda,ecx-2000", },
+ { .compatible = "fsl,imx8mq", },
+ { .compatible = "fsl,imx8mm", },
+
{ .compatible = "marvell,armadaxp", },
{ .compatible = "mediatek,mt2701", },
{ .compatible = "mediatek,mt2712", },
{ .compatible = "mediatek,mt7622", },
diff --git a/drivers/cpufreq/imx-cpufreq-dt.c b/drivers/cpufreq/imx-cpufreq-dt.c
new file mode 100644
index 000000000000..e1aa346efa10
--- /dev/null
+++ b/drivers/cpufreq/imx-cpufreq-dt.c
@@ -0,0 +1,96 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright 2019 NXP
+ */
+
+#include <linux/cpu.h>
+#include <linux/err.h>
+#include <linux/init.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/nvmem-consumer.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
+#include <linux/pm_opp.h>
+#include <linux/slab.h>
+
+#define OCOTP_CFG3_SPEED_GRADE_SHIFT 8
+#define OCOTP_CFG3_SPEED_GRADE_MASK (0x3 << 8)
+#define OCOTP_CFG3_MKT_SEGMENT_SHIFT 6
+#define OCOTP_CFG3_MKT_SEGMENT_MASK (0x3 << 6)
+
+static const struct of_device_id imx_cpufreq_dt_match_list[] = {
+ { .compatible = "fsl,imx8mm" },
+ { .compatible = "fsl,imx8mq" },
+ {}
+};
+
+/* cpufreq-dt device registered by imx-cpufreq-dt */
+static struct platform_device *cpufreq_dt_pdev;
+static struct opp_table *cpufreq_opp_table;
+
+static int imx_cpufreq_dt_probe(struct platform_device *pdev)
+{
+ struct device *cpu_dev = get_cpu_device(0);
+ struct device_node *np;
+ const struct of_device_id *match;
+ u32 cell_value, supported_hw[2];
+ int speed_grade, mkt_segment;
+ int ret;
+
+ np = of_find_node_by_path("/");
+ match = of_match_node(imx_cpufreq_dt_match_list, np);
+ of_node_put(np);
+ if (!match)
+ return -ENODEV;
+
+ ret = nvmem_cell_read_u32(cpu_dev, "speed_grade", &cell_value);
+ if (ret)
+ return ret;
+
+ speed_grade = (cell_value & OCOTP_CFG3_SPEED_GRADE_MASK) >> OCOTP_CFG3_SPEED_GRADE_SHIFT;
+ mkt_segment = (cell_value & OCOTP_CFG3_MKT_SEGMENT_MASK) >> OCOTP_CFG3_MKT_SEGMENT_SHIFT;
+ supported_hw[0] = BIT(speed_grade);
+ supported_hw[1] = BIT(mkt_segment);
+ dev_info(&pdev->dev, "cpu speed grade %d mkt segment %d supported-hw %#x %#x\n",
+ speed_grade, mkt_segment, supported_hw[0], supported_hw[1]);
+
+ cpufreq_opp_table = dev_pm_opp_set_supported_hw(cpu_dev, supported_hw, 2);
+ if (IS_ERR(cpufreq_opp_table)) {
+ ret = PTR_ERR(cpufreq_opp_table);
+ dev_err(&pdev->dev, "Failed to set supported opp: %d\n", ret);
+ return ret;
+ }
+
+ cpufreq_dt_pdev = platform_device_register_data(
+ &pdev->dev, "cpufreq-dt", -1, NULL, 0);
+ if (IS_ERR(cpufreq_dt_pdev)) {
+ dev_pm_opp_put_supported_hw(cpufreq_opp_table);
+ ret = PTR_ERR(cpufreq_dt_pdev);
+ dev_err(&pdev->dev, "Failed to register cpufreq-dt: %d\n", ret);
+ return ret;
+ }
+
+ return 0;
+}
+
+static int imx_cpufreq_dt_remove(struct platform_device *pdev)
+{
+ platform_device_unregister(cpufreq_dt_pdev);
+ dev_pm_opp_put_supported_hw(cpufreq_opp_table);
+
+ return 0;
+}
+
+static struct platform_driver imx_cpufreq_dt_driver = {
+ .probe = imx_cpufreq_dt_probe,
+ .remove = imx_cpufreq_dt_remove,
+ .driver = {
+ .name = "imx-cpufreq-dt",
+ },
+};
+module_platform_driver(imx_cpufreq_dt_driver);
+
+MODULE_ALIAS("platform:imx-cpufreq-dt");
+MODULE_DESCRIPTION("Freescale i.MX cpufreq speed grading driver");
+MODULE_LICENSE("GPL v2");
diff --git a/drivers/soc/imx/soc-imx8.c b/drivers/soc/imx/soc-imx8.c
index cd10726e64e4..02988bdfbb73 100644
--- a/drivers/soc/imx/soc-imx8.c
+++ b/drivers/soc/imx/soc-imx8.c
@@ -130,10 +130,13 @@ static int __init imx8_soc_init(void)
soc_dev = soc_device_register(soc_dev_attr);
if (IS_ERR(soc_dev))
goto free_rev;
+ if (IS_ENABLED(CONFIG_ARM_IMX_CPUFREQ_DT))
+ platform_device_register_simple("imx-cpufreq-dt", -1, NULL, 0);
+
return 0;
free_rev:
kfree(soc_dev_attr->revision);
free_soc:
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v4 2/5] dt-bindings: imx-cpufreq-dt: Document opp-supported-hw usage
2019-05-13 11:01 [PATCH v4 0/5] cpufreq: Add imx-cpufreq-dt driver for speed grading Leonard Crestez
2019-05-13 11:01 ` [PATCH v4 1/5] cpufreq: Add imx-cpufreq-dt driver Leonard Crestez
@ 2019-05-13 11:01 ` Leonard Crestez
2019-05-13 17:16 ` Rob Herring
2019-05-13 11:01 ` [PATCH v4 3/5] arm64: dts: imx8mm: Add cpu speed grading and all OPPs Leonard Crestez
` (3 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Leonard Crestez @ 2019-05-13 11:01 UTC (permalink / raw)
To: Viresh Kumar, Shawn Guo, Rob Herring
Cc: Mark Rutland, Aisheng Dong, Jacky Bai, Anson Huang, linux-pm,
Rafael J. Wysocki, devicetree, dl-linux-imx, kernel,
Fabio Estevam, Lucas Stach, linux-arm-kernel, Abel Vesa
The interpretation of opp-supported-hw bits for imx-cpufreq-dt driver is
not very obvious so attempt to explain it.
There is no OF compat string associated.
Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
---
.../bindings/cpufreq/imx-cpufreq-dt.txt | 37 +++++++++++++++++++
1 file changed, 37 insertions(+)
create mode 100644 Documentation/devicetree/bindings/cpufreq/imx-cpufreq-dt.txt
diff --git a/Documentation/devicetree/bindings/cpufreq/imx-cpufreq-dt.txt b/Documentation/devicetree/bindings/cpufreq/imx-cpufreq-dt.txt
new file mode 100644
index 000000000000..87bff5add3f9
--- /dev/null
+++ b/Documentation/devicetree/bindings/cpufreq/imx-cpufreq-dt.txt
@@ -0,0 +1,37 @@
+i.MX CPUFreq-DT OPP bindings
+================================
+
+Certain i.MX SoCs support different OPPs depending on the "market segment" and
+"speed grading" value which are written in fuses. These bits are combined with
+the opp-supported-hw values for each OPP to check if the OPP is allowed.
+
+Required properties:
+--------------------
+
+For each opp entry in 'operating-points-v2' table:
+- opp-supported-hw: Two bitmaps indicating:
+ - Supported speed grade mask
+ - Supported market segment mask
+ 0: Consumer
+ 1: Extended Consumer
+ 2: Industrial
+ 3: Automotive
+
+Example:
+--------
+
+opp_table {
+ compatible = "operating-points-v2";
+ opp-1000000000 {
+ opp-hz = /bits/ 64 <1000000000>;
+ /* grade >= 0, consumer only */
+ opp-supported-hw = <0xf>, <0x3>;
+ };
+
+ opp-1300000000 {
+ opp-hz = /bits/ 64 <1300000000>;
+ opp-microvolt = <1000000>;
+ /* grade >= 1, all segments */
+ opp-supported-hw = <0xe>, <0x7>;
+ };
+}
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v4 3/5] arm64: dts: imx8mm: Add cpu speed grading and all OPPs
2019-05-13 11:01 [PATCH v4 0/5] cpufreq: Add imx-cpufreq-dt driver for speed grading Leonard Crestez
2019-05-13 11:01 ` [PATCH v4 1/5] cpufreq: Add imx-cpufreq-dt driver Leonard Crestez
2019-05-13 11:01 ` [PATCH v4 2/5] dt-bindings: imx-cpufreq-dt: Document opp-supported-hw usage Leonard Crestez
@ 2019-05-13 11:01 ` Leonard Crestez
2019-05-21 8:01 ` Shawn Guo
2019-05-13 11:01 ` [PATCH v4 4/5] arm64: dts: imx8mq: " Leonard Crestez
` (2 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Leonard Crestez @ 2019-05-13 11:01 UTC (permalink / raw)
To: Viresh Kumar, Shawn Guo, Rob Herring
Cc: Mark Rutland, Aisheng Dong, Jacky Bai, Anson Huang, linux-pm,
Rafael J. Wysocki, devicetree, dl-linux-imx, kernel,
Fabio Estevam, Lucas Stach, linux-arm-kernel, Abel Vesa
Add a nvmem cell on cpu node referencing speed grade and the 1.8 Ghz
cpufreq opp.
Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
---
arch/arm64/boot/dts/freescale/imx8mm.dtsi | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index 6b407a94c06e..7e458dbbd017 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -51,10 +51,12 @@
clock-latency = <61036>; /* two CLK32 periods */
clocks = <&clk IMX8MM_CLK_ARM>;
enable-method = "psci";
next-level-cache = <&A53_L2>;
operating-points-v2 = <&a53_opp_table>;
+ nvmem-cells = <&cpu_speed_grade>;
+ nvmem-cell-names = "speed_grade";
};
A53_1: cpu@1 {
device_type = "cpu";
compatible = "arm,cortex-a53";
@@ -98,18 +100,27 @@
opp-shared;
opp-1200000000 {
opp-hz = /bits/ 64 <1200000000>;
opp-microvolt = <850000>;
+ opp-supported-hw = <0xe>, <0x7>;
clock-latency-ns = <150000>;
};
opp-1600000000 {
opp-hz = /bits/ 64 <1600000000>;
opp-microvolt = <900000>;
+ opp-supported-hw = <0xc>, <0x7>;
+ clock-latency-ns = <150000>;
+ };
+
+ opp-1800000000 {
+ opp-hz = /bits/ 64 <1800000000>;
+ opp-microvolt = <1000000>;
+ /* Consumer only but rely on speed grading */
+ opp-supported-hw = <0x8>, <0x7>;
clock-latency-ns = <150000>;
- opp-suspend;
};
};
memory@40000000 {
device_type = "memory";
@@ -317,10 +328,14 @@
reg = <0x30350000 0x10000>;
clocks = <&clk IMX8MM_CLK_OCOTP_ROOT>;
/* For nvmem subnodes */
#address-cells = <1>;
#size-cells = <1>;
+
+ cpu_speed_grade: speed-grade@10 {
+ reg = <0x10 4>;
+ };
};
anatop: anatop@30360000 {
compatible = "fsl,imx8mm-anatop", "syscon", "simple-bus";
reg = <0x30360000 0x10000>;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v4 4/5] arm64: dts: imx8mq: Add cpu speed grading and all OPPs
2019-05-13 11:01 [PATCH v4 0/5] cpufreq: Add imx-cpufreq-dt driver for speed grading Leonard Crestez
` (2 preceding siblings ...)
2019-05-13 11:01 ` [PATCH v4 3/5] arm64: dts: imx8mm: Add cpu speed grading and all OPPs Leonard Crestez
@ 2019-05-13 11:01 ` Leonard Crestez
2019-05-21 8:01 ` Shawn Guo
2019-05-13 11:01 ` [PATCH v4 5/5] arm64: defconfig: ARM_IMX_CPUFREQ_DT=m Leonard Crestez
2019-05-14 7:13 ` [PATCH v4 0/5] cpufreq: Add imx-cpufreq-dt driver for speed grading Viresh Kumar
5 siblings, 1 reply; 13+ messages in thread
From: Leonard Crestez @ 2019-05-13 11:01 UTC (permalink / raw)
To: Viresh Kumar, Shawn Guo, Rob Herring
Cc: Mark Rutland, Aisheng Dong, Jacky Bai, Anson Huang, linux-pm,
Rafael J. Wysocki, devicetree, dl-linux-imx, kernel,
Fabio Estevam, Lucas Stach, linux-arm-kernel, Abel Vesa
Add nvmem-cells reference to cpu and fill the OPP table with all known
OPPs.
Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
---
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 26 ++++++++++++++++++++++-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 6d635ba0904c..729376919d08 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -93,10 +93,12 @@
clocks = <&clk IMX8MQ_CLK_ARM>;
enable-method = "psci";
next-level-cache = <&A53_L2>;
operating-points-v2 = <&a53_opp_table>;
#cooling-cells = <2>;
+ nvmem-cells = <&cpu_speed_grade>;
+ nvmem-cell-names = "speed_grade";
};
A53_1: cpu@1 {
device_type = "cpu";
compatible = "arm,cortex-a53";
@@ -143,18 +145,36 @@
opp-shared;
opp-800000000 {
opp-hz = /bits/ 64 <800000000>;
opp-microvolt = <900000>;
+ /* Industrial only */
+ opp-supported-hw = <0xf>, <0x4>;
+ clock-latency-ns = <150000>;
+ };
+
+ opp-1000000000 {
+ opp-hz = /bits/ 64 <1000000000>;
+ opp-microvolt = <900000>;
+ /* Consumer only */
+ opp-supported-hw = <0xe>, <0x3>;
clock-latency-ns = <150000>;
};
opp-1300000000 {
opp-hz = /bits/ 64 <1300000000>;
opp-microvolt = <1000000>;
+ opp-supported-hw = <0xc>, <0x7>;
+ clock-latency-ns = <150000>;
+ };
+
+ opp-1500000000 {
+ opp-hz = /bits/ 64 <1500000000>;
+ opp-microvolt = <1000000>;
+ /* Consumer only but rely on speed grading */
+ opp-supported-hw = <0x8>, <0x7>;
clock-latency-ns = <150000>;
- opp-suspend;
};
};
pmu {
compatible = "arm,cortex-a53-pmu";
@@ -413,10 +433,14 @@
compatible = "fsl,imx8mq-ocotp", "syscon";
reg = <0x30350000 0x10000>;
clocks = <&clk IMX8MQ_CLK_OCOTP_ROOT>;
#address-cells = <1>;
#size-cells = <1>;
+
+ cpu_speed_grade: speed-grade@10 {
+ reg = <0x10 4>;
+ };
};
anatop: syscon@30360000 {
compatible = "fsl,imx8mq-anatop", "syscon";
reg = <0x30360000 0x10000>;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v4 5/5] arm64: defconfig: ARM_IMX_CPUFREQ_DT=m
2019-05-13 11:01 [PATCH v4 0/5] cpufreq: Add imx-cpufreq-dt driver for speed grading Leonard Crestez
` (3 preceding siblings ...)
2019-05-13 11:01 ` [PATCH v4 4/5] arm64: dts: imx8mq: " Leonard Crestez
@ 2019-05-13 11:01 ` Leonard Crestez
2019-05-21 8:05 ` Shawn Guo
2019-05-14 7:13 ` [PATCH v4 0/5] cpufreq: Add imx-cpufreq-dt driver for speed grading Viresh Kumar
5 siblings, 1 reply; 13+ messages in thread
From: Leonard Crestez @ 2019-05-13 11:01 UTC (permalink / raw)
To: Viresh Kumar, Shawn Guo, Rob Herring
Cc: Mark Rutland, Aisheng Dong, Jacky Bai, Anson Huang, linux-pm,
Rafael J. Wysocki, devicetree, dl-linux-imx, kernel,
Fabio Estevam, Lucas Stach, linux-arm-kernel, Abel Vesa
For imx8m we need a separate small driver to read "speed grading"
information from fuses and determine which OPPs are supported.
Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index df756468eacc..8202b940f263 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -80,10 +80,11 @@ CONFIG_CPU_FREQ_GOV_CONSERVATIVE=m
CONFIG_CPU_FREQ_GOV_SCHEDUTIL=y
CONFIG_CPUFREQ_DT=y
CONFIG_ACPI_CPPC_CPUFREQ=m
CONFIG_ARM_ARMADA_37XX_CPUFREQ=y
CONFIG_ARM_SCPI_CPUFREQ=y
+CONFIG_ARM_IMX_CPUFREQ_DT=m
CONFIG_ARM_TEGRA186_CPUFREQ=y
CONFIG_ARM_SCPI_PROTOCOL=y
CONFIG_RASPBERRYPI_FIRMWARE=y
CONFIG_INTEL_STRATIX10_SERVICE=y
CONFIG_EFI_CAPSULE_LOADER=y
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v4 2/5] dt-bindings: imx-cpufreq-dt: Document opp-supported-hw usage
2019-05-13 11:01 ` [PATCH v4 2/5] dt-bindings: imx-cpufreq-dt: Document opp-supported-hw usage Leonard Crestez
@ 2019-05-13 17:16 ` Rob Herring
0 siblings, 0 replies; 13+ messages in thread
From: Rob Herring @ 2019-05-13 17:16 UTC (permalink / raw)
To: Leonard Crestez
Cc: Mark Rutland, Aisheng Dong, Abel Vesa, Anson Huang, linux-pm,
Viresh Kumar, Rafael J. Wysocki, devicetree, Jacky Bai,
dl-linux-imx, kernel, Fabio Estevam, Shawn Guo, linux-arm-kernel,
Lucas Stach
On Mon, 13 May 2019 11:01:39 +0000, Leonard Crestez wrote:
> The interpretation of opp-supported-hw bits for imx-cpufreq-dt driver is
> not very obvious so attempt to explain it.
>
> There is no OF compat string associated.
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> ---
> .../bindings/cpufreq/imx-cpufreq-dt.txt | 37 +++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/cpufreq/imx-cpufreq-dt.txt
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v4 0/5] cpufreq: Add imx-cpufreq-dt driver for speed grading
2019-05-13 11:01 [PATCH v4 0/5] cpufreq: Add imx-cpufreq-dt driver for speed grading Leonard Crestez
` (4 preceding siblings ...)
2019-05-13 11:01 ` [PATCH v4 5/5] arm64: defconfig: ARM_IMX_CPUFREQ_DT=m Leonard Crestez
@ 2019-05-14 7:13 ` Viresh Kumar
2019-05-20 7:14 ` Shawn Guo
5 siblings, 1 reply; 13+ messages in thread
From: Viresh Kumar @ 2019-05-14 7:13 UTC (permalink / raw)
To: Leonard Crestez
Cc: Mark Rutland, Aisheng Dong, Abel Vesa, Anson Huang, linux-pm,
Rafael J. Wysocki, devicetree, Rob Herring, Jacky Bai,
dl-linux-imx, kernel, Fabio Estevam, Shawn Guo, linux-arm-kernel,
Lucas Stach
On 13-05-19, 11:01, Leonard Crestez wrote:
> Right now in upstream imx8m cpufreq support just lists a common subset
> of OPPs because the higher ones should only be attempted after checking
> speed grading in fuses.
>
> Driver reads from nvmem and calls dev_pm_opp_set_supported_hw before
> registering cpufreq-dt.
Who will apply patches 3-5 ?
--
viresh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v4 0/5] cpufreq: Add imx-cpufreq-dt driver for speed grading
2019-05-14 7:13 ` [PATCH v4 0/5] cpufreq: Add imx-cpufreq-dt driver for speed grading Viresh Kumar
@ 2019-05-20 7:14 ` Shawn Guo
2019-05-20 10:13 ` Viresh Kumar
0 siblings, 1 reply; 13+ messages in thread
From: Shawn Guo @ 2019-05-20 7:14 UTC (permalink / raw)
To: Viresh Kumar
Cc: Mark Rutland, Aisheng Dong, Abel Vesa, Anson Huang, linux-pm,
Rafael J. Wysocki, devicetree, Rob Herring, Jacky Bai,
dl-linux-imx, kernel, Fabio Estevam, Leonard Crestez,
linux-arm-kernel, Lucas Stach
On Tue, May 14, 2019 at 12:43:22PM +0530, Viresh Kumar wrote:
> On 13-05-19, 11:01, Leonard Crestez wrote:
> > Right now in upstream imx8m cpufreq support just lists a common subset
> > of OPPs because the higher ones should only be attempted after checking
> > speed grading in fuses.
> >
> > Driver reads from nvmem and calls dev_pm_opp_set_supported_hw before
> > registering cpufreq-dt.
>
> Who will apply patches 3-5 ?
Me. Will apply them after the first two get applied.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v4 0/5] cpufreq: Add imx-cpufreq-dt driver for speed grading
2019-05-20 7:14 ` Shawn Guo
@ 2019-05-20 10:13 ` Viresh Kumar
0 siblings, 0 replies; 13+ messages in thread
From: Viresh Kumar @ 2019-05-20 10:13 UTC (permalink / raw)
To: Shawn Guo
Cc: Mark Rutland, Aisheng Dong, Abel Vesa, Anson Huang, linux-pm,
Rafael J. Wysocki, devicetree, Rob Herring, Jacky Bai,
dl-linux-imx, kernel, Fabio Estevam, Leonard Crestez,
linux-arm-kernel, Lucas Stach
On 20-05-19, 15:14, Shawn Guo wrote:
> On Tue, May 14, 2019 at 12:43:22PM +0530, Viresh Kumar wrote:
> > On 13-05-19, 11:01, Leonard Crestez wrote:
> > > Right now in upstream imx8m cpufreq support just lists a common subset
> > > of OPPs because the higher ones should only be attempted after checking
> > > speed grading in fuses.
> > >
> > > Driver reads from nvmem and calls dev_pm_opp_set_supported_hw before
> > > registering cpufreq-dt.
> >
> > Who will apply patches 3-5 ?
>
> Me. Will apply them after the first two get applied.
Applied just now.
--
viresh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v4 3/5] arm64: dts: imx8mm: Add cpu speed grading and all OPPs
2019-05-13 11:01 ` [PATCH v4 3/5] arm64: dts: imx8mm: Add cpu speed grading and all OPPs Leonard Crestez
@ 2019-05-21 8:01 ` Shawn Guo
0 siblings, 0 replies; 13+ messages in thread
From: Shawn Guo @ 2019-05-21 8:01 UTC (permalink / raw)
To: Leonard Crestez
Cc: Mark Rutland, Aisheng Dong, Abel Vesa, Anson Huang, linux-pm,
Viresh Kumar, Rafael J. Wysocki, devicetree, Rob Herring,
Jacky Bai, dl-linux-imx, kernel, Fabio Estevam, linux-arm-kernel,
Lucas Stach
On Mon, May 13, 2019 at 11:01:41AM +0000, Leonard Crestez wrote:
> Add a nvmem cell on cpu node referencing speed grade and the 1.8 Ghz
> cpufreq opp.
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v4 4/5] arm64: dts: imx8mq: Add cpu speed grading and all OPPs
2019-05-13 11:01 ` [PATCH v4 4/5] arm64: dts: imx8mq: " Leonard Crestez
@ 2019-05-21 8:01 ` Shawn Guo
0 siblings, 0 replies; 13+ messages in thread
From: Shawn Guo @ 2019-05-21 8:01 UTC (permalink / raw)
To: Leonard Crestez
Cc: Mark Rutland, Aisheng Dong, Abel Vesa, Anson Huang, linux-pm,
Viresh Kumar, Rafael J. Wysocki, devicetree, Rob Herring,
Jacky Bai, dl-linux-imx, kernel, Fabio Estevam, linux-arm-kernel,
Lucas Stach
On Mon, May 13, 2019 at 11:01:43AM +0000, Leonard Crestez wrote:
> Add nvmem-cells reference to cpu and fill the OPP table with all known
> OPPs.
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v4 5/5] arm64: defconfig: ARM_IMX_CPUFREQ_DT=m
2019-05-13 11:01 ` [PATCH v4 5/5] arm64: defconfig: ARM_IMX_CPUFREQ_DT=m Leonard Crestez
@ 2019-05-21 8:05 ` Shawn Guo
0 siblings, 0 replies; 13+ messages in thread
From: Shawn Guo @ 2019-05-21 8:05 UTC (permalink / raw)
To: Leonard Crestez
Cc: Mark Rutland, Aisheng Dong, Abel Vesa, Anson Huang, linux-pm,
Viresh Kumar, Rafael J. Wysocki, devicetree, Rob Herring,
Jacky Bai, dl-linux-imx, kernel, Fabio Estevam, linux-arm-kernel,
Lucas Stach
On Mon, May 13, 2019 at 11:01:44AM +0000, Leonard Crestez wrote:
> For imx8m we need a separate small driver to read "speed grading"
> information from fuses and determine which OPPs are supported.
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2019-05-21 8:06 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-13 11:01 [PATCH v4 0/5] cpufreq: Add imx-cpufreq-dt driver for speed grading Leonard Crestez
2019-05-13 11:01 ` [PATCH v4 1/5] cpufreq: Add imx-cpufreq-dt driver Leonard Crestez
2019-05-13 11:01 ` [PATCH v4 2/5] dt-bindings: imx-cpufreq-dt: Document opp-supported-hw usage Leonard Crestez
2019-05-13 17:16 ` Rob Herring
2019-05-13 11:01 ` [PATCH v4 3/5] arm64: dts: imx8mm: Add cpu speed grading and all OPPs Leonard Crestez
2019-05-21 8:01 ` Shawn Guo
2019-05-13 11:01 ` [PATCH v4 4/5] arm64: dts: imx8mq: " Leonard Crestez
2019-05-21 8:01 ` Shawn Guo
2019-05-13 11:01 ` [PATCH v4 5/5] arm64: defconfig: ARM_IMX_CPUFREQ_DT=m Leonard Crestez
2019-05-21 8:05 ` Shawn Guo
2019-05-14 7:13 ` [PATCH v4 0/5] cpufreq: Add imx-cpufreq-dt driver for speed grading Viresh Kumar
2019-05-20 7:14 ` Shawn Guo
2019-05-20 10:13 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).