* [PATCH] arm64: Fix the arm64_personality() syscall wrapper redirection
@ 2019-05-28 11:39 Catalin Marinas
2019-05-28 11:51 ` Will Deacon
2019-05-28 12:35 ` Mark Rutland
0 siblings, 2 replies; 3+ messages in thread
From: Catalin Marinas @ 2019-05-28 11:39 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Mark Rutland, Will Deacon, stable
Following commit 4378a7d4be30 ("arm64: implement syscall wrappers"), the
syscall function names gained the '__arm64_' prefix. Ensure that we
have the correct #define for redirecting a default syscall through a
wrapper.
Fixes: 4378a7d4be30 ("arm64: implement syscall wrappers")
Cc: <stable@vger.kernel.org> # 4.19.x-
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
---
arch/arm64/kernel/sys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/sys.c b/arch/arm64/kernel/sys.c
index 6f91e8116514..162a95ed0881 100644
--- a/arch/arm64/kernel/sys.c
+++ b/arch/arm64/kernel/sys.c
@@ -50,7 +50,7 @@ SYSCALL_DEFINE1(arm64_personality, unsigned int, personality)
/*
* Wrappers to pass the pt_regs argument.
*/
-#define sys_personality sys_arm64_personality
+#define __arm64_sys_personality __arm64_sys_arm64_personality
asmlinkage long sys_ni_syscall(const struct pt_regs *);
#define __arm64_sys_ni_syscall sys_ni_syscall
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: Fix the arm64_personality() syscall wrapper redirection
2019-05-28 11:39 [PATCH] arm64: Fix the arm64_personality() syscall wrapper redirection Catalin Marinas
@ 2019-05-28 11:51 ` Will Deacon
2019-05-28 12:35 ` Mark Rutland
1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2019-05-28 11:51 UTC (permalink / raw)
To: Catalin Marinas; +Cc: Mark Rutland, stable, linux-arm-kernel
On Tue, May 28, 2019 at 12:39:34PM +0100, Catalin Marinas wrote:
> Following commit 4378a7d4be30 ("arm64: implement syscall wrappers"), the
> syscall function names gained the '__arm64_' prefix. Ensure that we
> have the correct #define for redirecting a default syscall through a
> wrapper.
>
> Fixes: 4378a7d4be30 ("arm64: implement syscall wrappers")
> Cc: <stable@vger.kernel.org> # 4.19.x-
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> ---
> arch/arm64/kernel/sys.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/sys.c b/arch/arm64/kernel/sys.c
> index 6f91e8116514..162a95ed0881 100644
> --- a/arch/arm64/kernel/sys.c
> +++ b/arch/arm64/kernel/sys.c
> @@ -50,7 +50,7 @@ SYSCALL_DEFINE1(arm64_personality, unsigned int, personality)
> /*
> * Wrappers to pass the pt_regs argument.
> */
> -#define sys_personality sys_arm64_personality
> +#define __arm64_sys_personality __arm64_sys_arm64_personality
Cheers, I've picked this up as a fix for -rc3.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: Fix the arm64_personality() syscall wrapper redirection
2019-05-28 11:39 [PATCH] arm64: Fix the arm64_personality() syscall wrapper redirection Catalin Marinas
2019-05-28 11:51 ` Will Deacon
@ 2019-05-28 12:35 ` Mark Rutland
1 sibling, 0 replies; 3+ messages in thread
From: Mark Rutland @ 2019-05-28 12:35 UTC (permalink / raw)
To: Catalin Marinas; +Cc: Will Deacon, stable, linux-arm-kernel
On Tue, May 28, 2019 at 12:39:34PM +0100, Catalin Marinas wrote:
> Following commit 4378a7d4be30 ("arm64: implement syscall wrappers"), the
> syscall function names gained the '__arm64_' prefix. Ensure that we
> have the correct #define for redirecting a default syscall through a
> wrapper.
>
> Fixes: 4378a7d4be30 ("arm64: implement syscall wrappers")
> Cc: <stable@vger.kernel.org> # 4.19.x-
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Evidently I failed to test this case; sorry about that.
FWIW:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> ---
> arch/arm64/kernel/sys.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/sys.c b/arch/arm64/kernel/sys.c
> index 6f91e8116514..162a95ed0881 100644
> --- a/arch/arm64/kernel/sys.c
> +++ b/arch/arm64/kernel/sys.c
> @@ -50,7 +50,7 @@ SYSCALL_DEFINE1(arm64_personality, unsigned int, personality)
> /*
> * Wrappers to pass the pt_regs argument.
> */
> -#define sys_personality sys_arm64_personality
> +#define __arm64_sys_personality __arm64_sys_arm64_personality
>
> asmlinkage long sys_ni_syscall(const struct pt_regs *);
> #define __arm64_sys_ni_syscall sys_ni_syscall
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-28 12:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-28 11:39 [PATCH] arm64: Fix the arm64_personality() syscall wrapper redirection Catalin Marinas
2019-05-28 11:51 ` Will Deacon
2019-05-28 12:35 ` Mark Rutland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).