* [PATCH] arm64: configs: Enable GPIO_DAVINCI
@ 2019-06-05 6:14 Keerthy
2019-06-11 18:19 ` Tero Kristo
0 siblings, 1 reply; 3+ messages in thread
From: Keerthy @ 2019-06-05 6:14 UTC (permalink / raw)
To: will.deacon, catalin.marinas, shawnguo
Cc: nm, lokeshvutla, j-keerthy, linux-kernel, t-kristo, linux-arm-kernel
Enable GPIO_DAVINCI and related configs for TI K3 AM6 platforms.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
arch/arm64/configs/defconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index d1b72f99e2f4..57d7a4c207bd 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -385,6 +385,9 @@ CONFIG_PINCTRL_QCS404=y
CONFIG_PINCTRL_QDF2XXX=y
CONFIG_PINCTRL_QCOM_SPMI_PMIC=y
CONFIG_PINCTRL_SDM845=y
+CONFIG_DEBUG_GPIO=y
+CONFIG_GPIO_SYSFS=y
+CONFIG_GPIO_DAVINCI=y
CONFIG_GPIO_DWAPB=y
CONFIG_GPIO_MB86S7X=y
CONFIG_GPIO_PL061=y
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: configs: Enable GPIO_DAVINCI
2019-06-05 6:14 [PATCH] arm64: configs: Enable GPIO_DAVINCI Keerthy
@ 2019-06-11 18:19 ` Tero Kristo
2019-06-12 1:44 ` keerthy
0 siblings, 1 reply; 3+ messages in thread
From: Tero Kristo @ 2019-06-11 18:19 UTC (permalink / raw)
To: Keerthy, will.deacon, catalin.marinas, shawnguo
Cc: lokeshvutla, nm, linux-kernel, linux-arm-kernel
On 05/06/2019 09:14, Keerthy wrote:
> Enable GPIO_DAVINCI and related configs for TI K3 AM6 platforms.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> arch/arm64/configs/defconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index d1b72f99e2f4..57d7a4c207bd 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -385,6 +385,9 @@ CONFIG_PINCTRL_QCS404=y
> CONFIG_PINCTRL_QDF2XXX=y
> CONFIG_PINCTRL_QCOM_SPMI_PMIC=y
> CONFIG_PINCTRL_SDM845=y
> +CONFIG_DEBUG_GPIO=y
Why DEBUG_GPIO?
> +CONFIG_GPIO_SYSFS=y
Also, why GPIO_SYSFS?
Both of the above are nice for debugging purposes, but should not be
enabled by default imho, as they are not needed by drivers.
> +CONFIG_GPIO_DAVINCI=y
I think you should not modify defconfig, rather add these as platform
required features under arch/arm64/Kconfig.platforms?
-Tero
> CONFIG_GPIO_DWAPB=y
> CONFIG_GPIO_MB86S7X=y
> CONFIG_GPIO_PL061=y
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: configs: Enable GPIO_DAVINCI
2019-06-11 18:19 ` Tero Kristo
@ 2019-06-12 1:44 ` keerthy
0 siblings, 0 replies; 3+ messages in thread
From: keerthy @ 2019-06-12 1:44 UTC (permalink / raw)
To: Tero Kristo, will.deacon, catalin.marinas, shawnguo
Cc: lokeshvutla, nm, linux-kernel, linux-arm-kernel
On 6/11/2019 11:49 PM, Tero Kristo wrote:
> On 05/06/2019 09:14, Keerthy wrote:
>> Enable GPIO_DAVINCI and related configs for TI K3 AM6 platforms.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>> arch/arm64/configs/defconfig | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index d1b72f99e2f4..57d7a4c207bd 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -385,6 +385,9 @@ CONFIG_PINCTRL_QCS404=y
>> CONFIG_PINCTRL_QDF2XXX=y
>> CONFIG_PINCTRL_QCOM_SPMI_PMIC=y
>> CONFIG_PINCTRL_SDM845=y
>> +CONFIG_DEBUG_GPIO=y
>
> Why DEBUG_GPIO?
Okay this can be left out.
>
>> +CONFIG_GPIO_SYSFS=y
>
> Also, why GPIO_SYSFS?
This has been there for pretty much all the SoCs in the past
and one of the ways to validate GPIOs are functional. This is very much
needed IMHO.
>
> Both of the above are nice for debugging purposes, but should not be
> enabled by default imho, as they are not needed by drivers.
>
>> +CONFIG_GPIO_DAVINCI=y
>
> I think you should not modify defconfig, rather add these as platform
> required features under arch/arm64/Kconfig.platforms?
I observed CONFIG_RESET_TI_SCI, CONFIG_TI_SCI_PROTOCOL which are
platform specific in the defconfig and added them here. Already there
are n number of GPIO config options as well under defconfig. If the norm
is to add selects under arch/arm64/Kconfig.platforms then i am fine with
that as well. Kindly let me know.
- Keerthy
>
> -Tero
>
>> CONFIG_GPIO_DWAPB=y
>> CONFIG_GPIO_MB86S7X=y
>> CONFIG_GPIO_PL061=y
>>
>
> --
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-12 1:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-05 6:14 [PATCH] arm64: configs: Enable GPIO_DAVINCI Keerthy
2019-06-11 18:19 ` Tero Kristo
2019-06-12 1:44 ` keerthy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).