From: Mark Rutland <mark.rutland@arm.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: peterz@infradead.org, catalin.marinas@arm.com,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
Raphael Gault <raphael.gault@arm.com>,
mingo@redhat.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/7] perf: arm64: Compile tests unconditionally
Date: Tue, 11 Jun 2019 18:01:27 +0100 [thread overview]
Message-ID: <20190611170126.GH29008@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <20190611142356.GA28689@kernel.org>
On Tue, Jun 11, 2019 at 11:23:56AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jun 11, 2019 at 03:09:07PM +0100, Mark Rutland escreveu:
> > On Tue, Jun 11, 2019 at 01:53:09PM +0100, Raphael Gault wrote:
> > > In order to subsequently add more tests for the arm64 architecture
> > > we compile the tests target for arm64 systematically.
> >
> > Given prior questions regarding this commit, it's probably worth
> > spelling things out more explicitly, e.g.
> >
> > Currently we only build the arm64/tests directory if
> > CONFIG_DWARF_UNWIND is selected, which is fine as the only test we
> > have is arm64/tests/dwarf-unwind.o.
> >
> > So that we can add more tests to the test directory, let's
> > unconditionally build the directory, but conditionally build
> > dwarf-unwind.o depending on CONFIG_DWARF_UNWIND.
> >
> > There should be no functional change as a result of this patch.
> >
> > >
> > > Signed-off-by: Raphael Gault <raphael.gault@arm.com>
> >
> > Either way, the patch looks good to me:
> >
> > Acked-by: Mark Rutland <mark.rutland@arm.com>
>
> I'll update the comment, collect your Acked-by and apply the patch.
That's great, thanks!
As a heads-up, there are still open ABI discussions to be had on the
rest of the series, so while review would be appreciated, it would be
best to hold off applying the remaining userspace bits for now.
Mark.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-11 17:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 12:53 [PATCH 0/7] arm64: Enable access to pmu registers by user-space Raphael Gault
2019-06-11 12:53 ` [PATCH 1/7] perf: arm64: Compile tests unconditionally Raphael Gault
2019-06-11 14:09 ` Mark Rutland
2019-06-11 14:23 ` Arnaldo Carvalho de Melo
2019-06-11 17:01 ` Mark Rutland [this message]
2019-06-11 12:53 ` [PATCH 2/7] perf: arm64: Add test to check userspace access to hardware counters Raphael Gault
2019-06-11 12:53 ` [PATCH 3/7] perf: arm64: Use rseq to test userspace access to pmu counters Raphael Gault
2019-06-11 14:33 ` Arnaldo Carvalho de Melo
2019-06-11 16:57 ` Mark Rutland
2019-06-11 19:33 ` Mathieu Desnoyers
2019-06-13 7:10 ` Raphael Gault
2019-06-13 8:27 ` Mathieu Desnoyers
2019-06-13 11:02 ` Raphael Gault
2019-06-25 13:20 ` Raphael Gault
2019-06-25 13:29 ` Raphael Gault
2019-06-25 13:41 ` Will Deacon
2019-06-11 12:53 ` [PATCH 4/7] arm64: pmu: Add function implementation to update event index in userpage Raphael Gault
2019-06-11 12:53 ` [PATCH 5/7] arm64: pmu: Add hook to handle pmu-related undefined instructions Raphael Gault
2019-06-11 12:53 ` [PATCH 6/7] arm64: perf: Enable pmu counter direct access for perf event on armv8 Raphael Gault
2019-06-11 12:53 ` [PATCH 7/7] Documentation: arm64: Document PMU counters access from userspace Raphael Gault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611170126.GH29008@lakrids.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=arnaldo.melo@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=raphael.gault@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).