linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] ARM: dts: imx6ull-colibri: enable UHS-I for USDHC1
@ 2019-06-06  9:06 Igor Opaniuk
  2019-06-06 10:31 ` Marcel Ziswiler
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Igor Opaniuk @ 2019-06-06  9:06 UTC (permalink / raw)
  To: devicetree, linux-kernel, linux-arm-kernel
  Cc: mark.rutland, marcel.ziswiler, shawnguo, s.hauer, stefan,
	robh+dt, linux-imx, kernel, festevam, marcel

From: Igor Opaniuk <igor.opaniuk@toradex.com>

Allows to use the SD interface at a higher speed mode if the card
supports it. For this the signaling voltage is switched from 3.3V to
1.8V under the usdhc1's drivers control.

Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
---
 arch/arm/boot/dts/imx6ul.dtsi                  |  4 ++++
 arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi | 11 +++++++++--
 arch/arm/boot/dts/imx6ull-colibri.dtsi         |  6 ++++++
 3 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
index fc388b84bf22..91a0ced44e27 100644
--- a/arch/arm/boot/dts/imx6ul.dtsi
+++ b/arch/arm/boot/dts/imx6ul.dtsi
@@ -857,6 +857,8 @@
 					 <&clks IMX6UL_CLK_USDHC1>,
 					 <&clks IMX6UL_CLK_USDHC1>;
 				clock-names = "ipg", "ahb", "per";
+				fsl,tuning-step= <2>;
+				fsl,tuning-start-tap = <20>;
 				bus-width = <4>;
 				status = "disabled";
 			};
@@ -870,6 +872,8 @@
 					 <&clks IMX6UL_CLK_USDHC2>;
 				clock-names = "ipg", "ahb", "per";
 				bus-width = <4>;
+				fsl,tuning-step= <2>;
+				fsl,tuning-start-tap = <20>;
 				status = "disabled";
 			};
 
diff --git a/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi b/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
index 006690ea98c0..7dc7770cf52c 100644
--- a/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
+++ b/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
@@ -145,13 +145,20 @@
 };
 
 &usdhc1 {
-	pinctrl-names = "default";
+	pinctrl-names = "default", "state_100mhz", "state_200mhz", "sleep";
 	pinctrl-0 = <&pinctrl_usdhc1 &pinctrl_snvs_usdhc1_cd>;
-	no-1-8-v;
+	pinctrl-1 = <&pinctrl_usdhc1_100mhz &pinctrl_snvs_usdhc1_cd>;
+	pinctrl-2 = <&pinctrl_usdhc1_100mhz &pinctrl_snvs_usdhc1_cd>;
+	pinctrl-3 = <&pinctrl_usdhc1 &pinctrl_snvs_usdhc1_sleep_cd>;
 	cd-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>;
 	disable-wp;
 	wakeup-source;
 	keep-power-in-suspend;
 	vmmc-supply = <&reg_3v3>;
+	vqmmc-supply = <&reg_sd1_vmmc>;
+	sd-uhs-sdr12;
+	sd-uhs-sdr25;
+	sd-uhs-sdr50;
+	sd-uhs-sdr104;
 	status = "okay";
 };
diff --git a/arch/arm/boot/dts/imx6ull-colibri.dtsi b/arch/arm/boot/dts/imx6ull-colibri.dtsi
index 9ad1da159768..d56728f03c35 100644
--- a/arch/arm/boot/dts/imx6ull-colibri.dtsi
+++ b/arch/arm/boot/dts/imx6ull-colibri.dtsi
@@ -545,6 +545,12 @@
 		>;
 	};
 
+	pinctrl_snvs_usdhc1_sleep_cd: snvs-usdhc1-cd-grp-slp {
+		fsl,pins = <
+			MX6ULL_PAD_SNVS_TAMPER0__GPIO5_IO00	0x0
+		>;
+	};
+
 	pinctrl_snvs_wifi_pdn: snvs-wifi-pdn-grp {
 		fsl,pins = <
 			MX6ULL_PAD_BOOT_MODE1__GPIO5_IO11	0x14
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] ARM: dts: imx6ull-colibri: enable UHS-I for USDHC1
  2019-06-06  9:06 [PATCH 1/1] ARM: dts: imx6ull-colibri: enable UHS-I for USDHC1 Igor Opaniuk
@ 2019-06-06 10:31 ` Marcel Ziswiler
  2019-06-12 10:45 ` Shawn Guo
  2019-06-12 12:17 ` Stefan Agner
  2 siblings, 0 replies; 7+ messages in thread
From: Marcel Ziswiler @ 2019-06-06 10:31 UTC (permalink / raw)
  To: linux-arm-kernel, devicetree, igor.opaniuk, linux-kernel
  Cc: mark.rutland, festevam, s.hauer, stefan, robh+dt, linux-imx,
	kernel, shawnguo

On Thu, 2019-06-06 at 12:06 +0300, Igor Opaniuk wrote:
> From: Igor Opaniuk <igor.opaniuk@toradex.com>
> 
> Allows to use the SD interface at a higher speed mode if the card
> supports it. For this the signaling voltage is switched from 3.3V to
> 1.8V under the usdhc1's drivers control.
> 
> Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>

Reviewed-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

> ---
>  arch/arm/boot/dts/imx6ul.dtsi                  |  4 ++++
>  arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi | 11 +++++++++--
>  arch/arm/boot/dts/imx6ull-colibri.dtsi         |  6 ++++++
>  3 files changed, 19 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6ul.dtsi
> b/arch/arm/boot/dts/imx6ul.dtsi
> index fc388b84bf22..91a0ced44e27 100644
> --- a/arch/arm/boot/dts/imx6ul.dtsi
> +++ b/arch/arm/boot/dts/imx6ul.dtsi
> @@ -857,6 +857,8 @@
>  					 <&clks IMX6UL_CLK_USDHC1>,
>  					 <&clks IMX6UL_CLK_USDHC1>;
>  				clock-names = "ipg", "ahb", "per";
> +				fsl,tuning-step= <2>;
> +				fsl,tuning-start-tap = <20>;
>  				bus-width = <4>;
>  				status = "disabled";
>  			};
> @@ -870,6 +872,8 @@
>  					 <&clks IMX6UL_CLK_USDHC2>;
>  				clock-names = "ipg", "ahb", "per";
>  				bus-width = <4>;
> +				fsl,tuning-step= <2>;
> +				fsl,tuning-start-tap = <20>;
>  				status = "disabled";
>  			};
>  
> diff --git a/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> b/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> index 006690ea98c0..7dc7770cf52c 100644
> --- a/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> +++ b/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> @@ -145,13 +145,20 @@
>  };
>  
>  &usdhc1 {
> -	pinctrl-names = "default";
> +	pinctrl-names = "default", "state_100mhz", "state_200mhz",
> "sleep";
>  	pinctrl-0 = <&pinctrl_usdhc1 &pinctrl_snvs_usdhc1_cd>;
> -	no-1-8-v;
> +	pinctrl-1 = <&pinctrl_usdhc1_100mhz &pinctrl_snvs_usdhc1_cd>;
> +	pinctrl-2 = <&pinctrl_usdhc1_100mhz &pinctrl_snvs_usdhc1_cd>;
> +	pinctrl-3 = <&pinctrl_usdhc1 &pinctrl_snvs_usdhc1_sleep_cd>;
>  	cd-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>;
>  	disable-wp;
>  	wakeup-source;
>  	keep-power-in-suspend;
>  	vmmc-supply = <&reg_3v3>;
> +	vqmmc-supply = <&reg_sd1_vmmc>;
> +	sd-uhs-sdr12;
> +	sd-uhs-sdr25;
> +	sd-uhs-sdr50;
> +	sd-uhs-sdr104;
>  	status = "okay";
>  };
> diff --git a/arch/arm/boot/dts/imx6ull-colibri.dtsi
> b/arch/arm/boot/dts/imx6ull-colibri.dtsi
> index 9ad1da159768..d56728f03c35 100644
> --- a/arch/arm/boot/dts/imx6ull-colibri.dtsi
> +++ b/arch/arm/boot/dts/imx6ull-colibri.dtsi
> @@ -545,6 +545,12 @@
>  		>;
>  	};
>  
> +	pinctrl_snvs_usdhc1_sleep_cd: snvs-usdhc1-cd-grp-slp {
> +		fsl,pins = <
> +			MX6ULL_PAD_SNVS_TAMPER0__GPIO5_IO00	0x0
> +		>;
> +	};
> +
>  	pinctrl_snvs_wifi_pdn: snvs-wifi-pdn-grp {
>  		fsl,pins = <
>  			MX6ULL_PAD_BOOT_MODE1__GPIO5_IO11	0x14
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] ARM: dts: imx6ull-colibri: enable UHS-I for USDHC1
  2019-06-06  9:06 [PATCH 1/1] ARM: dts: imx6ull-colibri: enable UHS-I for USDHC1 Igor Opaniuk
  2019-06-06 10:31 ` Marcel Ziswiler
@ 2019-06-12 10:45 ` Shawn Guo
  2019-06-12 12:17 ` Stefan Agner
  2 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2019-06-12 10:45 UTC (permalink / raw)
  To: Igor Opaniuk
  Cc: mark.rutland, devicetree, marcel.ziswiler, s.hauer, linux-kernel,
	stefan, robh+dt, linux-imx, kernel, festevam, linux-arm-kernel,
	marcel

On Thu, Jun 06, 2019 at 12:06:12PM +0300, Igor Opaniuk wrote:
> From: Igor Opaniuk <igor.opaniuk@toradex.com>
> 
> Allows to use the SD interface at a higher speed mode if the card
> supports it. For this the signaling voltage is switched from 3.3V to
> 1.8V under the usdhc1's drivers control.
> 
> Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>

Applied, thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] ARM: dts: imx6ull-colibri: enable UHS-I for USDHC1
  2019-06-06  9:06 [PATCH 1/1] ARM: dts: imx6ull-colibri: enable UHS-I for USDHC1 Igor Opaniuk
  2019-06-06 10:31 ` Marcel Ziswiler
  2019-06-12 10:45 ` Shawn Guo
@ 2019-06-12 12:17 ` Stefan Agner
  2019-06-12 12:49   ` Igor Opaniuk
  2 siblings, 1 reply; 7+ messages in thread
From: Stefan Agner @ 2019-06-12 12:17 UTC (permalink / raw)
  To: Igor Opaniuk
  Cc: mark.rutland, devicetree, marcel.ziswiler, festevam, s.hauer,
	linux-kernel, robh+dt, linux-imx, kernel, shawnguo,
	linux-arm-kernel, marcel

On 06.06.2019 11:06, Igor Opaniuk wrote:
> From: Igor Opaniuk <igor.opaniuk@toradex.com>
> 
> Allows to use the SD interface at a higher speed mode if the card
> supports it. For this the signaling voltage is switched from 3.3V to
> 1.8V under the usdhc1's drivers control.
> 
> Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
> ---
>  arch/arm/boot/dts/imx6ul.dtsi                  |  4 ++++
>  arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi | 11 +++++++++--
>  arch/arm/boot/dts/imx6ull-colibri.dtsi         |  6 ++++++
>  3 files changed, 19 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> index fc388b84bf22..91a0ced44e27 100644
> --- a/arch/arm/boot/dts/imx6ul.dtsi
> +++ b/arch/arm/boot/dts/imx6ul.dtsi
> @@ -857,6 +857,8 @@
>  					 <&clks IMX6UL_CLK_USDHC1>,
>  					 <&clks IMX6UL_CLK_USDHC1>;
>  				clock-names = "ipg", "ahb", "per";
> +				fsl,tuning-step= <2>;
> +				fsl,tuning-start-tap = <20>;
>  				bus-width = <4>;
>  				status = "disabled";
>  			};
> @@ -870,6 +872,8 @@
>  					 <&clks IMX6UL_CLK_USDHC2>;
>  				clock-names = "ipg", "ahb", "per";
>  				bus-width = <4>;
> +				fsl,tuning-step= <2>;
> +				fsl,tuning-start-tap = <20>;
>  				status = "disabled";
>  			};
>  
> diff --git a/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> b/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> index 006690ea98c0..7dc7770cf52c 100644
> --- a/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> +++ b/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> @@ -145,13 +145,20 @@
>  };
>  
>  &usdhc1 {
> -	pinctrl-names = "default";
> +	pinctrl-names = "default", "state_100mhz", "state_200mhz", "sleep";
>  	pinctrl-0 = <&pinctrl_usdhc1 &pinctrl_snvs_usdhc1_cd>;
> -	no-1-8-v;
> +	pinctrl-1 = <&pinctrl_usdhc1_100mhz &pinctrl_snvs_usdhc1_cd>;
> +	pinctrl-2 = <&pinctrl_usdhc1_100mhz &pinctrl_snvs_usdhc1_cd>;

Should that not be pinctrl_usdhc1_200mhz?

--
Stefan

> +	pinctrl-3 = <&pinctrl_usdhc1 &pinctrl_snvs_usdhc1_sleep_cd>;
>  	cd-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>;
>  	disable-wp;
>  	wakeup-source;
>  	keep-power-in-suspend;
>  	vmmc-supply = <&reg_3v3>;
> +	vqmmc-supply = <&reg_sd1_vmmc>;
> +	sd-uhs-sdr12;
> +	sd-uhs-sdr25;
> +	sd-uhs-sdr50;
> +	sd-uhs-sdr104;
>  	status = "okay";
>  };
> diff --git a/arch/arm/boot/dts/imx6ull-colibri.dtsi
> b/arch/arm/boot/dts/imx6ull-colibri.dtsi
> index 9ad1da159768..d56728f03c35 100644
> --- a/arch/arm/boot/dts/imx6ull-colibri.dtsi
> +++ b/arch/arm/boot/dts/imx6ull-colibri.dtsi
> @@ -545,6 +545,12 @@
>  		>;
>  	};
>  
> +	pinctrl_snvs_usdhc1_sleep_cd: snvs-usdhc1-cd-grp-slp {
> +		fsl,pins = <
> +			MX6ULL_PAD_SNVS_TAMPER0__GPIO5_IO00	0x0
> +		>;
> +	};
> +
>  	pinctrl_snvs_wifi_pdn: snvs-wifi-pdn-grp {
>  		fsl,pins = <
>  			MX6ULL_PAD_BOOT_MODE1__GPIO5_IO11	0x14

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] ARM: dts: imx6ull-colibri: enable UHS-I for USDHC1
  2019-06-12 12:17 ` Stefan Agner
@ 2019-06-12 12:49   ` Igor Opaniuk
  2019-06-12 13:38     ` Shawn Guo
  0 siblings, 1 reply; 7+ messages in thread
From: Igor Opaniuk @ 2019-06-12 12:49 UTC (permalink / raw)
  To: Stefan Agner
  Cc: mark.rutland, devicetree, Marcel Ziswiler, Fabio Estevam,
	s.hauer, linux-kernel, robh+dt, linux-imx, kernel, shawnguo,
	Linux ARM, Marcel Ziswiler

Hi Stefan,

On Wed, Jun 12, 2019 at 3:17 PM Stefan Agner <stefan@agner.ch> wrote:
>
> On 06.06.2019 11:06, Igor Opaniuk wrote:
> > From: Igor Opaniuk <igor.opaniuk@toradex.com>
> >
> > Allows to use the SD interface at a higher speed mode if the card
> > supports it. For this the signaling voltage is switched from 3.3V to
> > 1.8V under the usdhc1's drivers control.
> >
> > Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
> > ---
> >  arch/arm/boot/dts/imx6ul.dtsi                  |  4 ++++
> >  arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi | 11 +++++++++--
> >  arch/arm/boot/dts/imx6ull-colibri.dtsi         |  6 ++++++
> >  3 files changed, 19 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> > index fc388b84bf22..91a0ced44e27 100644
> > --- a/arch/arm/boot/dts/imx6ul.dtsi
> > +++ b/arch/arm/boot/dts/imx6ul.dtsi
> > @@ -857,6 +857,8 @@
> >                                        <&clks IMX6UL_CLK_USDHC1>,
> >                                        <&clks IMX6UL_CLK_USDHC1>;
> >                               clock-names = "ipg", "ahb", "per";
> > +                             fsl,tuning-step= <2>;
> > +                             fsl,tuning-start-tap = <20>;
> >                               bus-width = <4>;
> >                               status = "disabled";
> >                       };
> > @@ -870,6 +872,8 @@
> >                                        <&clks IMX6UL_CLK_USDHC2>;
> >                               clock-names = "ipg", "ahb", "per";
> >                               bus-width = <4>;
> > +                             fsl,tuning-step= <2>;
> > +                             fsl,tuning-start-tap = <20>;
> >                               status = "disabled";
> >                       };
> >
> > diff --git a/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> > b/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> > index 006690ea98c0..7dc7770cf52c 100644
> > --- a/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> > +++ b/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> > @@ -145,13 +145,20 @@
> >  };
> >
> >  &usdhc1 {
> > -     pinctrl-names = "default";
> > +     pinctrl-names = "default", "state_100mhz", "state_200mhz", "sleep";
> >       pinctrl-0 = <&pinctrl_usdhc1 &pinctrl_snvs_usdhc1_cd>;
> > -     no-1-8-v;
> > +     pinctrl-1 = <&pinctrl_usdhc1_100mhz &pinctrl_snvs_usdhc1_cd>;
> > +     pinctrl-2 = <&pinctrl_usdhc1_100mhz &pinctrl_snvs_usdhc1_cd>;
>
> Should that not be pinctrl_usdhc1_200mhz?
>

Correct, thanks for pointing this out.
Taking into account that the patch was already accepted by Shawn, will
send another to fix this typo ASAP (added to my todo list).

Thanks

> --
> Stefan
>
> > +     pinctrl-3 = <&pinctrl_usdhc1 &pinctrl_snvs_usdhc1_sleep_cd>;
> >       cd-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>;
> >       disable-wp;
> >       wakeup-source;
> >       keep-power-in-suspend;
> >       vmmc-supply = <&reg_3v3>;
> > +     vqmmc-supply = <&reg_sd1_vmmc>;
> > +     sd-uhs-sdr12;
> > +     sd-uhs-sdr25;
> > +     sd-uhs-sdr50;
> > +     sd-uhs-sdr104;
> >       status = "okay";
> >  };
> > diff --git a/arch/arm/boot/dts/imx6ull-colibri.dtsi
> > b/arch/arm/boot/dts/imx6ull-colibri.dtsi
> > index 9ad1da159768..d56728f03c35 100644
> > --- a/arch/arm/boot/dts/imx6ull-colibri.dtsi
> > +++ b/arch/arm/boot/dts/imx6ull-colibri.dtsi
> > @@ -545,6 +545,12 @@
> >               >;
> >       };
> >
> > +     pinctrl_snvs_usdhc1_sleep_cd: snvs-usdhc1-cd-grp-slp {
> > +             fsl,pins = <
> > +                     MX6ULL_PAD_SNVS_TAMPER0__GPIO5_IO00     0x0
> > +             >;
> > +     };
> > +
> >       pinctrl_snvs_wifi_pdn: snvs-wifi-pdn-grp {
> >               fsl,pins = <
> >                       MX6ULL_PAD_BOOT_MODE1__GPIO5_IO11       0x14



-- 
Best regards - Freundliche Grüsse - Meilleures salutations

Igor Opaniuk

mailto: igor.opaniuk@gmail.com
skype: igor.opanyuk
+380 (93) 836 40 67
http://ua.linkedin.com/in/iopaniuk

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] ARM: dts: imx6ull-colibri: enable UHS-I for USDHC1
  2019-06-12 12:49   ` Igor Opaniuk
@ 2019-06-12 13:38     ` Shawn Guo
  2019-06-12 14:29       ` Igor Opaniuk
  0 siblings, 1 reply; 7+ messages in thread
From: Shawn Guo @ 2019-06-12 13:38 UTC (permalink / raw)
  To: Igor Opaniuk
  Cc: mark.rutland, devicetree, Marcel Ziswiler, s.hauer, linux-kernel,
	Stefan Agner, robh+dt, linux-imx, kernel, Fabio Estevam,
	Linux ARM, Marcel Ziswiler

On Wed, Jun 12, 2019 at 03:49:03PM +0300, Igor Opaniuk wrote:
> Hi Stefan,
> 
> On Wed, Jun 12, 2019 at 3:17 PM Stefan Agner <stefan@agner.ch> wrote:
> >
> > On 06.06.2019 11:06, Igor Opaniuk wrote:
> > > From: Igor Opaniuk <igor.opaniuk@toradex.com>
> > >
> > > Allows to use the SD interface at a higher speed mode if the card
> > > supports it. For this the signaling voltage is switched from 3.3V to
> > > 1.8V under the usdhc1's drivers control.
> > >
> > > Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
> > > ---
> > >  arch/arm/boot/dts/imx6ul.dtsi                  |  4 ++++
> > >  arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi | 11 +++++++++--
> > >  arch/arm/boot/dts/imx6ull-colibri.dtsi         |  6 ++++++
> > >  3 files changed, 19 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> > > index fc388b84bf22..91a0ced44e27 100644
> > > --- a/arch/arm/boot/dts/imx6ul.dtsi
> > > +++ b/arch/arm/boot/dts/imx6ul.dtsi
> > > @@ -857,6 +857,8 @@
> > >                                        <&clks IMX6UL_CLK_USDHC1>,
> > >                                        <&clks IMX6UL_CLK_USDHC1>;
> > >                               clock-names = "ipg", "ahb", "per";
> > > +                             fsl,tuning-step= <2>;
> > > +                             fsl,tuning-start-tap = <20>;
> > >                               bus-width = <4>;
> > >                               status = "disabled";
> > >                       };
> > > @@ -870,6 +872,8 @@
> > >                                        <&clks IMX6UL_CLK_USDHC2>;
> > >                               clock-names = "ipg", "ahb", "per";
> > >                               bus-width = <4>;
> > > +                             fsl,tuning-step= <2>;
> > > +                             fsl,tuning-start-tap = <20>;
> > >                               status = "disabled";
> > >                       };
> > >
> > > diff --git a/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> > > b/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> > > index 006690ea98c0..7dc7770cf52c 100644
> > > --- a/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> > > +++ b/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> > > @@ -145,13 +145,20 @@
> > >  };
> > >
> > >  &usdhc1 {
> > > -     pinctrl-names = "default";
> > > +     pinctrl-names = "default", "state_100mhz", "state_200mhz", "sleep";
> > >       pinctrl-0 = <&pinctrl_usdhc1 &pinctrl_snvs_usdhc1_cd>;
> > > -     no-1-8-v;
> > > +     pinctrl-1 = <&pinctrl_usdhc1_100mhz &pinctrl_snvs_usdhc1_cd>;
> > > +     pinctrl-2 = <&pinctrl_usdhc1_100mhz &pinctrl_snvs_usdhc1_cd>;
> >
> > Should that not be pinctrl_usdhc1_200mhz?
> >
> 
> Correct, thanks for pointing this out.
> Taking into account that the patch was already accepted by Shawn, will
> send another to fix this typo ASAP (added to my todo list).

I just fixed it up on my branch.

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] ARM: dts: imx6ull-colibri: enable UHS-I for USDHC1
  2019-06-12 13:38     ` Shawn Guo
@ 2019-06-12 14:29       ` Igor Opaniuk
  0 siblings, 0 replies; 7+ messages in thread
From: Igor Opaniuk @ 2019-06-12 14:29 UTC (permalink / raw)
  To: Shawn Guo
  Cc: mark.rutland, devicetree, Marcel Ziswiler, s.hauer, linux-kernel,
	Stefan Agner, robh+dt, linux-imx, kernel, Fabio Estevam,
	Linux ARM, Marcel Ziswiler

On Wed, Jun 12, 2019 at 4:39 PM Shawn Guo <shawnguo@kernel.org> wrote:
>
> On Wed, Jun 12, 2019 at 03:49:03PM +0300, Igor Opaniuk wrote:
> > Hi Stefan,
> >
> > On Wed, Jun 12, 2019 at 3:17 PM Stefan Agner <stefan@agner.ch> wrote:
> > >
> > > On 06.06.2019 11:06, Igor Opaniuk wrote:
> > > > From: Igor Opaniuk <igor.opaniuk@toradex.com>
> > > >
> > > > Allows to use the SD interface at a higher speed mode if the card
> > > > supports it. For this the signaling voltage is switched from 3.3V to
> > > > 1.8V under the usdhc1's drivers control.
> > > >
> > > > Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
> > > > ---
> > > >  arch/arm/boot/dts/imx6ul.dtsi                  |  4 ++++
> > > >  arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi | 11 +++++++++--
> > > >  arch/arm/boot/dts/imx6ull-colibri.dtsi         |  6 ++++++
> > > >  3 files changed, 19 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> > > > index fc388b84bf22..91a0ced44e27 100644
> > > > --- a/arch/arm/boot/dts/imx6ul.dtsi
> > > > +++ b/arch/arm/boot/dts/imx6ul.dtsi
> > > > @@ -857,6 +857,8 @@
> > > >                                        <&clks IMX6UL_CLK_USDHC1>,
> > > >                                        <&clks IMX6UL_CLK_USDHC1>;
> > > >                               clock-names = "ipg", "ahb", "per";
> > > > +                             fsl,tuning-step= <2>;
> > > > +                             fsl,tuning-start-tap = <20>;
> > > >                               bus-width = <4>;
> > > >                               status = "disabled";
> > > >                       };
> > > > @@ -870,6 +872,8 @@
> > > >                                        <&clks IMX6UL_CLK_USDHC2>;
> > > >                               clock-names = "ipg", "ahb", "per";
> > > >                               bus-width = <4>;
> > > > +                             fsl,tuning-step= <2>;
> > > > +                             fsl,tuning-start-tap = <20>;
> > > >                               status = "disabled";
> > > >                       };
> > > >
> > > > diff --git a/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> > > > b/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> > > > index 006690ea98c0..7dc7770cf52c 100644
> > > > --- a/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> > > > +++ b/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> > > > @@ -145,13 +145,20 @@
> > > >  };
> > > >
> > > >  &usdhc1 {
> > > > -     pinctrl-names = "default";
> > > > +     pinctrl-names = "default", "state_100mhz", "state_200mhz", "sleep";
> > > >       pinctrl-0 = <&pinctrl_usdhc1 &pinctrl_snvs_usdhc1_cd>;
> > > > -     no-1-8-v;
> > > > +     pinctrl-1 = <&pinctrl_usdhc1_100mhz &pinctrl_snvs_usdhc1_cd>;
> > > > +     pinctrl-2 = <&pinctrl_usdhc1_100mhz &pinctrl_snvs_usdhc1_cd>;
> > >
> > > Should that not be pinctrl_usdhc1_200mhz?
> > >
> >
> > Correct, thanks for pointing this out.
> > Taking into account that the patch was already accepted by Shawn, will
> > send another to fix this typo ASAP (added to my todo list).
>
> I just fixed it up on my branch.
>
> Shawn

Thanks a lot!

-- 
Best regards - Freundliche Grüsse - Meilleures salutations

Igor Opaniuk

mailto: igor.opaniuk@gmail.com
skype: igor.opanyuk
+380 (93) 836 40 67
http://ua.linkedin.com/in/iopaniuk

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-06-12 14:30 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-06  9:06 [PATCH 1/1] ARM: dts: imx6ull-colibri: enable UHS-I for USDHC1 Igor Opaniuk
2019-06-06 10:31 ` Marcel Ziswiler
2019-06-12 10:45 ` Shawn Guo
2019-06-12 12:17 ` Stefan Agner
2019-06-12 12:49   ` Igor Opaniuk
2019-06-12 13:38     ` Shawn Guo
2019-06-12 14:29       ` Igor Opaniuk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).