* [PATCH -next] coresight: replicator: Add terminate entry for acpi_device_id tables
@ 2019-06-15 10:44 Wei Yongjun
2019-06-17 8:25 ` Suzuki K Poulose
2019-06-17 9:22 ` [PATCH -next v2] " Wei Yongjun
0 siblings, 2 replies; 4+ messages in thread
From: Wei Yongjun @ 2019-06-15 10:44 UTC (permalink / raw)
To: Mathieu Poirier, Suzuki K Poulose, Alexander Shishkin
Cc: kernel-janitors, Wei Yongjun, linux-kernel, linux-arm-kernel
Make sure acpi_device_id tables have terminate entry.
Fixes: 8f35caae1e1f ("coresight: acpi: Support for platform devices")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/hwtracing/coresight/coresight-replicator.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c
index 542952759941..0c73dc1073c0 100644
--- a/drivers/hwtracing/coresight/coresight-replicator.c
+++ b/drivers/hwtracing/coresight/coresight-replicator.c
@@ -300,6 +300,7 @@ static const struct of_device_id static_replicator_match[] = {
#ifdef CONFIG_ACPI
static const struct acpi_device_id static_replicator_acpi_ids[] = {
{"ARMHC985", 0}, /* ARM CoreSight Static Replicator */
+ {"", 0},
};
#endif
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] coresight: replicator: Add terminate entry for acpi_device_id tables
2019-06-15 10:44 [PATCH -next] coresight: replicator: Add terminate entry for acpi_device_id tables Wei Yongjun
@ 2019-06-17 8:25 ` Suzuki K Poulose
2019-06-17 9:22 ` [PATCH -next v2] " Wei Yongjun
1 sibling, 0 replies; 4+ messages in thread
From: Suzuki K Poulose @ 2019-06-17 8:25 UTC (permalink / raw)
To: weiyongjun1, mathieu.poirier, alexander.shishkin
Cc: kernel-janitors, linux-kernel, linux-arm-kernel
Hi
Thanks for the fix, please find my comment below.
On 15/06/2019 11:44, Wei Yongjun wrote:
> Make sure acpi_device_id tables have terminate entry.
>
> Fixes: 8f35caae1e1f ("coresight: acpi: Support for platform devices")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/hwtracing/coresight/coresight-replicator.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c
> index 542952759941..0c73dc1073c0 100644
> --- a/drivers/hwtracing/coresight/coresight-replicator.c
> +++ b/drivers/hwtracing/coresight/coresight-replicator.c
> @@ -300,6 +300,7 @@ static const struct of_device_id static_replicator_match[] = {
> #ifdef CONFIG_ACPI
> static const struct acpi_device_id static_replicator_acpi_ids[] = {
> {"ARMHC985", 0}, /* ARM CoreSight Static Replicator */
> + {"", 0},
nit: I would leave it {}, instead of creating an empty string.
With that :
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH -next v2] coresight: replicator: Add terminate entry for acpi_device_id tables
2019-06-15 10:44 [PATCH -next] coresight: replicator: Add terminate entry for acpi_device_id tables Wei Yongjun
2019-06-17 8:25 ` Suzuki K Poulose
@ 2019-06-17 9:22 ` Wei Yongjun
2019-06-18 16:57 ` Mathieu Poirier
1 sibling, 1 reply; 4+ messages in thread
From: Wei Yongjun @ 2019-06-17 9:22 UTC (permalink / raw)
To: Mathieu Poirier, Suzuki K Poulose, Alexander Shishkin
Cc: kernel-janitors, Wei Yongjun, linux-kernel, linux-arm-kernel
Make sure acpi_device_id tables have terminate entry.
Fixes: fe446287ec9f ("coresight: acpi: Support for platform devices")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
drivers/hwtracing/coresight/coresight-replicator.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c
index 542952759941..b7d6d59d56db 100644
--- a/drivers/hwtracing/coresight/coresight-replicator.c
+++ b/drivers/hwtracing/coresight/coresight-replicator.c
@@ -300,6 +300,7 @@ static const struct of_device_id static_replicator_match[] = {
#ifdef CONFIG_ACPI
static const struct acpi_device_id static_replicator_acpi_ids[] = {
{"ARMHC985", 0}, /* ARM CoreSight Static Replicator */
+ {}
};
#endif
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next v2] coresight: replicator: Add terminate entry for acpi_device_id tables
2019-06-17 9:22 ` [PATCH -next v2] " Wei Yongjun
@ 2019-06-18 16:57 ` Mathieu Poirier
0 siblings, 0 replies; 4+ messages in thread
From: Mathieu Poirier @ 2019-06-18 16:57 UTC (permalink / raw)
To: Wei Yongjun
Cc: Alexander Shishkin, kernel-janitors, Linux Kernel Mailing List,
linux-arm-kernel, Suzuki K Poulose
On Mon, 17 Jun 2019 at 03:15, Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> Make sure acpi_device_id tables have terminate entry.
>
> Fixes: fe446287ec9f ("coresight: acpi: Support for platform devices")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
> drivers/hwtracing/coresight/coresight-replicator.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c
> index 542952759941..b7d6d59d56db 100644
> --- a/drivers/hwtracing/coresight/coresight-replicator.c
> +++ b/drivers/hwtracing/coresight/coresight-replicator.c
> @@ -300,6 +300,7 @@ static const struct of_device_id static_replicator_match[] = {
> #ifdef CONFIG_ACPI
> static const struct acpi_device_id static_replicator_acpi_ids[] = {
> {"ARMHC985", 0}, /* ARM CoreSight Static Replicator */
> + {}
Applied - thanks
> };
> #endif
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-18 16:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-15 10:44 [PATCH -next] coresight: replicator: Add terminate entry for acpi_device_id tables Wei Yongjun
2019-06-17 8:25 ` Suzuki K Poulose
2019-06-17 9:22 ` [PATCH -next v2] " Wei Yongjun
2019-06-18 16:57 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).