linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms
@ 2019-06-21  7:07 Anson.Huang
  2019-06-21  7:07 ` [PATCH 2/4] dt-bindings: clock: imx8mm: Add system counter clock Anson.Huang
                   ` (3 more replies)
  0 siblings, 4 replies; 15+ messages in thread
From: Anson.Huang @ 2019-06-21  7:07 UTC (permalink / raw)
  To: catalin.marinas, will, robh+dt, mark.rutland, shawnguo, s.hauer,
	kernel, festevam, mturquette, sboyd, leonard.crestez,
	aisheng.dong, ping.bai, daniel.baluta, peng.fan, abel.vesa,
	linux-arm-kernel, linux-kernel, devicetree, linux-clk
  Cc: Linux-imx

From: Anson Huang <Anson.Huang@nxp.com>

ARCH_MXC platforms needs system counter as broadcast timer
to support cpuidle, enable it by default.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 arch/arm64/Kconfig.platforms | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index 4778c77..f5e623f 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -173,6 +173,7 @@ config ARCH_MXC
 	select PM
 	select PM_GENERIC_DOMAINS
 	select SOC_BUS
+	select TIMER_IMX_SYS_CTR
 	help
 	  This enables support for the ARMv8 based SoCs in the
 	  NXP i.MX family.
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 2/4] dt-bindings: clock: imx8mm: Add system counter clock
  2019-06-21  7:07 [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms Anson.Huang
@ 2019-06-21  7:07 ` Anson.Huang
  2019-07-09 20:18   ` Rob Herring
  2019-06-21  7:07 ` [PATCH 3/4] clk: imx8mm: Add system counter to clock tree Anson.Huang
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 15+ messages in thread
From: Anson.Huang @ 2019-06-21  7:07 UTC (permalink / raw)
  To: catalin.marinas, will, robh+dt, mark.rutland, shawnguo, s.hauer,
	kernel, festevam, mturquette, sboyd, leonard.crestez,
	aisheng.dong, ping.bai, daniel.baluta, peng.fan, abel.vesa,
	linux-arm-kernel, linux-kernel, devicetree, linux-clk
  Cc: Linux-imx

From: Anson Huang <Anson.Huang@nxp.com>

Add i.MX8MM system counter clock macro definition.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 include/dt-bindings/clock/imx8mm-clock.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/include/dt-bindings/clock/imx8mm-clock.h b/include/dt-bindings/clock/imx8mm-clock.h
index 07e6c68..a8c2124 100644
--- a/include/dt-bindings/clock/imx8mm-clock.h
+++ b/include/dt-bindings/clock/imx8mm-clock.h
@@ -248,6 +248,8 @@
 #define IMX8MM_CLK_SNVS_ROOT			228
 #define IMX8MM_CLK_GIC				229
 
-#define IMX8MM_CLK_END				230
+#define IMX8MM_CLK_SYS_CTR			230
+
+#define IMX8MM_CLK_END				231
 
 #endif
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 3/4] clk: imx8mm: Add system counter to clock tree
  2019-06-21  7:07 [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms Anson.Huang
  2019-06-21  7:07 ` [PATCH 2/4] dt-bindings: clock: imx8mm: Add system counter clock Anson.Huang
@ 2019-06-21  7:07 ` Anson.Huang
  2019-07-11  8:19   ` Abel Vesa
  2019-06-21  7:07 ` [PATCH 4/4] arm64: dts: imx8mm: Add system counter node Anson.Huang
  2019-06-24  2:22 ` [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms Shawn Guo
  3 siblings, 1 reply; 15+ messages in thread
From: Anson.Huang @ 2019-06-21  7:07 UTC (permalink / raw)
  To: catalin.marinas, will, robh+dt, mark.rutland, shawnguo, s.hauer,
	kernel, festevam, mturquette, sboyd, leonard.crestez,
	aisheng.dong, ping.bai, daniel.baluta, peng.fan, abel.vesa,
	linux-arm-kernel, linux-kernel, devicetree, linux-clk
  Cc: Linux-imx

From: Anson Huang <Anson.Huang@nxp.com>

i.MX8MM timer-imx-sysctr driver needs system counter clock
for proper function, add it into clock tree.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 drivers/clk/imx/clk-imx8mm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
index 43fa9c3..56d53dd 100644
--- a/drivers/clk/imx/clk-imx8mm.c
+++ b/drivers/clk/imx/clk-imx8mm.c
@@ -645,6 +645,8 @@ static int __init imx8mm_clocks_init(struct device_node *ccm_node)
 	clks[IMX8MM_CLK_DRAM_ALT_ROOT] = imx_clk_fixed_factor("dram_alt_root", "dram_alt", 1, 4);
 	clks[IMX8MM_CLK_DRAM_CORE] = imx_clk_mux2_flags("dram_core_clk", base + 0x9800, 24, 1, imx8mm_dram_core_sels, ARRAY_SIZE(imx8mm_dram_core_sels), CLK_IS_CRITICAL);
 
+	clks[IMX8MM_CLK_SYS_CTR] = imx_clk_fixed_factor("sys_ctr", "osc_24m", 1, 3);
+
 	clks[IMX8MM_CLK_ARM] = imx_clk_cpu("arm", "arm_a53_div",
 					   clks[IMX8MM_CLK_A53_DIV],
 					   clks[IMX8MM_CLK_A53_SRC],
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 4/4] arm64: dts: imx8mm: Add system counter node
  2019-06-21  7:07 [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms Anson.Huang
  2019-06-21  7:07 ` [PATCH 2/4] dt-bindings: clock: imx8mm: Add system counter clock Anson.Huang
  2019-06-21  7:07 ` [PATCH 3/4] clk: imx8mm: Add system counter to clock tree Anson.Huang
@ 2019-06-21  7:07 ` Anson.Huang
  2019-06-22 12:10   ` Martin Kepplinger
  2019-06-24  2:22 ` [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms Shawn Guo
  3 siblings, 1 reply; 15+ messages in thread
From: Anson.Huang @ 2019-06-21  7:07 UTC (permalink / raw)
  To: catalin.marinas, will, robh+dt, mark.rutland, shawnguo, s.hauer,
	kernel, festevam, mturquette, sboyd, leonard.crestez,
	aisheng.dong, ping.bai, daniel.baluta, peng.fan, abel.vesa,
	linux-arm-kernel, linux-kernel, devicetree, linux-clk
  Cc: Linux-imx

From: Anson Huang <Anson.Huang@nxp.com>

Add i.MX8MM system counter node to enable timer-imx-sysctr
broadcast timer driver.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mm.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index 232a741..f606efa 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -510,6 +510,15 @@
 				#pwm-cells = <2>;
 				status = "disabled";
 			};
+
+			system_counter: timer@306a0000 {
+				compatible = "nxp,sysctr-timer";
+				reg = <0x306a0000 0x30000>;
+				interrupts = <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&clk IMX8MM_CLK_SYS_CTR>;
+				clock-names = "per";
+			};
 		};
 
 		aips3: bus@30800000 {
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [PATCH 4/4] arm64: dts: imx8mm: Add system counter node
  2019-06-21  7:07 ` [PATCH 4/4] arm64: dts: imx8mm: Add system counter node Anson.Huang
@ 2019-06-22 12:10   ` Martin Kepplinger
  2019-06-23 11:20     ` Anson Huang
  0 siblings, 1 reply; 15+ messages in thread
From: Martin Kepplinger @ 2019-06-22 12:10 UTC (permalink / raw)
  To: Anson.Huang, catalin.marinas, will, robh+dt, mark.rutland,
	shawnguo, s.hauer, kernel, festevam, mturquette, sboyd,
	leonard.crestez, aisheng.dong, ping.bai, daniel.baluta, peng.fan,
	abel.vesa, linux-arm-kernel, linux-kernel, devicetree, linux-clk
  Cc: Linux-imx

On 21.06.19 09:07, Anson.Huang@nxp.com wrote:
> From: Anson Huang <Anson.Huang@nxp.com>
> 
> Add i.MX8MM system counter node to enable timer-imx-sysctr
> broadcast timer driver.
> 


do we need similar additions to imx8mq? If so, I think these would fit
in here too.

thanks,
                                martin


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: [PATCH 4/4] arm64: dts: imx8mm: Add system counter node
  2019-06-22 12:10   ` Martin Kepplinger
@ 2019-06-23 11:20     ` Anson Huang
  0 siblings, 0 replies; 15+ messages in thread
From: Anson Huang @ 2019-06-23 11:20 UTC (permalink / raw)
  To: Martin Kepplinger, catalin.marinas, will, robh+dt, mark.rutland,
	shawnguo, s.hauer, kernel, festevam, mturquette, sboyd,
	Leonard Crestez, Aisheng Dong, Jacky Bai, Daniel Baluta,
	Peng Fan, Abel Vesa, linux-arm-kernel, linux-kernel, devicetree,
	linux-clk
  Cc: dl-linux-imx

Hi, Martin

> -----Original Message-----
> From: Martin Kepplinger <martink@posteo.de>
> Sent: Saturday, June 22, 2019 8:10 PM
> To: Anson Huang <anson.huang@nxp.com>; catalin.marinas@arm.com;
> will@kernel.org; robh+dt@kernel.org; mark.rutland@arm.com;
> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> festevam@gmail.com; mturquette@baylibre.com; sboyd@kernel.org;
> Leonard Crestez <leonard.crestez@nxp.com>; Aisheng Dong
> <aisheng.dong@nxp.com>; Jacky Bai <ping.bai@nxp.com>; Daniel Baluta
> <daniel.baluta@nxp.com>; Peng Fan <peng.fan@nxp.com>; Abel Vesa
> <abel.vesa@nxp.com>; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-
> clk@vger.kernel.org
> Cc: dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH 4/4] arm64: dts: imx8mm: Add system counter node
> 
> On 21.06.19 09:07, Anson.Huang@nxp.com wrote:
> > From: Anson Huang <Anson.Huang@nxp.com>
> >
> > Add i.MX8MM system counter node to enable timer-imx-sysctr broadcast
> > timer driver.
> >
> 
> 
> do we need similar additions to imx8mq? If so, I think these would fit in here
> too.

i.MX8MQ has something different about system counter driver enablement, I did
it in another patch series.

Anson.

> 
> thanks,
>                                 martin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms
  2019-06-21  7:07 [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms Anson.Huang
                   ` (2 preceding siblings ...)
  2019-06-21  7:07 ` [PATCH 4/4] arm64: dts: imx8mm: Add system counter node Anson.Huang
@ 2019-06-24  2:22 ` Shawn Guo
  2019-06-24  2:26   ` Anson Huang
  2019-06-24  2:27   ` Shawn Guo
  3 siblings, 2 replies; 15+ messages in thread
From: Shawn Guo @ 2019-06-24  2:22 UTC (permalink / raw)
  To: Anson.Huang
  Cc: mark.rutland, aisheng.dong, peng.fan, festevam, ping.bai,
	devicetree, sboyd, catalin.marinas, s.hauer, linux-kernel,
	daniel.baluta, linux-clk, robh+dt, Linux-imx, kernel,
	leonard.crestez, will, mturquette, linux-arm-kernel, abel.vesa

On Fri, Jun 21, 2019 at 03:07:17PM +0800, Anson.Huang@nxp.com wrote:
> From: Anson Huang <Anson.Huang@nxp.com>
> 
> ARCH_MXC platforms needs system counter as broadcast timer
> to support cpuidle, enable it by default.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
>  arch/arm64/Kconfig.platforms | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 4778c77..f5e623f 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -173,6 +173,7 @@ config ARCH_MXC
>  	select PM
>  	select PM_GENERIC_DOMAINS
>  	select SOC_BUS
> +	select TIMER_IMX_SYS_CTR

Where is that driver?

Shawn

>  	help
>  	  This enables support for the ARMv8 based SoCs in the
>  	  NXP i.MX family.
> -- 
> 2.7.4
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms
  2019-06-24  2:22 ` [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms Shawn Guo
@ 2019-06-24  2:26   ` Anson Huang
  2019-06-24  2:27   ` Shawn Guo
  1 sibling, 0 replies; 15+ messages in thread
From: Anson Huang @ 2019-06-24  2:26 UTC (permalink / raw)
  To: Shawn Guo
  Cc: mark.rutland, Aisheng Dong, Peng Fan, festevam, Jacky Bai,
	devicetree, sboyd, catalin.marinas, s.hauer, linux-kernel,
	Daniel Baluta, linux-clk, robh+dt, dl-linux-imx, kernel,
	Leonard Crestez, will, mturquette, linux-arm-kernel, Abel Vesa

Hi, Shawn

> -----Original Message-----
> From: Shawn Guo <shawnguo@kernel.org>
> Sent: Monday, June 24, 2019 10:22 AM
> To: Anson Huang <anson.huang@nxp.com>
> Cc: catalin.marinas@arm.com; will@kernel.org; robh+dt@kernel.org;
> mark.rutland@arm.com; s.hauer@pengutronix.de; kernel@pengutronix.de;
> festevam@gmail.com; mturquette@baylibre.com; sboyd@kernel.org;
> Leonard Crestez <leonard.crestez@nxp.com>; Aisheng Dong
> <aisheng.dong@nxp.com>; Jacky Bai <ping.bai@nxp.com>; Daniel Baluta
> <daniel.baluta@nxp.com>; Peng Fan <peng.fan@nxp.com>; Abel Vesa
> <abel.vesa@nxp.com>; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-
> clk@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC
> platforms
> 
> On Fri, Jun 21, 2019 at 03:07:17PM +0800, Anson.Huang@nxp.com wrote:
> > From: Anson Huang <Anson.Huang@nxp.com>
> >
> > ARCH_MXC platforms needs system counter as broadcast timer to support
> > cpuidle, enable it by default.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> >  arch/arm64/Kconfig.platforms | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/Kconfig.platforms
> > b/arch/arm64/Kconfig.platforms index 4778c77..f5e623f 100644
> > --- a/arch/arm64/Kconfig.platforms
> > +++ b/arch/arm64/Kconfig.platforms
> > @@ -173,6 +173,7 @@ config ARCH_MXC
> >  	select PM
> >  	select PM_GENERIC_DOMAINS
> >  	select SOC_BUS
> > +	select TIMER_IMX_SYS_CTR
> 
> Where is that driver?

The driver is drivers/clocksource/timer-imx-sysctr.c, similar function as GPT.

Thanks,
Anson

> 
> Shawn
> 
> >  	help
> >  	  This enables support for the ARMv8 based SoCs in the
> >  	  NXP i.MX family.
> > --
> > 2.7.4
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms
  2019-06-24  2:22 ` [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms Shawn Guo
  2019-06-24  2:26   ` Anson Huang
@ 2019-06-24  2:27   ` Shawn Guo
  2019-06-24  2:35     ` Anson Huang
  1 sibling, 1 reply; 15+ messages in thread
From: Shawn Guo @ 2019-06-24  2:27 UTC (permalink / raw)
  To: Anson.Huang
  Cc: mark.rutland, aisheng.dong, peng.fan, ping.bai, will, devicetree,
	sboyd, catalin.marinas, s.hauer, linux-kernel, daniel.baluta,
	mturquette, robh+dt, Linux-imx, kernel, leonard.crestez,
	festevam, linux-clk, linux-arm-kernel, abel.vesa

On Mon, Jun 24, 2019 at 10:22:01AM +0800, Shawn Guo wrote:
> On Fri, Jun 21, 2019 at 03:07:17PM +0800, Anson.Huang@nxp.com wrote:
> > From: Anson Huang <Anson.Huang@nxp.com>
> > 
> > ARCH_MXC platforms needs system counter as broadcast timer
> > to support cpuidle, enable it by default.
> > 
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> >  arch/arm64/Kconfig.platforms | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> > index 4778c77..f5e623f 100644
> > --- a/arch/arm64/Kconfig.platforms
> > +++ b/arch/arm64/Kconfig.platforms
> > @@ -173,6 +173,7 @@ config ARCH_MXC
> >  	select PM
> >  	select PM_GENERIC_DOMAINS
> >  	select SOC_BUS
> > +	select TIMER_IMX_SYS_CTR
> 
> Where is that driver?

Okay, just found it in the mailbox.  They seem to be sent in the wrong
order.  Really, you should send this series only after the driver lands
on mainline.

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms
  2019-06-24  2:27   ` Shawn Guo
@ 2019-06-24  2:35     ` Anson Huang
  2019-07-22  2:00       ` Shawn Guo
  0 siblings, 1 reply; 15+ messages in thread
From: Anson Huang @ 2019-06-24  2:35 UTC (permalink / raw)
  To: Shawn Guo
  Cc: mark.rutland, Aisheng Dong, Peng Fan, Jacky Bai, will,
	devicetree, sboyd, catalin.marinas, s.hauer, linux-kernel,
	Daniel Baluta, mturquette, robh+dt, dl-linux-imx, kernel,
	Leonard Crestez, festevam, linux-clk, linux-arm-kernel,
	Abel Vesa

Hi, Shawn

> -----Original Message-----
> From: Shawn Guo <shawnguo@kernel.org>
> Sent: Monday, June 24, 2019 10:27 AM
> To: Anson Huang <anson.huang@nxp.com>
> Cc: mark.rutland@arm.com; Aisheng Dong <aisheng.dong@nxp.com>; Peng
> Fan <peng.fan@nxp.com>; festevam@gmail.com; Jacky Bai
> <ping.bai@nxp.com>; devicetree@vger.kernel.org; sboyd@kernel.org;
> catalin.marinas@arm.com; s.hauer@pengutronix.de; linux-
> kernel@vger.kernel.org; Daniel Baluta <daniel.baluta@nxp.com>; linux-
> clk@vger.kernel.org; robh+dt@kernel.org; dl-linux-imx <linux-
> imx@nxp.com>; kernel@pengutronix.de; Leonard Crestez
> <leonard.crestez@nxp.com>; will@kernel.org; mturquette@baylibre.com;
> linux-arm-kernel@lists.infradead.org; Abel Vesa <abel.vesa@nxp.com>
> Subject: Re: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC
> platforms
> 
> On Mon, Jun 24, 2019 at 10:22:01AM +0800, Shawn Guo wrote:
> > On Fri, Jun 21, 2019 at 03:07:17PM +0800, Anson.Huang@nxp.com wrote:
> > > From: Anson Huang <Anson.Huang@nxp.com>
> > >
> > > ARCH_MXC platforms needs system counter as broadcast timer to
> > > support cpuidle, enable it by default.
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > > ---
> > >  arch/arm64/Kconfig.platforms | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm64/Kconfig.platforms
> > > b/arch/arm64/Kconfig.platforms index 4778c77..f5e623f 100644
> > > --- a/arch/arm64/Kconfig.platforms
> > > +++ b/arch/arm64/Kconfig.platforms
> > > @@ -173,6 +173,7 @@ config ARCH_MXC
> > >  	select PM
> > >  	select PM_GENERIC_DOMAINS
> > >  	select SOC_BUS
> > > +	select TIMER_IMX_SYS_CTR
> >
> > Where is that driver?
> 
> Okay, just found it in the mailbox.  They seem to be sent in the wrong order.
> Really, you should send this series only after the driver lands on mainline.

OK, just noticed that mainline does NOT have it, since I did it based on next tree.
I will resend the patch series after the system counter driver landing on mainline.

Thanks,
Anson.

> 
> Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 2/4] dt-bindings: clock: imx8mm: Add system counter clock
  2019-06-21  7:07 ` [PATCH 2/4] dt-bindings: clock: imx8mm: Add system counter clock Anson.Huang
@ 2019-07-09 20:18   ` Rob Herring
  0 siblings, 0 replies; 15+ messages in thread
From: Rob Herring @ 2019-07-09 20:18 UTC (permalink / raw)
  To: Anson.Huang
  Cc: mark.rutland, aisheng.dong, peng.fan, festevam, ping.bai,
	devicetree, sboyd, catalin.marinas, s.hauer, linux-kernel,
	daniel.baluta, linux-clk, robh+dt, Linux-imx, kernel, shawnguo,
	leonard.crestez, will, mturquette, linux-arm-kernel, abel.vesa

On Fri, 21 Jun 2019 15:07:18 +0800, Anson.Huang@nxp.com wrote:
> From: Anson Huang <Anson.Huang@nxp.com>
> 
> Add i.MX8MM system counter clock macro definition.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
>  include/dt-bindings/clock/imx8mm-clock.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 3/4] clk: imx8mm: Add system counter to clock tree
  2019-06-21  7:07 ` [PATCH 3/4] clk: imx8mm: Add system counter to clock tree Anson.Huang
@ 2019-07-11  8:19   ` Abel Vesa
  0 siblings, 0 replies; 15+ messages in thread
From: Abel Vesa @ 2019-07-11  8:19 UTC (permalink / raw)
  To: Anson Huang
  Cc: mark.rutland, Aisheng Dong, Peng Fan, festevam, Jacky Bai,
	devicetree, sboyd, catalin.marinas, s.hauer, linux-kernel,
	Daniel Baluta, linux-clk, robh+dt, dl-linux-imx, kernel,
	shawnguo, Leonard Crestez, will, mturquette, linux-arm-kernel

On 19-06-21 15:07:19, Anson.Huang@nxp.com wrote:
> From: Anson Huang <Anson.Huang@nxp.com>
> 
> i.MX8MM timer-imx-sysctr driver needs system counter clock
> for proper function, add it into clock tree.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

Reviewed-by: Abel Vesa <abel.vesa@nxp.com>

> ---
>  drivers/clk/imx/clk-imx8mm.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
> index 43fa9c3..56d53dd 100644
> --- a/drivers/clk/imx/clk-imx8mm.c
> +++ b/drivers/clk/imx/clk-imx8mm.c
> @@ -645,6 +645,8 @@ static int __init imx8mm_clocks_init(struct device_node *ccm_node)
>  	clks[IMX8MM_CLK_DRAM_ALT_ROOT] = imx_clk_fixed_factor("dram_alt_root", "dram_alt", 1, 4);
>  	clks[IMX8MM_CLK_DRAM_CORE] = imx_clk_mux2_flags("dram_core_clk", base + 0x9800, 24, 1, imx8mm_dram_core_sels, ARRAY_SIZE(imx8mm_dram_core_sels), CLK_IS_CRITICAL);
>  
> +	clks[IMX8MM_CLK_SYS_CTR] = imx_clk_fixed_factor("sys_ctr", "osc_24m", 1, 3);
> +
>  	clks[IMX8MM_CLK_ARM] = imx_clk_cpu("arm", "arm_a53_div",
>  					   clks[IMX8MM_CLK_A53_DIV],
>  					   clks[IMX8MM_CLK_A53_SRC],
> -- 
> 2.7.4
> 
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms
  2019-06-24  2:35     ` Anson Huang
@ 2019-07-22  2:00       ` Shawn Guo
  2019-07-22  2:15         ` Anson Huang
  0 siblings, 1 reply; 15+ messages in thread
From: Shawn Guo @ 2019-07-22  2:00 UTC (permalink / raw)
  To: Anson Huang
  Cc: mark.rutland, Aisheng Dong, Peng Fan, Jacky Bai, will,
	devicetree, sboyd, catalin.marinas, s.hauer, linux-kernel,
	Daniel Baluta, mturquette, robh+dt, dl-linux-imx, kernel,
	Leonard Crestez, festevam, linux-clk, linux-arm-kernel,
	Abel Vesa

On Mon, Jun 24, 2019 at 02:35:10AM +0000, Anson Huang wrote:
> Hi, Shawn
> 
> > -----Original Message-----
> > From: Shawn Guo <shawnguo@kernel.org>
> > Sent: Monday, June 24, 2019 10:27 AM
> > To: Anson Huang <anson.huang@nxp.com>
> > Cc: mark.rutland@arm.com; Aisheng Dong <aisheng.dong@nxp.com>; Peng
> > Fan <peng.fan@nxp.com>; festevam@gmail.com; Jacky Bai
> > <ping.bai@nxp.com>; devicetree@vger.kernel.org; sboyd@kernel.org;
> > catalin.marinas@arm.com; s.hauer@pengutronix.de; linux-
> > kernel@vger.kernel.org; Daniel Baluta <daniel.baluta@nxp.com>; linux-
> > clk@vger.kernel.org; robh+dt@kernel.org; dl-linux-imx <linux-
> > imx@nxp.com>; kernel@pengutronix.de; Leonard Crestez
> > <leonard.crestez@nxp.com>; will@kernel.org; mturquette@baylibre.com;
> > linux-arm-kernel@lists.infradead.org; Abel Vesa <abel.vesa@nxp.com>
> > Subject: Re: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC
> > platforms
> > 
> > On Mon, Jun 24, 2019 at 10:22:01AM +0800, Shawn Guo wrote:
> > > On Fri, Jun 21, 2019 at 03:07:17PM +0800, Anson.Huang@nxp.com wrote:
> > > > From: Anson Huang <Anson.Huang@nxp.com>
> > > >
> > > > ARCH_MXC platforms needs system counter as broadcast timer to
> > > > support cpuidle, enable it by default.
> > > >
> > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > > > ---
> > > >  arch/arm64/Kconfig.platforms | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/arch/arm64/Kconfig.platforms
> > > > b/arch/arm64/Kconfig.platforms index 4778c77..f5e623f 100644
> > > > --- a/arch/arm64/Kconfig.platforms
> > > > +++ b/arch/arm64/Kconfig.platforms
> > > > @@ -173,6 +173,7 @@ config ARCH_MXC
> > > >  	select PM
> > > >  	select PM_GENERIC_DOMAINS
> > > >  	select SOC_BUS
> > > > +	select TIMER_IMX_SYS_CTR
> > >
> > > Where is that driver?
> > 
> > Okay, just found it in the mailbox.  They seem to be sent in the wrong order.
> > Really, you should send this series only after the driver lands on mainline.
> 
> OK, just noticed that mainline does NOT have it, since I did it based on next tree.
> I will resend the patch series after the system counter driver landing on mainline.

I just picked the series up, so no need to resend.

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms
  2019-07-22  2:00       ` Shawn Guo
@ 2019-07-22  2:15         ` Anson Huang
  2019-07-22  3:19           ` Shawn Guo
  0 siblings, 1 reply; 15+ messages in thread
From: Anson Huang @ 2019-07-22  2:15 UTC (permalink / raw)
  To: Shawn Guo
  Cc: mark.rutland, Aisheng Dong, Peng Fan, Jacky Bai, will,
	devicetree, sboyd, catalin.marinas, s.hauer, linux-kernel,
	Daniel Baluta, mturquette, robh+dt, dl-linux-imx, kernel,
	Leonard Crestez, festevam, linux-clk, linux-arm-kernel,
	Abel Vesa

Hi, Shawn

> On Mon, Jun 24, 2019 at 02:35:10AM +0000, Anson Huang wrote:
> > Hi, Shawn
> >
> > > -----Original Message-----
> > > From: Shawn Guo <shawnguo@kernel.org>
> > > Sent: Monday, June 24, 2019 10:27 AM
> > > To: Anson Huang <anson.huang@nxp.com>
> > > Cc: mark.rutland@arm.com; Aisheng Dong <aisheng.dong@nxp.com>;
> Peng
> > > Fan <peng.fan@nxp.com>; festevam@gmail.com; Jacky Bai
> > > <ping.bai@nxp.com>; devicetree@vger.kernel.org; sboyd@kernel.org;
> > > catalin.marinas@arm.com; s.hauer@pengutronix.de; linux-
> > > kernel@vger.kernel.org; Daniel Baluta <daniel.baluta@nxp.com>;
> > > linux- clk@vger.kernel.org; robh+dt@kernel.org; dl-linux-imx <linux-
> > > imx@nxp.com>; kernel@pengutronix.de; Leonard Crestez
> > > <leonard.crestez@nxp.com>; will@kernel.org; mturquette@baylibre.com;
> > > linux-arm-kernel@lists.infradead.org; Abel Vesa <abel.vesa@nxp.com>
> > > Subject: Re: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for
> > > ARCH_MXC platforms
> > >
> > > On Mon, Jun 24, 2019 at 10:22:01AM +0800, Shawn Guo wrote:
> > > > On Fri, Jun 21, 2019 at 03:07:17PM +0800, Anson.Huang@nxp.com
> wrote:
> > > > > From: Anson Huang <Anson.Huang@nxp.com>
> > > > >
> > > > > ARCH_MXC platforms needs system counter as broadcast timer to
> > > > > support cpuidle, enable it by default.
> > > > >
> > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > > > > ---
> > > > >  arch/arm64/Kconfig.platforms | 1 +
> > > > >  1 file changed, 1 insertion(+)
> > > > >
> > > > > diff --git a/arch/arm64/Kconfig.platforms
> > > > > b/arch/arm64/Kconfig.platforms index 4778c77..f5e623f 100644
> > > > > --- a/arch/arm64/Kconfig.platforms
> > > > > +++ b/arch/arm64/Kconfig.platforms
> > > > > @@ -173,6 +173,7 @@ config ARCH_MXC
> > > > >  	select PM
> > > > >  	select PM_GENERIC_DOMAINS
> > > > >  	select SOC_BUS
> > > > > +	select TIMER_IMX_SYS_CTR
> > > >
> > > > Where is that driver?
> > >
> > > Okay, just found it in the mailbox.  They seem to be sent in the wrong
> order.
> > > Really, you should send this series only after the driver lands on mainline.
> >
> > OK, just noticed that mainline does NOT have it, since I did it based on next
> tree.
> > I will resend the patch series after the system counter driver landing on
> mainline.
> 
> I just picked the series up, so no need to resend.

Something changed for this series, the system counter clock related implementation
are changed after some comments from maintainer, so I think you should picked up
below patch series instead, and drop this series,

https://patchwork.kernel.org/patch/11037953/

thanks,
Anson
 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms
  2019-07-22  2:15         ` Anson Huang
@ 2019-07-22  3:19           ` Shawn Guo
  0 siblings, 0 replies; 15+ messages in thread
From: Shawn Guo @ 2019-07-22  3:19 UTC (permalink / raw)
  To: Anson Huang
  Cc: mark.rutland, Aisheng Dong, Peng Fan, Jacky Bai, will,
	devicetree, sboyd, catalin.marinas, s.hauer, linux-kernel,
	Daniel Baluta, mturquette, robh+dt, dl-linux-imx, kernel,
	Leonard Crestez, festevam, linux-clk, linux-arm-kernel,
	Abel Vesa

On Mon, Jul 22, 2019 at 02:15:10AM +0000, Anson Huang wrote:
> Hi, Shawn
> 
> > On Mon, Jun 24, 2019 at 02:35:10AM +0000, Anson Huang wrote:
> > > Hi, Shawn
> > >
> > > > -----Original Message-----
> > > > From: Shawn Guo <shawnguo@kernel.org>
> > > > Sent: Monday, June 24, 2019 10:27 AM
> > > > To: Anson Huang <anson.huang@nxp.com>
> > > > Cc: mark.rutland@arm.com; Aisheng Dong <aisheng.dong@nxp.com>;
> > Peng
> > > > Fan <peng.fan@nxp.com>; festevam@gmail.com; Jacky Bai
> > > > <ping.bai@nxp.com>; devicetree@vger.kernel.org; sboyd@kernel.org;
> > > > catalin.marinas@arm.com; s.hauer@pengutronix.de; linux-
> > > > kernel@vger.kernel.org; Daniel Baluta <daniel.baluta@nxp.com>;
> > > > linux- clk@vger.kernel.org; robh+dt@kernel.org; dl-linux-imx <linux-
> > > > imx@nxp.com>; kernel@pengutronix.de; Leonard Crestez
> > > > <leonard.crestez@nxp.com>; will@kernel.org; mturquette@baylibre.com;
> > > > linux-arm-kernel@lists.infradead.org; Abel Vesa <abel.vesa@nxp.com>
> > > > Subject: Re: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for
> > > > ARCH_MXC platforms
> > > >
> > > > On Mon, Jun 24, 2019 at 10:22:01AM +0800, Shawn Guo wrote:
> > > > > On Fri, Jun 21, 2019 at 03:07:17PM +0800, Anson.Huang@nxp.com
> > wrote:
> > > > > > From: Anson Huang <Anson.Huang@nxp.com>
> > > > > >
> > > > > > ARCH_MXC platforms needs system counter as broadcast timer to
> > > > > > support cpuidle, enable it by default.
> > > > > >
> > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > > > > > ---
> > > > > >  arch/arm64/Kconfig.platforms | 1 +
> > > > > >  1 file changed, 1 insertion(+)
> > > > > >
> > > > > > diff --git a/arch/arm64/Kconfig.platforms
> > > > > > b/arch/arm64/Kconfig.platforms index 4778c77..f5e623f 100644
> > > > > > --- a/arch/arm64/Kconfig.platforms
> > > > > > +++ b/arch/arm64/Kconfig.platforms
> > > > > > @@ -173,6 +173,7 @@ config ARCH_MXC
> > > > > >  	select PM
> > > > > >  	select PM_GENERIC_DOMAINS
> > > > > >  	select SOC_BUS
> > > > > > +	select TIMER_IMX_SYS_CTR
> > > > >
> > > > > Where is that driver?
> > > >
> > > > Okay, just found it in the mailbox.  They seem to be sent in the wrong
> > order.
> > > > Really, you should send this series only after the driver lands on mainline.
> > >
> > > OK, just noticed that mainline does NOT have it, since I did it based on next
> > tree.
> > > I will resend the patch series after the system counter driver landing on
> > mainline.
> > 
> > I just picked the series up, so no need to resend.
> 
> Something changed for this series, the system counter clock related implementation
> are changed after some comments from maintainer, so I think you should picked up
> below patch series instead, and drop this series,
> 
> https://patchwork.kernel.org/patch/11037953/

Okay, dropped clk and dts patches.  arch/arm64/Kconfig.platforms one is kept.

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2019-07-22  3:19 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-21  7:07 [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms Anson.Huang
2019-06-21  7:07 ` [PATCH 2/4] dt-bindings: clock: imx8mm: Add system counter clock Anson.Huang
2019-07-09 20:18   ` Rob Herring
2019-06-21  7:07 ` [PATCH 3/4] clk: imx8mm: Add system counter to clock tree Anson.Huang
2019-07-11  8:19   ` Abel Vesa
2019-06-21  7:07 ` [PATCH 4/4] arm64: dts: imx8mm: Add system counter node Anson.Huang
2019-06-22 12:10   ` Martin Kepplinger
2019-06-23 11:20     ` Anson Huang
2019-06-24  2:22 ` [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms Shawn Guo
2019-06-24  2:26   ` Anson Huang
2019-06-24  2:27   ` Shawn Guo
2019-06-24  2:35     ` Anson Huang
2019-07-22  2:00       ` Shawn Guo
2019-07-22  2:15         ` Anson Huang
2019-07-22  3:19           ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).