linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: imx8mq: Add sai6 node
@ 2019-07-02 11:41 Andra Danciu
  2019-07-02 11:45 ` Abel Vesa
  0 siblings, 1 reply; 3+ messages in thread
From: Andra Danciu @ 2019-07-02 11:41 UTC (permalink / raw)
  To: shawnguo
  Cc: mark.rutland, devicetree, abel.vesa, Anson.Huang, ccaione,
	andrew.smirnov, s.hauer, angus, linux-kernel, robh+dt, linux-imx,
	kernel, festevam, agx, linux-arm-kernel, l.stach

Cc: Daniel Baluta <daniel.baluta@nxp.com>
Signed-off-by: Andra Danciu <andradanciu1997@gmail.com>
---
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index d09b808eff87..1ff664523f56 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -278,6 +278,20 @@
 			#size-cells = <1>;
 			ranges = <0x30000000 0x30000000 0x400000>;
 
+			sai6: sai@30030000 {
+				compatible = "fsl,imx8mq-sai",
+					"fsl,imx6sx-sai";
+				reg = <0x30030000 0x10000>;
+				interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&clk IMX8MQ_CLK_SAI6_IPG>,
+					<&clk IMX8MQ_CLK_SAI6_ROOT>,
+					<&clk IMX8MQ_CLK_DUMMY>, <&clk IMX8MQ_CLK_DUMMY>;
+				clock-names = "bus", "mclk1", "mclk2", "mclk3";
+				dmas = <&sdma2 4 24 0>, <&sdma2 5 24 0>;
+				dma-names = "rx", "tx";
+				status = "disabled";
+			};
+
 			gpio1: gpio@30200000 {
 				compatible = "fsl,imx8mq-gpio", "fsl,imx35-gpio";
 				reg = <0x30200000 0x10000>;
-- 
2.11.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: imx8mq: Add sai6 node
  2019-07-02 11:41 [PATCH] arm64: dts: imx8mq: Add sai6 node Andra Danciu
@ 2019-07-02 11:45 ` Abel Vesa
  2019-07-02 12:40   ` Daniel Baluta
  0 siblings, 1 reply; 3+ messages in thread
From: Abel Vesa @ 2019-07-02 11:45 UTC (permalink / raw)
  To: Andra Danciu
  Cc: mark.rutland, devicetree, Anson Huang, ccaione, andrew.smirnov,
	shawnguo, s.hauer, angus, linux-kernel, robh+dt, dl-linux-imx,
	kernel, festevam, agx, linux-arm-kernel, l.stach

On 19-07-02 14:41:02, Andra Danciu wrote:

Missing commit message here. Please add one.

> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> Signed-off-by: Andra Danciu <andradanciu1997@gmail.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index d09b808eff87..1ff664523f56 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -278,6 +278,20 @@
>  			#size-cells = <1>;
>  			ranges = <0x30000000 0x30000000 0x400000>;
>  
> +			sai6: sai@30030000 {
> +				compatible = "fsl,imx8mq-sai",
> +					"fsl,imx6sx-sai";
> +				reg = <0x30030000 0x10000>;
> +				interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clk IMX8MQ_CLK_SAI6_IPG>,
> +					<&clk IMX8MQ_CLK_SAI6_ROOT>,
> +					<&clk IMX8MQ_CLK_DUMMY>, <&clk IMX8MQ_CLK_DUMMY>;
> +				clock-names = "bus", "mclk1", "mclk2", "mclk3";
> +				dmas = <&sdma2 4 24 0>, <&sdma2 5 24 0>;
> +				dma-names = "rx", "tx";
> +				status = "disabled";
> +			};
> +
>  			gpio1: gpio@30200000 {
>  				compatible = "fsl,imx8mq-gpio", "fsl,imx35-gpio";
>  				reg = <0x30200000 0x10000>;
> -- 
> 2.11.0
> 
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: imx8mq: Add sai6 node
  2019-07-02 11:45 ` Abel Vesa
@ 2019-07-02 12:40   ` Daniel Baluta
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel Baluta @ 2019-07-02 12:40 UTC (permalink / raw)
  To: Abel Vesa
  Cc: mark.rutland, devicetree, Andra Danciu, Anson Huang, ccaione,
	andrew.smirnov, festevam, s.hauer, angus, linux-kernel, robh+dt,
	dl-linux-imx, kernel, shawnguo, agx, linux-arm-kernel, l.stach

On Tue, Jul 2, 2019 at 2:46 PM Abel Vesa <abel.vesa@nxp.com> wrote:
>
> On 19-07-02 14:41:02, Andra Danciu wrote:
>
> Missing commit message here. Please add one.

Agree. Also, please add SAI3. As you noticed our pico pi board has
pins exposed on for SAI2/SAI3.

As for the description you can say:

SAI3/6 supports up to 2-channels TX (1 dataline) and 2-channels RX (1 dataline).

>
> > Cc: Daniel Baluta <daniel.baluta@nxp.com>
> > Signed-off-by: Andra Danciu <andradanciu1997@gmail.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > index d09b808eff87..1ff664523f56 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > @@ -278,6 +278,20 @@
> >                       #size-cells = <1>;
> >                       ranges = <0x30000000 0x30000000 0x400000>;
> >
> > +                     sai6: sai@30030000 {
> > +                             compatible = "fsl,imx8mq-sai",
> > +                                     "fsl,imx6sx-sai";
> > +                             reg = <0x30030000 0x10000>;
> > +                             interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> > +                             clocks = <&clk IMX8MQ_CLK_SAI6_IPG>,
> > +                                     <&clk IMX8MQ_CLK_SAI6_ROOT>,
> > +                                     <&clk IMX8MQ_CLK_DUMMY>, <&clk IMX8MQ_CLK_DUMMY>;
> > +                             clock-names = "bus", "mclk1", "mclk2", "mclk3";
> > +                             dmas = <&sdma2 4 24 0>, <&sdma2 5 24 0>;
> > +                             dma-names = "rx", "tx";
> > +                             status = "disabled";
> > +                     };
> > +
> >                       gpio1: gpio@30200000 {
> >                               compatible = "fsl,imx8mq-gpio", "fsl,imx35-gpio";
> >                               reg = <0x30200000 0x10000>;
> > --
> > 2.11.0
> >

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-07-02 12:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-02 11:41 [PATCH] arm64: dts: imx8mq: Add sai6 node Andra Danciu
2019-07-02 11:45 ` Abel Vesa
2019-07-02 12:40   ` Daniel Baluta

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).