[PATCH] coresight: fix typos

[PATCH] coresight: fix typos

[Pavel Machek]

[-- Attachment #1.1: Type: text/plain, Size: 1144 bytes --]


Fix typos in comments.

Signed-off-by: Pavel Machek <pavel@denx.de>

diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c
index 55db77f641..1d66191 100644
--- a/drivers/hwtracing/coresight/coresight.c
+++ b/drivers/hwtracing/coresight/coresight.c
@@ -1001,7 +1001,7 @@ static int coresight_orphan_match(struct device *dev, void *data)
 	if (!i_csdev->orphan)
 		return 0;
 	/*
-	 * Circle throuch all the connection of that component.  If we find
+	 * Circle through all the connections of that component.  If we find
 	 * an orphan connection whose name matches @csdev, link it.
 	 */
 	for (i = 0; i < i_csdev->pdata->nr_outport; i++) {
@@ -1021,7 +1021,7 @@ static int coresight_orphan_match(struct device *dev, void *data)
 	i_csdev->orphan = still_orphan;
 
 	/*
-	 * Returning '0' ensures that all known component on the
+	 * Returning '0' ensures that all known components on the
 	 * bus will be checked.
 	 */
 	return 0;


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] coresight: fix typos

[Suzuki K Poulose]

On 24/07/2019 11:03, Pavel Machek wrote:
> 
> Fix typos in comments.
> 
> Signed-off-by: Pavel Machek <pavel@denx.de>
> 
> diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c
> index 55db77f641..1d66191 100644
> --- a/drivers/hwtracing/coresight/coresight.c
> +++ b/drivers/hwtracing/coresight/coresight.c
> @@ -1001,7 +1001,7 @@ static int coresight_orphan_match(struct device *dev, void *data)
>   	if (!i_csdev->orphan)
>   		return 0;
>   	/*
> -	 * Circle throuch all the connection of that component.  If we find
> +	 * Circle through all the connections of that component.  If we find
>   	 * an orphan connection whose name matches @csdev, link it.

We have stopped using name to match the csdev and switched to fwnode handles. 
Please could you update the comment to reflect this, while you are at it ?
Otherwise looks fine to me.

Suzuki

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] coresight: fix typos

[Pavel Machek]

[-- Attachment #1.1: Type: text/plain, Size: 1327 bytes --]

On Wed 2019-07-24 11:36:23, Suzuki K Poulose wrote:
> 
> 
> On 24/07/2019 11:03, Pavel Machek wrote:
> >
> >Fix typos in comments.
> >
> >Signed-off-by: Pavel Machek <pavel@denx.de>
> >
> >diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c
> >index 55db77f641..1d66191 100644
> >--- a/drivers/hwtracing/coresight/coresight.c
> >+++ b/drivers/hwtracing/coresight/coresight.c
> >@@ -1001,7 +1001,7 @@ static int coresight_orphan_match(struct device *dev, void *data)
> >  	if (!i_csdev->orphan)
> >  		return 0;
> >  	/*
> >-	 * Circle throuch all the connection of that component.  If we find
> >+	 * Circle through all the connections of that component.  If we find
> >  	 * an orphan connection whose name matches @csdev, link it.
> 
> We have stopped using name to match the csdev and switched to fwnode
> handles. Please could you update the comment to reflect this, while you are
> at it ?
> Otherwise looks fine to me.

I guess best way would be to apply this and then fix up the facts in a
comment... or feel free to just fix it up. I am not best person to fix
facts there...

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel