From: Krzysztof Kozlowski <krzk@kernel.org>
To: Guillaume GARDET <guillaume.gardet@free.fr>
Cc: linux-samsung-soc@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Guillaume GARDET <guillaume.gardet@arm.com>
Subject: Re: [PATCH] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250
Date: Wed, 24 Jul 2019 21:43:13 +0200 [thread overview]
Message-ID: <20190724194313.GA1898@kozik-lap> (raw)
In-Reply-To: <20190724072008.6272-1-guillaume.gardet@free.fr>
Hi,
Thanks for the patch.
On Wed, Jul 24, 2019 at 09:20:08AM +0200, Guillaume GARDET wrote:
> From: Guillaume GARDET <guillaume.gardet@arm.com>
>
> Add nodes for GPU (Mali T604) to Exynos5250, disabled by default.
Why disabled? If tested I would expect it to be enabled at least on
tested platforms.
> Tested with kmscube on Chromebook snow.
>
> Signed-off-by: Guillaume GARDET <guillaume.gardet@arm.com>
>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
>
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 47 +++++++++++++++++++++++++++++++
> 1 file changed, 47 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index d5e0392b409e..5ce4b2853cf2 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -1097,6 +1097,53 @@
> */
> clock-frequency = <24000000>;
> };
> +
> + mali: gpu@0x11800000 {
1. Put the node under /soc (as recently pointed out by Marek Szyprowski)
in an address-sorted mode... if possible (nodes are mixed so find some
reasonable place based on address_.
2. Fix errors from:
make dtbs W=1
> + compatible = "samsung,exynos5250-mali", "arm,mali-t604";
You also need to update the bindings.
> + reg = <0x11800000 0x5000>;
> + interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
Please run checkpatch and fix the errors.
> + <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "job", "mmu", "gpu";
> + clocks = <&clock CLK_G3D>;
> + clock-names = "g3d";
> + operating-points-v2 = <&gpu_opp_table>;
> + power-domains = <&pd_g3d>;
> + status = "disabled";
> + };
> +
> + gpu_opp_table: gpu-opp-table {
GPU opp table as subnode of Mali node.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-24 19:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 7:20 [PATCH] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250 Guillaume GARDET
2019-07-24 19:43 ` Krzysztof Kozlowski [this message]
2019-07-25 8:34 ` [PATCH V2 1/2] " Guillaume
2019-07-25 8:34 ` [PATCH V2 2/2] dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible Guillaume
2019-07-25 11:19 ` [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250 Krzysztof Kozlowski
2019-07-25 11:35 ` Guillaume Gardet
2019-07-25 12:26 ` Krzysztof Kozlowski
2019-07-25 12:37 ` Guillaume Gardet
2019-07-26 10:40 ` Krzysztof Kozlowski
2019-07-31 14:37 ` Guillaume Gardet
2019-08-01 9:35 ` Marek Szyprowski
2019-08-30 10:44 ` [PATCH V3 0/4] Add GPU/Mali T604 node to arndale and snow (exynos5250) Guillaume Gardet
2019-08-30 10:44 ` [PATCH V3 1/5] dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible Guillaume Gardet
2019-09-02 15:31 ` Krzysztof Kozlowski
2019-09-03 6:56 ` Krzysztof Kozlowski
2019-09-03 7:02 ` Guillaume Gardet
2019-09-03 7:04 ` Krzysztof Kozlowski
2019-09-03 7:33 ` [PATCH] " Guillaume Gardet
2019-09-03 7:36 ` Krzysztof Kozlowski
2019-09-03 9:32 ` Rob Herring
2019-08-30 10:44 ` [PATCH V3 2/5] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250 Guillaume Gardet
2019-08-30 10:45 ` [PATCH V3 3/5] arm: dts: exynos: snow: Enable GPU/Mali T604 node Guillaume Gardet
2019-08-30 10:45 ` [PATCH V3 4/5] arm: dts: exynos: arndale: " Guillaume Gardet
2019-08-30 10:45 ` [PATCH V3 5/5] arm: dts: exynos: arndale: Fix min/max for buck4 regulator for gpu Guillaume Gardet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724194313.GA1898@kozik-lap \
--to=krzk@kernel.org \
--cc=guillaume.gardet@arm.com \
--cc=guillaume.gardet@free.fr \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).