From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Guillaume Gardet <Guillaume.Gardet@arm.com>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: "linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
Kukjin Kim <kgene@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250
Date: Thu, 1 Aug 2019 11:35:24 +0200 [thread overview]
Message-ID: <79a50bdd-17ba-4e2f-5389-4b39ed440685@samsung.com> (raw)
In-Reply-To: <DBBPR08MB4678D2A9A042269A8934E84183DF0@DBBPR08MB4678.eurprd08.prod.outlook.com>
Hi Guillaume,
On 2019-07-31 16:37, Guillaume Gardet wrote:
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: 26 July 2019 12:40
>> To: Guillaume Gardet <Guillaume.Gardet@arm.com>
>> Cc: linux-samsung-soc@vger.kernel.org; Kukjin Kim <kgene@kernel.org>;
>> linux-arm-kernel@lists.infradead.org
>> Subject: Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to
>> exynos5250
>>
>> On Thu, 25 Jul 2019 at 14:37, Guillaume Gardet <Guillaume.Gardet@arm.com>
>> wrote:
>>>> No, regulator is not provided. On all Exynos boards Mali uses its
>>>> own dedicated regulator (and sometimes additional one). It worked in
>>>> your case because the regulator was set as always-on but this is a
>> workaround for lack of consumers.
>>>> Once there is a consumer, the regulator should not be always-on to
>>>> save the energy when not used.
>>> I do not have the required info here. Do you have it, or could I skip the
>> mali-supply for now?
>>
>> You can guess from regulator name :)
>> For the Arndale, the schematics are saying it is buck4.
> Thanks. This is buck4 as well for snow.
>
> On Arndale board, buck4 has a fixed voltage of 1V contrary to snow, which leads to the following error:
> [ 21.131930] panfrost 11800000.gpu: Cannot set voltage 925000 uV
>
> The following change fixes the previous error:
> - regulator-min-microvolt = <1000000>;
> - regulator-max-microvolt = <1000000>;
> + regulator-min-microvolt = <850000>;
> + regulator-max-microvolt = <1300000>;
>
> Should I remove arndale enablement for now until this is fixed separately, or could I add this fixup in this patch serie, as it is related?
It is okay to add this fixup to the patch, which sets mali regulator on
arndale board.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-01 9:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 7:20 [PATCH] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250 Guillaume GARDET
2019-07-24 19:43 ` Krzysztof Kozlowski
2019-07-25 8:34 ` [PATCH V2 1/2] " Guillaume
2019-07-25 8:34 ` [PATCH V2 2/2] dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible Guillaume
2019-07-25 11:19 ` [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250 Krzysztof Kozlowski
2019-07-25 11:35 ` Guillaume Gardet
2019-07-25 12:26 ` Krzysztof Kozlowski
2019-07-25 12:37 ` Guillaume Gardet
2019-07-26 10:40 ` Krzysztof Kozlowski
2019-07-31 14:37 ` Guillaume Gardet
2019-08-01 9:35 ` Marek Szyprowski [this message]
2019-08-30 10:44 ` [PATCH V3 0/4] Add GPU/Mali T604 node to arndale and snow (exynos5250) Guillaume Gardet
2019-08-30 10:44 ` [PATCH V3 1/5] dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible Guillaume Gardet
2019-09-02 15:31 ` Krzysztof Kozlowski
2019-09-03 6:56 ` Krzysztof Kozlowski
2019-09-03 7:02 ` Guillaume Gardet
2019-09-03 7:04 ` Krzysztof Kozlowski
2019-09-03 7:33 ` [PATCH] " Guillaume Gardet
2019-09-03 7:36 ` Krzysztof Kozlowski
2019-09-03 9:32 ` Rob Herring
2019-08-30 10:44 ` [PATCH V3 2/5] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250 Guillaume Gardet
2019-08-30 10:45 ` [PATCH V3 3/5] arm: dts: exynos: snow: Enable GPU/Mali T604 node Guillaume Gardet
2019-08-30 10:45 ` [PATCH V3 4/5] arm: dts: exynos: arndale: " Guillaume Gardet
2019-08-30 10:45 ` [PATCH V3 5/5] arm: dts: exynos: arndale: Fix min/max for buck4 regulator for gpu Guillaume Gardet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79a50bdd-17ba-4e2f-5389-4b39ed440685@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=Guillaume.Gardet@arm.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).