* [PATCH 1/1] drm: mxsfb: add i.MX6UL in Kconfig
@ 2019-07-29 14:13 Sébastien Szymanski
2019-07-29 14:27 ` Fabio Estevam
0 siblings, 1 reply; 5+ messages in thread
From: Sébastien Szymanski @ 2019-07-29 14:13 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Shawn Guo, Sascha Hauer
Cc: Marek Vasut, dri-devel, Julien BOIBESSOT, Stefan Agner,
Pengutronix Kernel Team, Fabio Estevam, linux-arm-kernel,
NXP Linux Team
This controller is also found on i.MX6UL and i.MX6ULL so update Kconfig
accordingly.
Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
---
drivers/gpu/drm/mxsfb/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mxsfb/Kconfig b/drivers/gpu/drm/mxsfb/Kconfig
index 0dca8f27169e..4571d4990e6f 100644
--- a/drivers/gpu/drm/mxsfb/Kconfig
+++ b/drivers/gpu/drm/mxsfb/Kconfig
@@ -5,7 +5,7 @@ config DRM_MXS
Choose this option to select drivers for MXS FB devices
config DRM_MXSFB
- tristate "i.MX23/i.MX28/i.MX6SX MXSFB LCD controller"
+ tristate "i.MX23/i.MX28/i.MX6SX/i.MX6UL MXSFB LCD controller"
depends on DRM && OF
depends on COMMON_CLK
select DRM_MXS
@@ -14,7 +14,7 @@ config DRM_MXSFB
select DRM_KMS_CMA_HELPER
select DRM_PANEL
help
- Choose this option if you have an i.MX23/i.MX28/i.MX6SX MXSFB
+ Choose this option if you have an i.MX23/i.MX28/i.MX6SX/i.MX6UL MXSFB
LCD controller.
If M is selected the module will be called mxsfb.
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] drm: mxsfb: add i.MX6UL in Kconfig
2019-07-29 14:13 [PATCH 1/1] drm: mxsfb: add i.MX6UL in Kconfig Sébastien Szymanski
@ 2019-07-29 14:27 ` Fabio Estevam
2019-07-29 14:37 ` Sam Ravnborg
0 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2019-07-29 14:27 UTC (permalink / raw)
To: Sébastien Szymanski
Cc: Marek Vasut, Pengutronix Kernel Team, DRI mailing list,
David Airlie, Sascha Hauer, Stefan Agner, Julien BOIBESSOT,
NXP Linux Team, Daniel Vetter, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Hi Sébastien,
On Mon, Jul 29, 2019 at 11:14 AM Sébastien Szymanski
<sebastien.szymanski@armadeus.com> wrote:
> config DRM_MXSFB
> - tristate "i.MX23/i.MX28/i.MX6SX MXSFB LCD controller"
> + tristate "i.MX23/i.MX28/i.MX6SX/i.MX6UL MXSFB LCD controller"
This IP is also found on i.MX6SL, i.MX7D, i.MX7S, i.MX8M, i.MX8QXP, etc
I think it would be better if we do not keep increasing the list of
supported SoCs in the Kconfig text.
What about just having the text like this instead?
tristate "MXSFB LCD controller"
> depends on DRM && OF
> depends on COMMON_CLK
> select DRM_MXS
> @@ -14,7 +14,7 @@ config DRM_MXSFB
> select DRM_KMS_CMA_HELPER
> select DRM_PANEL
> help
> - Choose this option if you have an i.MX23/i.MX28/i.MX6SX MXSFB
> + Choose this option if you have an i.MX23/i.MX28/i.MX6SX/i.MX6UL MXSFB
> LCD controller.
and here it would become:
Choose this option if you want to support the MXSFB LCD controller.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] drm: mxsfb: add i.MX6UL in Kconfig
2019-07-29 14:27 ` Fabio Estevam
@ 2019-07-29 14:37 ` Sam Ravnborg
2019-07-29 15:51 ` Fabio Estevam
0 siblings, 1 reply; 5+ messages in thread
From: Sam Ravnborg @ 2019-07-29 14:37 UTC (permalink / raw)
To: Fabio Estevam
Cc: Marek Vasut, David Airlie, DRI mailing list, Julien BOIBESSOT,
NXP Linux Team, Pengutronix Kernel Team, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Hi Sébastien,
On Mon, Jul 29, 2019 at 11:27:37AM -0300, Fabio Estevam wrote:
> Hi Sébastien,
>
> On Mon, Jul 29, 2019 at 11:14 AM Sébastien Szymanski
> <sebastien.szymanski@armadeus.com> wrote:
>
> > config DRM_MXSFB
> > - tristate "i.MX23/i.MX28/i.MX6SX MXSFB LCD controller"
> > + tristate "i.MX23/i.MX28/i.MX6SX/i.MX6UL MXSFB LCD controller"
>
> This IP is also found on i.MX6SL, i.MX7D, i.MX7S, i.MX8M, i.MX8QXP, etc
>
> I think it would be better if we do not keep increasing the list of
> supported SoCs in the Kconfig text.
Could we throw a COMPILE_TEST in the mix so we get better build
coverage too?
Sam
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] drm: mxsfb: add i.MX6UL in Kconfig
2019-07-29 14:37 ` Sam Ravnborg
@ 2019-07-29 15:51 ` Fabio Estevam
2019-07-29 17:50 ` Sam Ravnborg
0 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2019-07-29 15:51 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Marek Vasut, David Airlie, DRI mailing list, Julien BOIBESSOT,
NXP Linux Team, Pengutronix Kernel Team, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Hi Sam,
On Mon, Jul 29, 2019 at 11:37 AM Sam Ravnborg <sam@ravnborg.org> wrote:
> Could we throw a COMPILE_TEST in the mix so we get better build
> coverage too?
There is no architecture dependency to build this driver, so we
already have build coverage for it.
Regards,
Fabio Estevam
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] drm: mxsfb: add i.MX6UL in Kconfig
2019-07-29 15:51 ` Fabio Estevam
@ 2019-07-29 17:50 ` Sam Ravnborg
0 siblings, 0 replies; 5+ messages in thread
From: Sam Ravnborg @ 2019-07-29 17:50 UTC (permalink / raw)
To: Fabio Estevam
Cc: Marek Vasut, David Airlie, DRI mailing list, Julien BOIBESSOT,
NXP Linux Team, Pengutronix Kernel Team, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Hi Fabio.
On Mon, Jul 29, 2019 at 12:51:08PM -0300, Fabio Estevam wrote:
> Hi Sam,
>
> On Mon, Jul 29, 2019 at 11:37 AM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> > Could we throw a COMPILE_TEST in the mix so we get better build
> > coverage too?
>
> There is no architecture dependency to build this driver, so we
> already have build coverage for it.
Super, thanks for the info.
Sam
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-29 17:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-29 14:13 [PATCH 1/1] drm: mxsfb: add i.MX6UL in Kconfig Sébastien Szymanski
2019-07-29 14:27 ` Fabio Estevam
2019-07-29 14:37 ` Sam Ravnborg
2019-07-29 15:51 ` Fabio Estevam
2019-07-29 17:50 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).