Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Bhushan Shah <bshah@kde.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>,
	Gregory CLEMENT <gregory.clement@bootlin.com>,
	linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
	Rob Herring <robh+dt@kernel.org>,
	linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Icenowy Zheng <icenowy@aosc.io>
Subject: Re: [PATCH v2 3/3] arm64: allwinner: h6: add i2c0 node in PineH64
Date: Fri, 16 Aug 2019 09:52:11 +0200
Message-ID: <20190816075211.xaq54q2cdniwjpp3@flea> (raw)
In-Reply-To: <20190816064710.18280-4-bshah@kde.org>

[-- Attachment #1.1: Type: text/plain, Size: 1116 bytes --]

65;5603;1c
On Fri, Aug 16, 2019 at 12:17:10PM +0530, Bhushan Shah wrote:
> i2c0 bus is exposed by PI-2 BUS in the PineH64, model B.
>
> Signed-off-by: Bhushan Shah <bshah@kde.org>
> ---
> Changes in v2:
>   - Don't enable the i2c0 node in PineH64 by default
>
>  arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> index 684d1daa3081..97d9b7c63fb3 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> @@ -160,6 +160,15 @@
>  	vcc-pg-supply = <&reg_aldo1>;
>  };
>
> +/* This i2c interface is exposed on PI-2 BUS, Pin 3 (I2C_SDA) and 5 (I2C_SCL) */
> +&i2c0 {
> +	status = "disabled";
> +};

This property is set to disabled in the DTSI already

> +&i2c0_pins {
> +	bias-pull-up;
> +};
> +

And this should be in the same overlay than the one that sets status
to okay.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply index

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-11  9:05 [PATCH 0/2] Enable the I2C nodes for Allwinner H6 CPU Bhushan Shah
2019-08-11  9:05 ` [PATCH 1/2] arm64: allwinner: h6: add I2C nodes Bhushan Shah
2019-08-12  4:12   ` Chen-Yu Tsai
2019-08-11  9:05 ` [PATCH 2/2] arm64: allwinner: h6: enable i2c0 in PineH64 Bhushan Shah
2019-08-12  4:19   ` Chen-Yu Tsai
2019-08-16  6:47 ` [PATCH v2 0/3] Enable the I2C nodes for Allwinner H6 CPU Bhushan Shah
2019-08-16  6:47   ` [PATCH v2 1/3] dt-bindings: i2c: mv64xxx: Add compatible for the H6 i2c node Bhushan Shah
2019-08-16  6:47   ` [PATCH v2 2/3] arm64: allwinner: h6: add I2C nodes Bhushan Shah
2019-08-16  7:50     ` Maxime Ripard
2019-08-16  8:23       ` Bhushan Shah
2019-08-16  6:47   ` [PATCH v2 3/3] arm64: allwinner: h6: add i2c0 node in PineH64 Bhushan Shah
2019-08-16  7:52     ` Maxime Ripard [this message]
2019-08-16  8:21       ` Bhushan Shah
2019-08-16  8:43   ` [PATCH v3 0/2] Enable the I2C nodes for Allwinner H6 CPU Bhushan Shah
2019-08-16  8:43     ` [PATCH v3 1/2] dt-bindings: i2c: mv64xxx: Add compatible for the H6 i2c node Bhushan Shah
2019-08-16 19:44       ` Rob Herring
2019-08-16  8:43     ` [PATCH v3 2/2] arm64: allwinner: h6: add I2C nodes Bhushan Shah
2019-08-16 11:33       ` Maxime Ripard

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190816075211.xaq54q2cdniwjpp3@flea \
    --to=maxime.ripard@bootlin.com \
    --cc=bshah@kde.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=icenowy@aosc.io \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git