From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Mike Leach <mike.leach@linaro.org>
Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
suzuki.poulose@arm.com
Subject: Re: [PATCH 6/8] coresight: etm4x: Add view comparator settings API to sysfs.
Date: Tue, 27 Aug 2019 15:40:07 -0600 [thread overview]
Message-ID: <20190827214007.GB14958@xps15> (raw)
In-Reply-To: <20190819205720.24457-7-mike.leach@linaro.org>
On Mon, Aug 19, 2019 at 09:57:18PM +0100, Mike Leach wrote:
> Currently it is not possible to view the current settings of a given
> address comparator without knowing what type it is set to. For example, if
> a comparator is set as an addr_start comparator, attempting to read
> addr_stop for the same index will result in an error.
>
> addr_cmp_view is added to allow the user to see the current settings of
> the indexed address comparator without resorting to trail and error when
> the set type is not known.
>
> Signed-off-by: Mike Leach <mike.leach@linaro.org>
> ---
> .../coresight/coresight-etm4x-sysfs.c | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c
> index baac5b48b7ac..483976074779 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c
> +++ b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c
> @@ -1272,6 +1272,56 @@ static ssize_t addr_exlevel_s_ns_store(struct device *dev,
> }
> static DEVICE_ATTR_RW(addr_exlevel_s_ns);
>
> +static const char * const addr_type_names[] = {
> + "unused",
> + "single",
> + "range",
> + "start",
> + "stop"
> +};
> +
> +static ssize_t addr_cmp_view_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + u8 idx, addr_type;
> + unsigned long addr_v, addr_v2, addr_ctrl;
> + struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent);
> + struct etmv4_config *config = &drvdata->config;
> + int size = 0;
> + bool exclude = false;
> +
> + spin_lock(&drvdata->spinlock);
> + idx = config->addr_idx;
> + addr_v = config->addr_val[idx];
> + addr_ctrl = config->addr_acc[idx];
> + addr_type = config->addr_type[idx];
> + if (addr_type == ETM_ADDR_TYPE_RANGE) {
> + if (idx%2) {
> + idx -= 1;
> + addr_v2 = addr_v;
> + addr_v = config->addr_val[idx];
> + } else
> + addr_v2 = config->addr_val[idx+1];
s/"idx+1"/"idx + 1"/
With that:
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> + exclude = config->viiectlr & BIT(idx / 2 + 16);
> + }
> + spin_unlock(&drvdata->spinlock);
> + if (addr_type) {
> + size = scnprintf(buf, PAGE_SIZE, "addr_cmp[%i] %s %#lx", idx,
> + addr_type_names[addr_type], addr_v);
> + if (addr_type == ETM_ADDR_TYPE_RANGE) {
> + size += scnprintf(buf+size, PAGE_SIZE-size,
> + " %#lx %s", addr_v2,
> + exclude ? "exclude" : "include");
> + }
> + size += scnprintf(buf+size, PAGE_SIZE-size,
> + " ctrl(%#lx)\n", addr_ctrl);
> + } else {
> + size = scnprintf(buf, PAGE_SIZE, "addr_cmp[%i] unused\n", idx);
> + }
> + return size;
> +}
> +static DEVICE_ATTR_RO(addr_cmp_view);
> +
> static ssize_t vinst_pe_cmp_start_stop_show(struct device *dev,
> struct device_attribute *attr,
> char *buf)
> @@ -2117,6 +2167,7 @@ static struct attribute *coresight_etmv4_attrs[] = {
> &dev_attr_addr_ctxtype.attr,
> &dev_attr_addr_context.attr,
> &dev_attr_addr_exlevel_s_ns.attr,
> + &dev_attr_addr_cmp_view.attr,
> &dev_attr_vinst_pe_cmp_start_stop.attr,
> &dev_attr_seq_idx.attr,
> &dev_attr_seq_state.attr,
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-27 21:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 20:57 [PATCH 0/8] coresight: etm4x: Fixes and updates for sysfs API Mike Leach
2019-08-19 20:57 ` [PATCH 1/8] coresight: etm4x: Fixes for ETM v4.4 architecture updates Mike Leach
2019-08-26 21:47 ` Mathieu Poirier
2019-08-27 10:12 ` Mike Leach
2019-08-27 19:19 ` Mathieu Poirier
2019-08-28 1:52 ` Leo Yan
2019-08-19 20:57 ` [PATCH 2/8] coresight: etm4x: Fix input validation for sysfs Mike Leach
2019-08-26 22:29 ` Mathieu Poirier
2019-08-28 2:42 ` Leo Yan
2019-08-19 20:57 ` [PATCH 3/8] coresight: etm4x: Add missing API to set EL match on address filters Mike Leach
2019-08-26 22:59 ` Mathieu Poirier
2019-08-27 10:55 ` Mike Leach
2019-08-27 17:57 ` Mathieu Poirier
2019-08-28 2:53 ` Leo Yan
2019-08-28 12:10 ` Mike Leach
2019-08-19 20:57 ` [PATCH 4/8] coresight: etm4x: Fix issues with start-stop logic Mike Leach
2019-08-28 3:17 ` Leo Yan
2019-08-28 12:40 ` Mike Leach
2019-08-19 20:57 ` [PATCH 5/8] coresight: etm4x: Improve usability of sysfs API Mike Leach
2019-08-27 21:35 ` Mathieu Poirier
2019-08-28 3:36 ` Leo Yan
2019-08-28 12:56 ` Mike Leach
2019-08-19 20:57 ` [PATCH 6/8] coresight: etm4x: Add view comparator settings API to sysfs Mike Leach
2019-08-27 21:40 ` Mathieu Poirier [this message]
2019-08-28 4:00 ` Leo Yan
2019-08-19 20:57 ` [PATCH 7/8] coresight: etm4x: Add missing single-shot control " Mike Leach
2019-08-27 22:27 ` Mathieu Poirier
2019-08-28 14:15 ` Mike Leach
2019-08-28 5:18 ` Leo Yan
2019-08-28 14:15 ` Mike Leach
2019-08-19 20:57 ` [PATCH 8/8] coresight: etm4x: docs: Additional documentation for ETM4x Mike Leach
2019-08-27 22:32 ` Mathieu Poirier
2019-08-27 22:34 ` Mathieu Poirier
2019-08-28 14:20 ` Mike Leach
2019-08-28 16:36 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827214007.GB14958@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=coresight@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).