From: "René van Dorst" <opensource@vdorst.com>
To: Rob Herring <robh@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Frank Wunderlich <frank-w@public-files.de>,
netdev@vger.kernel.org, Sean Wang <sean.wang@mediatek.com>,
linux-mips@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org,
John Crispin <john@phrozen.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v2 2/3] dt-bindings: net: dsa: mt7530: Add support for port 5
Date: Fri, 30 Aug 2019 17:16:03 +0000 [thread overview]
Message-ID: <20190830171603.Horde.UeVVg_YU-C4f8bcYmFJ_1Gv@www.vdorst.com> (raw)
In-Reply-To: <20190828063520.Horde.4_ak7mcmFhVJlxZWWy2wo3V@www.vdorst.com>
Hi Rob,
<snip>
>>> See Documentation/devicetree/bindings/net/dsa/dsa.txt for a list
>>> of additional
>>> required, optional properties and how the integrated switch subnodes must
>>> be specified.
>>> @@ -94,3 +130,185 @@ Example:
>>> };
>>> };
>>> };
>>> +
>>> +Example 2: MT7621: Port 4 is WAN port: 2nd GMAC -> Port 5 -> PHY port 4.
>>> +
>>> +ð {
>>> + status = "okay";
>>
>> Don't show status in examples.
>
> OK.
>
>> This should show the complete node.
>>
>
I asked this question below in my previous email.
May be you missed it, I hope that you have time soon to answer this so that I
can send a new version.
> To be clear, I should take ethernet node from the mt7621.dtsi [0] or
> mt7623.dtsi [1] and insert the example below?, right?
Greats,
René
>
> Greats,
>
> René
>
> [0]:
> https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/tree/drivers/staging/mt7621-dts/mt7621.dtsi#n397
> [1]:
> https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/tree/arch/arm/boot/dts/mt7623.dtsi#n1023
>
>>> +
>>> + gmac0: mac@0 {
>>> + compatible = "mediatek,eth-mac";
>>> + reg = <0>;
>>> + phy-mode = "rgmii";
>>> +
>>> + fixed-link {
>>> + speed = <1000>;
>>> + full-duplex;
>>> + pause;
>>> + };
>>> + };
>>> +
>>> + gmac1: mac@1 {
>>> + compatible = "mediatek,eth-mac";
>>> + reg = <1>;
>>> + phy-mode = "rgmii-txid";
>>> + phy-handle = <&phy4>;
>>> + };
>>> +
>>> + mdio: mdio-bus {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + /* Internal phy */
>>> + phy4: ethernet-phy@4 {
>>> + reg = <4>;
>>> + };
>>> +
>>> + mt7530: switch@1f {
>>> + compatible = "mediatek,mt7621";
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + reg = <0x1f>;
>>> + pinctrl-names = "default";
>>> + mediatek,mcm;
>>> +
>>> + resets = <&rstctrl 2>;
>>> + reset-names = "mcm";
>>> +
>>> + ports {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + port@0 {
>>> + reg = <0>;
>>> + label = "lan0";
>>> + };
>>> +
>>> + port@1 {
>>> + reg = <1>;
>>> + label = "lan1";
>>> + };
>>> +
>>> + port@2 {
>>> + reg = <2>;
>>> + label = "lan2";
>>> + };
>>> +
>>> + port@3 {
>>> + reg = <3>;
>>> + label = "lan3";
>>> + };
>>> +
>>> +/* Commented out. Port 4 is handled by 2nd GMAC.
>>> + port@4 {
>>> + reg = <4>;
>>> + label = "lan4";
>>> + };
>>> +*/
>>> +
>>> + cpu_port0: port@6 {
>>> + reg = <6>;
>>> + label = "cpu";
>>> + ethernet = <&gmac0>;
>>> + phy-mode = "rgmii";
>>> +
>>> + fixed-link {
>>> + speed = <1000>;
>>> + full-duplex;
>>> + pause;
>>> + };
>>> + };
>>> + };
>>> + };
>>> + };
>>> +};
>>> +
>>> +Example 3: MT7621: Port 5 is connected to external PHY: Port 5 ->
>>> external PHY.
>>> +
>>> +ð {
>>> + status = "okay";
>>> +
>>> + gmac0: mac@0 {
>>> + compatible = "mediatek,eth-mac";
>>> + reg = <0>;
>>> + phy-mode = "rgmii";
>>> +
>>> + fixed-link {
>>> + speed = <1000>;
>>> + full-duplex;
>>> + pause;
>>> + };
>>> + };
>>> +
>>> + mdio: mdio-bus {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + /* External phy */
>>> + ephy5: ethernet-phy@7 {
>>> + reg = <7>;
>>> + };
>>> +
>>> + mt7530: switch@1f {
>>> + compatible = "mediatek,mt7621";
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + reg = <0x1f>;
>>> + pinctrl-names = "default";
>>> + mediatek,mcm;
>>> +
>>> + resets = <&rstctrl 2>;
>>> + reset-names = "mcm";
>>> +
>>> + ports {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + port@0 {
>>> + reg = <0>;
>>> + label = "lan0";
>>> + };
>>> +
>>> + port@1 {
>>> + reg = <1>;
>>> + label = "lan1";
>>> + };
>>> +
>>> + port@2 {
>>> + reg = <2>;
>>> + label = "lan2";
>>> + };
>>> +
>>> + port@3 {
>>> + reg = <3>;
>>> + label = "lan3";
>>> + };
>>> +
>>> + port@4 {
>>> + reg = <4>;
>>> + label = "lan4";
>>> + };
>>> +
>>> + port@5 {
>>> + reg = <5>;
>>> + label = "lan5";
>>> + phy-mode = "rgmii";
>>> + phy-handle = <&ephy5>;
>>> + };
>>> +
>>> + cpu_port0: port@6 {
>>> + reg = <6>;
>>> + label = "cpu";
>>> + ethernet = <&gmac0>;
>>> + phy-mode = "rgmii";
>>> +
>>> + fixed-link {
>>> + speed = <1000>;
>>> + full-duplex;
>>> + pause;
>>> + };
>>> + };
>>> + };
>>> + };
>>> + };
>>> +};
>>> --
>>> 2.20.1
>>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-30 17:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 14:45 [PATCH net-next v2 0/3] net: dsa: mt7530: Convert to PHYLINK and add support for port 5 René van Dorst
2019-08-21 14:45 ` [PATCH net-next v2 1/3] net: dsa: mt7530: Convert to PHYLINK API René van Dorst
2019-08-21 14:45 ` [PATCH net-next v2 2/3] dt-bindings: net: dsa: mt7530: Add support for port 5 René van Dorst
2019-08-27 22:22 ` Rob Herring
2019-08-28 6:35 ` René van Dorst
2019-08-30 17:16 ` René van Dorst [this message]
2019-08-21 14:45 ` [PATCH net-next v2 3/3] " René van Dorst
2019-08-24 23:19 ` David Miller
2019-08-25 12:48 ` René van Dorst
2019-08-21 21:05 ` [PATCH net-next v2 0/3] net: dsa: mt7530: Convert to PHYLINK and add " Andrew Lunn
2019-08-22 15:44 ` Aw: " Frank Wunderlich
2019-08-22 16:26 ` Frank Wunderlich
2019-08-22 23:20 ` David Miller
2019-08-23 1:09 ` Andrew Lunn
2019-08-24 21:18 ` David Miller
2019-08-24 22:15 ` Andrew Lunn
2019-08-24 22:31 ` Russell King - ARM Linux admin
2019-08-24 22:18 ` Russell King - ARM Linux admin
2019-08-24 22:29 ` Russell King - ARM Linux admin
2019-08-25 13:15 ` René van Dorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830171603.Horde.UeVVg_YU-C4f8bcYmFJ_1Gv@www.vdorst.com \
--to=opensource@vdorst.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frank-w@public-files.de \
--cc=john@phrozen.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).