* Re: [PATCH 1/2] arm64: dts: imx8mm: Remove incorrect fallback compatible for ocotp
2019-09-11 14:24 [PATCH 1/2] arm64: dts: imx8mm: Remove incorrect fallback compatible for ocotp Anson Huang
@ 2019-09-11 9:01 ` Daniel Lezcano
2019-09-11 9:05 ` Anson Huang
2019-09-11 14:24 ` [PATCH 2/2] arm64: dts: imx8mn: Use "fsl, imx8mm-ocotp" as ocotp's fallback compatible Anson Huang
2019-10-06 7:44 ` [PATCH 1/2] arm64: dts: imx8mm: Remove incorrect fallback compatible for ocotp Shawn Guo
2 siblings, 1 reply; 6+ messages in thread
From: Daniel Lezcano @ 2019-09-11 9:01 UTC (permalink / raw)
To: Anson Huang, robh+dt, mark.rutland, shawnguo, s.hauer, kernel,
festevam, leonard.crestez, ping.bai, daniel.baluta, jun.li,
devicetree, linux-arm-kernel, linux-kernel
Cc: Linux-imx
On 11/09/2019 16:24, Anson Huang wrote:
> Compared to i.MX7D, i.MX8MM has different ocotp layout, so it should
> NOT use "fsl,imx7d-ocotp" as ocotp's fallback compatible, remove it.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mm.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index 5f9d0da..7c4dcce 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -426,7 +426,7 @@
> };
>
> ocotp: ocotp-ctrl@30350000 {
> - compatible = "fsl,imx8mm-ocotp", "fsl,imx7d-ocotp", "syscon";
> + compatible = "fsl,imx8mm-ocotp", "syscon";
> reg = <0x30350000 0x10000>;
> clocks = <&clk IMX8MM_CLK_OCOTP_ROOT>;
> /* For nvmem subnodes */
Why not fold the two patches?
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH 1/2] arm64: dts: imx8mm: Remove incorrect fallback compatible for ocotp
2019-09-11 9:01 ` Daniel Lezcano
@ 2019-09-11 9:05 ` Anson Huang
2019-09-11 9:17 ` Daniel Lezcano
0 siblings, 1 reply; 6+ messages in thread
From: Anson Huang @ 2019-09-11 9:05 UTC (permalink / raw)
To: Daniel Lezcano, robh+dt, mark.rutland, shawnguo, s.hauer, kernel,
festevam, Leonard Crestez, Jacky Bai, Daniel Baluta, Jun Li,
devicetree, linux-arm-kernel, linux-kernel
Cc: dl-linux-imx
Hi, Daniel
> On 11/09/2019 16:24, Anson Huang wrote:
> > Compared to i.MX7D, i.MX8MM has different ocotp layout, so it should
> > NOT use "fsl,imx7d-ocotp" as ocotp's fallback compatible, remove it.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > index 5f9d0da..7c4dcce 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > @@ -426,7 +426,7 @@
> > };
> >
> > ocotp: ocotp-ctrl@30350000 {
> > - compatible = "fsl,imx8mm-ocotp", "fsl,imx7d-
> ocotp", "syscon";
> > + compatible = "fsl,imx8mm-ocotp", "syscon";
> > reg = <0x30350000 0x10000>;
> > clocks = <&clk IMX8MM_CLK_OCOTP_ROOT>;
> > /* For nvmem subnodes */
>
> Why not fold the two patches?
For i.MX8MM, it just removes the incorrect fallback compatible, for i.MX8MN, it needs
to replace the incorrect fallback compatible in order to support SoC UID read, so I think
this should be 2 separate patch?
Thanks,
Anson.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] arm64: dts: imx8mm: Remove incorrect fallback compatible for ocotp
2019-09-11 9:05 ` Anson Huang
@ 2019-09-11 9:17 ` Daniel Lezcano
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Lezcano @ 2019-09-11 9:17 UTC (permalink / raw)
To: Anson Huang
Cc: mark.rutland, devicetree, Jacky Bai, shawnguo, s.hauer,
linux-kernel, Daniel Baluta, robh+dt, dl-linux-imx, kernel,
Leonard Crestez, festevam, linux-arm-kernel, Jun Li
On Wed, Sep 11, 2019 at 09:05:49AM +0000, Anson Huang wrote:
> Hi, Daniel
>
> > On 11/09/2019 16:24, Anson Huang wrote:
> > > Compared to i.MX7D, i.MX8MM has different ocotp layout, so it should
> > > NOT use "fsl,imx7d-ocotp" as ocotp's fallback compatible, remove it.
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > > ---
> > > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > index 5f9d0da..7c4dcce 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > @@ -426,7 +426,7 @@
> > > };
> > >
> > > ocotp: ocotp-ctrl@30350000 {
> > > - compatible = "fsl,imx8mm-ocotp", "fsl,imx7d-
> > ocotp", "syscon";
> > > + compatible = "fsl,imx8mm-ocotp", "syscon";
> > > reg = <0x30350000 0x10000>;
> > > clocks = <&clk IMX8MM_CLK_OCOTP_ROOT>;
> > > /* For nvmem subnodes */
> >
> > Why not fold the two patches?
>
> For i.MX8MM, it just removes the incorrect fallback compatible, for i.MX8MN, it needs
> to replace the incorrect fallback compatible in order to support SoC UID read, so I think
> this should be 2 separate patch?
Oh, yes, there is a subtle difference in the file name :) m|n. I understand
now why you splitted it.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm64: dts: imx8mn: Use "fsl, imx8mm-ocotp" as ocotp's fallback compatible
2019-09-11 14:24 [PATCH 1/2] arm64: dts: imx8mm: Remove incorrect fallback compatible for ocotp Anson Huang
2019-09-11 9:01 ` Daniel Lezcano
@ 2019-09-11 14:24 ` Anson Huang
2019-10-06 7:44 ` [PATCH 1/2] arm64: dts: imx8mm: Remove incorrect fallback compatible for ocotp Shawn Guo
2 siblings, 0 replies; 6+ messages in thread
From: Anson Huang @ 2019-09-11 14:24 UTC (permalink / raw)
To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
leonard.crestez, daniel.lezcano, ping.bai, daniel.baluta, jun.li,
devicetree, linux-arm-kernel, linux-kernel
Cc: Linux-imx
Use "fsl,imx8mm-ocotp" as i.MX8MN ocotp's fallback compatible instead
of "fsl,imx7d-ocotp" to support SoC UID read, as i.MX8MN reuses
i.MX8MM's SoC ID driver.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mn.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
index e4efe8d..6cb6c9c 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
@@ -337,7 +337,7 @@
};
ocotp: ocotp-ctrl@30350000 {
- compatible = "fsl,imx8mn-ocotp", "fsl,imx7d-ocotp", "syscon";
+ compatible = "fsl,imx8mn-ocotp", "fsl,imx8mm-ocotp", "syscon";
reg = <0x30350000 0x10000>;
clocks = <&clk IMX8MN_CLK_OCOTP_ROOT>;
#address-cells = <1>;
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] arm64: dts: imx8mm: Remove incorrect fallback compatible for ocotp
2019-09-11 14:24 [PATCH 1/2] arm64: dts: imx8mm: Remove incorrect fallback compatible for ocotp Anson Huang
2019-09-11 9:01 ` Daniel Lezcano
2019-09-11 14:24 ` [PATCH 2/2] arm64: dts: imx8mn: Use "fsl, imx8mm-ocotp" as ocotp's fallback compatible Anson Huang
@ 2019-10-06 7:44 ` Shawn Guo
2 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2019-10-06 7:44 UTC (permalink / raw)
To: Anson Huang
Cc: mark.rutland, devicetree, ping.bai, daniel.baluta, s.hauer,
daniel.lezcano, linux-kernel, robh+dt, Linux-imx, kernel,
leonard.crestez, festevam, linux-arm-kernel, jun.li
On Wed, Sep 11, 2019 at 10:24:46AM -0400, Anson Huang wrote:
> Compared to i.MX7D, i.MX8MM has different ocotp layout, so it should
> NOT use "fsl,imx7d-ocotp" as ocotp's fallback compatible, remove it.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Applied both, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread