* [PATCH v3 0/2] Exynos5 DMC minor fixes
[not found] <CGME20190919092652eucas1p2715611db7a0b0c4cc79956311e01c35a@eucas1p2.samsung.com>
@ 2019-09-19 9:26 ` Lukasz Luba
[not found] ` <CGME20190919092652eucas1p12dbf9ba9d60a0c89cb7de05ab61893be@eucas1p1.samsung.com>
[not found] ` <CGME20190919092653eucas1p21a1caa00589649fbc972bc7b84fe0d89@eucas1p2.samsung.com>
0 siblings, 2 replies; 6+ messages in thread
From: Lukasz Luba @ 2019-09-19 9:26 UTC (permalink / raw)
To: devicetree, linux-kernel, linux-pm, linux-samsung-soc, linux-arm-kernel
Cc: mark.rutland, willy.mh.wolff.ml, b.zolnierkie, krzk, Lukasz Luba,
cw00.choi, kyungmin.park, robh+dt, kgene, s.nawrocki,
myungjoo.ham, dan.carpenter, m.szyprowski
Hi all,
This is a follow up patch set for the Exynos5 Dynamic Memory Controller
driver v13 [1]. The patches are for Krzysztof's branch [2]
for-v5.4-5.5/memory-samsung-dmc
and/or linux-next where Dan Carpenter reported the issue (patch 1/2).
There are a few fixes captured during static analysis and a new
binding for 'samsung,K3QF2F20DB' LPDDR3 memory.
Regards,
Lukasz Luba
[1] https://lkml.org/lkml/2019/8/21/283
[2] https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/log/?h=for-v5.4-5.5/memory-samsung-dmc
Lukasz Luba (2):
memory: samsung: exynos5422-dmc: Fix kfree() of devm-allocated memory
and missing static
dt-bindings: ddr: Add bindings for Samsung LPDDR3 memories
Documentation/devicetree/bindings/ddr/lpddr3.txt | 10 +++++++---
drivers/memory/samsung/exynos5422-dmc.c | 6 ++----
2 files changed, 9 insertions(+), 7 deletions(-)
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 1/2] memory: samsung: exynos5422-dmc: Fix kfree() of devm-allocated memory and missing static
[not found] ` <CGME20190919092652eucas1p12dbf9ba9d60a0c89cb7de05ab61893be@eucas1p1.samsung.com>
@ 2019-09-19 9:26 ` Lukasz Luba
2019-09-19 9:32 ` Dan Carpenter
2019-09-19 18:19 ` Krzysztof Kozlowski
0 siblings, 2 replies; 6+ messages in thread
From: Lukasz Luba @ 2019-09-19 9:26 UTC (permalink / raw)
To: devicetree, linux-kernel, linux-pm, linux-samsung-soc, linux-arm-kernel
Cc: mark.rutland, willy.mh.wolff.ml, b.zolnierkie, krzk, Lukasz Luba,
cw00.choi, kyungmin.park, robh+dt, kgene, s.nawrocki,
myungjoo.ham, dan.carpenter, m.szyprowski
Fix issues captured by static checkers: used kfree() and missing 'static'
in the private function.
Fixes Smatch warning:
drivers/memory/samsung/exynos5422-dmc.c:272
exynos5_init_freq_table() warn: passing devm_ allocated variable to kfree. 'dmc->opp'
Fixes Sparse warning:
drivers/memory/samsung/exynos5422-dmc.c:736:1:
warning: symbol 'exynos5_dmc_align_init_freq' was not declared.
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
---
drivers/memory/samsung/exynos5422-dmc.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c
index 8c2ec29a7d57..1b54fc8c912e 100644
--- a/drivers/memory/samsung/exynos5422-dmc.c
+++ b/drivers/memory/samsung/exynos5422-dmc.c
@@ -258,7 +258,7 @@ static int exynos5_init_freq_table(struct exynos5_dmc *dmc,
opp = dev_pm_opp_find_freq_floor(dmc->dev, &freq);
if (IS_ERR(opp))
- goto err_free_tables;
+ goto err_opp;
dmc->opp[idx - i].freq_hz = freq;
dmc->opp[idx - i].volt_uv = dev_pm_opp_get_voltage(opp);
@@ -268,8 +268,6 @@ static int exynos5_init_freq_table(struct exynos5_dmc *dmc,
return 0;
-err_free_tables:
- kfree(dmc->opp);
err_opp:
dev_pm_opp_of_remove_table(dmc->dev);
@@ -732,7 +730,7 @@ static struct devfreq_dev_profile exynos5_dmc_df_profile = {
* statistics engine which supports only registered values. Thus, some alignment
* must be made.
*/
-unsigned long
+static unsigned long
exynos5_dmc_align_init_freq(struct exynos5_dmc *dmc,
unsigned long bootloader_init_freq)
{
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v3 2/2] dt-bindings: ddr: Add bindings for Samsung LPDDR3 memories
[not found] ` <CGME20190919092653eucas1p21a1caa00589649fbc972bc7b84fe0d89@eucas1p2.samsung.com>
@ 2019-09-19 9:26 ` Lukasz Luba
2019-09-19 18:20 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Lukasz Luba @ 2019-09-19 9:26 UTC (permalink / raw)
To: devicetree, linux-kernel, linux-pm, linux-samsung-soc, linux-arm-kernel
Cc: mark.rutland, willy.mh.wolff.ml, b.zolnierkie, krzk, Lukasz Luba,
cw00.choi, kyungmin.park, robh+dt, kgene, s.nawrocki,
myungjoo.ham, dan.carpenter, m.szyprowski
Add compatible for Samsung k3qf2f20db LPDDR3 memory bindings.
Suggested to based on at25.txt compatible section.
Introduce minor fixes in the old documentation.
Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
---
Documentation/devicetree/bindings/ddr/lpddr3.txt | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/ddr/lpddr3.txt b/Documentation/devicetree/bindings/ddr/lpddr3.txt
index 3b2485b84b3f..a0eda35a86ee 100644
--- a/Documentation/devicetree/bindings/ddr/lpddr3.txt
+++ b/Documentation/devicetree/bindings/ddr/lpddr3.txt
@@ -1,7 +1,10 @@
* LPDDR3 SDRAM memories compliant to JEDEC JESD209-3C
Required properties:
-- compatible : Should be - "jedec,lpddr3"
+- compatible : Should be "<vendor>,<type>", and generic value "jedec,lpddr3".
+ Example "<vendor>,<type>" values:
+ "samsung,K3QF2F20DB"
+
- density : <u32> representing density in Mb (Mega bits)
- io-width : <u32> representing bus width. Possible values are 8, 16, 32, 64
- #address-cells: Must be set to 1
@@ -43,7 +46,7 @@ Child nodes:
Example:
samsung_K3QF2F20DB: lpddr3 {
- compatible = "Samsung,K3QF2F20DB", "jedec,lpddr3";
+ compatible = "samsung,K3QF2F20DB", "jedec,lpddr3";
density = <16384>;
io-width = <32>;
#address-cells = <1>;
@@ -73,7 +76,8 @@ samsung_K3QF2F20DB: lpddr3 {
timings_samsung_K3QF2F20DB_800mhz: lpddr3-timings@800000000 {
compatible = "jedec,lpddr3-timings";
- reg = <800000000>; /* workaround: it shows max-freq */
+ /* workaround: 'reg' shows max-freq */
+ reg = <800000000>;
min-freq = <100000000>;
tRFC = <65000>;
tRRD = <6000>;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3 1/2] memory: samsung: exynos5422-dmc: Fix kfree() of devm-allocated memory and missing static
2019-09-19 9:26 ` [PATCH v3 1/2] memory: samsung: exynos5422-dmc: Fix kfree() of devm-allocated memory and missing static Lukasz Luba
@ 2019-09-19 9:32 ` Dan Carpenter
2019-09-19 18:19 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2019-09-19 9:32 UTC (permalink / raw)
To: Lukasz Luba
Cc: mark.rutland, devicetree, willy.mh.wolff.ml, linux-samsung-soc,
cw00.choi, b.zolnierkie, linux-pm, linux-kernel, krzk, robh+dt,
kyungmin.park, kgene, myungjoo.ham, s.nawrocki, linux-arm-kernel,
m.szyprowski
Thanks! Looks good.
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 1/2] memory: samsung: exynos5422-dmc: Fix kfree() of devm-allocated memory and missing static
2019-09-19 9:26 ` [PATCH v3 1/2] memory: samsung: exynos5422-dmc: Fix kfree() of devm-allocated memory and missing static Lukasz Luba
2019-09-19 9:32 ` Dan Carpenter
@ 2019-09-19 18:19 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2019-09-19 18:19 UTC (permalink / raw)
To: Lukasz Luba
Cc: mark.rutland, devicetree, willy.mh.wolff.ml, linux-samsung-soc,
b.zolnierkie, linux-pm, linux-kernel, robh+dt, cw00.choi,
kyungmin.park, kgene, myungjoo.ham, s.nawrocki, dan.carpenter,
linux-arm-kernel, m.szyprowski
On Thu, Sep 19, 2019 at 11:26:40AM +0200, Lukasz Luba wrote:
> Fix issues captured by static checkers: used kfree() and missing 'static'
> in the private function.
>
> Fixes Smatch warning:
> drivers/memory/samsung/exynos5422-dmc.c:272
> exynos5_init_freq_table() warn: passing devm_ allocated variable to kfree. 'dmc->opp'
>
> Fixes Sparse warning:
> drivers/memory/samsung/exynos5422-dmc.c:736:1:
> warning: symbol 'exynos5_dmc_align_init_freq' was not declared.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
> ---
> drivers/memory/samsung/exynos5422-dmc.c | 6 ++----
Thanks, applied.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: ddr: Add bindings for Samsung LPDDR3 memories
2019-09-19 9:26 ` [PATCH v3 2/2] dt-bindings: ddr: Add bindings for Samsung LPDDR3 memories Lukasz Luba
@ 2019-09-19 18:20 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2019-09-19 18:20 UTC (permalink / raw)
To: Lukasz Luba
Cc: mark.rutland, devicetree, willy.mh.wolff.ml, linux-samsung-soc,
b.zolnierkie, linux-pm, linux-kernel, robh+dt, cw00.choi,
kyungmin.park, kgene, myungjoo.ham, s.nawrocki, dan.carpenter,
linux-arm-kernel, m.szyprowski
On Thu, Sep 19, 2019 at 11:26:41AM +0200, Lukasz Luba wrote:
> Add compatible for Samsung k3qf2f20db LPDDR3 memory bindings.
> Suggested to based on at25.txt compatible section.
> Introduce minor fixes in the old documentation.
>
> Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
> ---
> Documentation/devicetree/bindings/ddr/lpddr3.txt | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
Thanks, applied.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-09-19 18:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20190919092652eucas1p2715611db7a0b0c4cc79956311e01c35a@eucas1p2.samsung.com>
2019-09-19 9:26 ` [PATCH v3 0/2] Exynos5 DMC minor fixes Lukasz Luba
[not found] ` <CGME20190919092652eucas1p12dbf9ba9d60a0c89cb7de05ab61893be@eucas1p1.samsung.com>
2019-09-19 9:26 ` [PATCH v3 1/2] memory: samsung: exynos5422-dmc: Fix kfree() of devm-allocated memory and missing static Lukasz Luba
2019-09-19 9:32 ` Dan Carpenter
2019-09-19 18:19 ` Krzysztof Kozlowski
[not found] ` <CGME20190919092653eucas1p21a1caa00589649fbc972bc7b84fe0d89@eucas1p2.samsung.com>
2019-09-19 9:26 ` [PATCH v3 2/2] dt-bindings: ddr: Add bindings for Samsung LPDDR3 memories Lukasz Luba
2019-09-19 18:20 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).