[PATCH] Bluetooth: hci_ll: set operational frequency earlier

[PATCH] Bluetooth: hci_ll: set operational frequency earlier

[Adam Ford]

Is anyone else having issues with the hci_ll after  a2e02f38eff8
("Bluetooth: hci_ll: set operational frequency earlier") was applied?

I have an i.MX6Q with a WL1837MOD attached to UART2.  After this patch
I git a bunch of timeouts when initializing the device using the 5.3
and 5.3.1 kernel.   I know a bunch of omap and imx users have done
some various tests over the years, so I thought I'd ask.

[  195.911836] Bluetooth: hci0: command 0xff36 tx timeout
[  206.071837] Bluetooth: hci0: command 0x1001 tx timeout
[  214.231862] Bluetooth: hci0: Reading TI version information failed (-110)
[  214.238712] Bluetooth: hci0: download firmware failed, retrying...
[  216.391834] Bluetooth: hci0: command 0xff36 tx timeout
[  226.551843] Bluetooth: hci0: command 0x1001 tx timeout
[  234.711856] Bluetooth: hci0: Reading TI version information failed (-110)
[  234.718705] Bluetooth: hci0: download firmware failed, retrying...
[  236.871832] Bluetooth: hci0: command 0xff36 tx timeout
[  247.031837] Bluetooth: hci0: command 0x1001 tx timeout
[  255.191852] Bluetooth: hci0: Reading TI version information failed (-110)
[  255.198706] Bluetooth: hci0: download firmware failed, retrying...
Can't init device hci0: Connection timed out (110)

Revering this patch fixes the issue, and subsequent patch proposals
form Philipp haven't seemed to fix the issues for me on 5.3

adam

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] Bluetooth: hci_ll: set operational frequency earlier

[Sebastian Reichel]

[-- Attachment #1.1: Type: text/plain, Size: 1747 bytes --]

Hi,

On Mon, Sep 30, 2019 at 03:10:18PM -0500, Adam Ford wrote:
> Is anyone else having issues with the hci_ll after a2e02f38eff8
> ("Bluetooth: hci_ll: set operational frequency earlier") was applied?
> 
> I have an i.MX6Q with a WL1837MOD attached to UART2. After this patch
> I git a bunch of timeouts when initializing the device using the 5.3
> and 5.3.1 kernel.   I know a bunch of omap and imx users have done
> some various tests over the years, so I thought I'd ask.
> 
> [  195.911836] Bluetooth: hci0: command 0xff36 tx timeout
> [  206.071837] Bluetooth: hci0: command 0x1001 tx timeout
> [  214.231862] Bluetooth: hci0: Reading TI version information failed (-110)
> [  214.238712] Bluetooth: hci0: download firmware failed, retrying...
> [  216.391834] Bluetooth: hci0: command 0xff36 tx timeout
> [  226.551843] Bluetooth: hci0: command 0x1001 tx timeout
> [  234.711856] Bluetooth: hci0: Reading TI version information failed (-110)
> [  234.718705] Bluetooth: hci0: download firmware failed, retrying...
> [  236.871832] Bluetooth: hci0: command 0xff36 tx timeout
> [  247.031837] Bluetooth: hci0: command 0x1001 tx timeout
> [  255.191852] Bluetooth: hci0: Reading TI version information failed (-110)
> [  255.198706] Bluetooth: hci0: download firmware failed, retrying...
>
> Can't init device hci0: Connection timed out (110)

I can see the same messages on OMAP4+WL1285 based Motorola Droid 4
(with the same commands resulting in a timeout).

> Revering this patch fixes the issue,

Ack.

> and subsequent patch proposals form Philipp haven't seemed
> to fix the issues for me on 5.3.

I did not do any further tests, just noticed this while working
on another patchset.

-- Sebastian

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] Bluetooth: hci_ll: set operational frequency earlier

[Philipp Puschmann]

A few times i have seen this here too. The wl1837mod should definitely be able to set
the operaional frequency before loading the firmware.
It takes nearly 5 seconds to upload the firmware with 115kbps while only
0.2s with 3mbps. So i see a high interest to do it the fast way.
A problem i have identified may be the power supply. At least on my custom board
the power supply is controlled via gpio. But the serial bluetooth device has no
support for a regulator. As it is controlled by wifi driver only. I have prepared a patch
adding regulator support to hci_ll driver. In a few weeks i may try to get it upstream.

Another problem may be the timings. The timings the driver uses are according the wl1837mod
datasheets but it may that not all devices of that class or the wiring have the same
specifications and this causes the trouble.

For the above mentioned performance gain i would like to see the problem really solved.
It may be enough to add some sleep time or small delay or something of that kind in
ll_setup().

Regards,
Philipp


Am 30.09.19 um 22:10 schrieb Adam Ford:
> Is anyone else having issues with the hci_ll after  a2e02f38eff8
> ("Bluetooth: hci_ll: set operational frequency earlier") was applied?
> 
> I have an i.MX6Q with a WL1837MOD attached to UART2.  After this patch
> I git a bunch of timeouts when initializing the device using the 5.3
> and 5.3.1 kernel.   I know a bunch of omap and imx users have done
> some various tests over the years, so I thought I'd ask.
> 
> [  195.911836] Bluetooth: hci0: command 0xff36 tx timeout
> [  206.071837] Bluetooth: hci0: command 0x1001 tx timeout
> [  214.231862] Bluetooth: hci0: Reading TI version information failed (-110)
> [  214.238712] Bluetooth: hci0: download firmware failed, retrying...
> [  216.391834] Bluetooth: hci0: command 0xff36 tx timeout
> [  226.551843] Bluetooth: hci0: command 0x1001 tx timeout
> [  234.711856] Bluetooth: hci0: Reading TI version information failed (-110)
> [  234.718705] Bluetooth: hci0: download firmware failed, retrying...
> [  236.871832] Bluetooth: hci0: command 0xff36 tx timeout
> [  247.031837] Bluetooth: hci0: command 0x1001 tx timeout
> [  255.191852] Bluetooth: hci0: Reading TI version information failed (-110)
> [  255.198706] Bluetooth: hci0: download firmware failed, retrying...
> Can't init device hci0: Connection timed out (110)
> 
> Revering this patch fixes the issue, and subsequent patch proposals
> form Philipp haven't seemed to fix the issues for me on 5.3
> 
> adam
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] Bluetooth: hci_ll: set operational frequency earlier

[Adam Ford]

On Tue, Oct 1, 2019 at 2:04 AM Philipp Puschmann
<philipp.puschmann@emlix.com> wrote:
>
> A few times i have seen this here too. The wl1837mod should definitely be able to set
> the operaional frequency before loading the firmware.
> It takes nearly 5 seconds to upload the firmware with 115kbps while only
> 0.2s with 3mbps. So i see a high interest to do it the fast way.
> A problem i have identified may be the power supply. At least on my custom board
> the power supply is controlled via gpio. But the serial bluetooth device has no
> support for a regulator. As it is controlled by wifi driver only. I have prepared a patch
> adding regulator support to hci_ll driver. In a few weeks i may try to get it upstream.

Any change you can share with me what you have?  With 5.4 being the
next LTS and at least two of us with broken boards, I am concerned
that a patch in a few weeks may not make the cut for the final release
of 5.4.

>
> Another problem may be the timings. The timings the driver uses are according the wl1837mod
> datasheets but it may that not all devices of that class or the wiring have the same
> specifications and this causes the trouble.
>
> For the above mentioned performance gain i would like to see the problem really solved.

I agree it would be nice to have it working fast, but for others of
us, we just need to work, so unless there is a clear solution to the
problem, I would advocate reverting the patch until the solution can
be found that doesn't break other boards.

> It may be enough to add some sleep time or small delay or something of that kind in
> ll_setup().
>

I am willing to try something if you want.


adam
> Regards,
> Philipp
>
>
> Am 30.09.19 um 22:10 schrieb Adam Ford:
> > Is anyone else having issues with the hci_ll after  a2e02f38eff8
> > ("Bluetooth: hci_ll: set operational frequency earlier") was applied?
> >
> > I have an i.MX6Q with a WL1837MOD attached to UART2.  After this patch
> > I git a bunch of timeouts when initializing the device using the 5.3
> > and 5.3.1 kernel.   I know a bunch of omap and imx users have done
> > some various tests over the years, so I thought I'd ask.
> >
> > [  195.911836] Bluetooth: hci0: command 0xff36 tx timeout
> > [  206.071837] Bluetooth: hci0: command 0x1001 tx timeout
> > [  214.231862] Bluetooth: hci0: Reading TI version information failed (-110)
> > [  214.238712] Bluetooth: hci0: download firmware failed, retrying...
> > [  216.391834] Bluetooth: hci0: command 0xff36 tx timeout
> > [  226.551843] Bluetooth: hci0: command 0x1001 tx timeout
> > [  234.711856] Bluetooth: hci0: Reading TI version information failed (-110)
> > [  234.718705] Bluetooth: hci0: download firmware failed, retrying...
> > [  236.871832] Bluetooth: hci0: command 0xff36 tx timeout
> > [  247.031837] Bluetooth: hci0: command 0x1001 tx timeout
> > [  255.191852] Bluetooth: hci0: Reading TI version information failed (-110)
> > [  255.198706] Bluetooth: hci0: download firmware failed, retrying...
> > Can't init device hci0: Connection timed out (110)
> >
> > Revering this patch fixes the issue, and subsequent patch proposals
> > form Philipp haven't seemed to fix the issues for me on 5.3
> >
> > adam
> >

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel