* [PATCH] arm64: errata: Update stale comment
@ 2019-09-23 9:12 Thierry Reding
2019-10-02 13:20 ` Marc Zyngier
0 siblings, 1 reply; 2+ messages in thread
From: Thierry Reding @ 2019-09-23 9:12 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon; +Cc: Marc Zyngier, linux-kernel, linux-arm-kernel
From: Thierry Reding <treding@nvidia.com>
Commit 73f381660959 ("arm64: Advertise mitigation of Spectre-v2, or lack
thereof") renamed the caller of the install_bp_hardening_cb() function
but forgot to update a comment, which can be confusing when trying to
follow the code flow.
Fixes: 73f381660959 ("arm64: Advertise mitigation of Spectre-v2, or lack thereof")
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
arch/arm64/kernel/cpu_errata.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c
index 1e43ba5c79b7..f593f4cffc0d 100644
--- a/arch/arm64/kernel/cpu_errata.c
+++ b/arch/arm64/kernel/cpu_errata.c
@@ -128,8 +128,8 @@ static void install_bp_hardening_cb(bp_hardening_cb_t fn,
int cpu, slot = -1;
/*
- * enable_smccc_arch_workaround_1() passes NULL for the hyp_vecs
- * start/end if we're a guest. Skip the hyp-vectors work.
+ * detect_harden_bp_fw() passes NULL for the hyp_vecs start/end if
+ * we're a guest. Skip the hyp-vectors work.
*/
if (!hyp_vecs_start) {
__this_cpu_write(bp_hardening_data.fn, fn);
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: errata: Update stale comment
2019-09-23 9:12 [PATCH] arm64: errata: Update stale comment Thierry Reding
@ 2019-10-02 13:20 ` Marc Zyngier
0 siblings, 0 replies; 2+ messages in thread
From: Marc Zyngier @ 2019-10-02 13:20 UTC (permalink / raw)
To: Thierry Reding
Cc: Catalin Marinas, Will Deacon, linux-kernel, linux-arm-kernel
On Mon, 23 Sep 2019 11:12:29 +0200
Thierry Reding <thierry.reding@gmail.com> wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Commit 73f381660959 ("arm64: Advertise mitigation of Spectre-v2, or lack
> thereof") renamed the caller of the install_bp_hardening_cb() function
> but forgot to update a comment, which can be confusing when trying to
> follow the code flow.
>
> Fixes: 73f381660959 ("arm64: Advertise mitigation of Spectre-v2, or lack thereof")
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> arch/arm64/kernel/cpu_errata.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c
> index 1e43ba5c79b7..f593f4cffc0d 100644
> --- a/arch/arm64/kernel/cpu_errata.c
> +++ b/arch/arm64/kernel/cpu_errata.c
> @@ -128,8 +128,8 @@ static void install_bp_hardening_cb(bp_hardening_cb_t fn,
> int cpu, slot = -1;
>
> /*
> - * enable_smccc_arch_workaround_1() passes NULL for the hyp_vecs
> - * start/end if we're a guest. Skip the hyp-vectors work.
> + * detect_harden_bp_fw() passes NULL for the hyp_vecs start/end if
> + * we're a guest. Skip the hyp-vectors work.
> */
> if (!hyp_vecs_start) {
> __this_cpu_write(bp_hardening_data.fn, fn);
Acked-by: Marc Zyngier <maz@kernel.org>
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-02 13:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-23 9:12 [PATCH] arm64: errata: Update stale comment Thierry Reding
2019-10-02 13:20 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).