linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: ard.biesheuvel@linaro.org, catalin.marinas@arm.com,
	ndesaulniers@google.com, linux-kernel@vger.kernel.org,
	luto@kernel.org, tglx@linutronix.de,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 0/6] arm64: vdso32: Address various issues
Date: Tue, 8 Oct 2019 10:07:38 +0100	[thread overview]
Message-ID: <20191008090737.yari3gbtg65cuq7d@willie-the-truck> (raw)
In-Reply-To: <2b3b3255-6532-e70c-8d1a-8d60308adbe1@arm.com>

On Mon, Oct 07, 2019 at 06:48:00PM +0100, Vincenzo Frascino wrote:
> On 07/10/2019 15:37, Vincenzo Frascino wrote:
> > On 07/10/2019 15:15, Will Deacon wrote:
> >> On Mon, Oct 07, 2019 at 02:54:29PM +0100, Vincenzo Frascino wrote:
> >>> On 07/10/2019 14:31, Will Deacon wrote:
> >>>> I've queued this up as fixes for 5.4, but I ended up making quite a few
> >>>> additional changes to address some other issues and minor inconsistencies
> >>>> I ran into. In particular, with my changes, you can now easily build the
> >>>> kernel with clang but the compat vDSO with gcc. The header files still need
> >>>> sorting out properly, but I think this is a decent starting point:
> >>>>
> >>>> https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/log/?h=for-next/fixes
> >>>>
> >>>> Please have a look.
> >>>>
> >>>
> >>> Thank you for letting me know, I will have a look.
> >>
> >> Thanks.
> >>
> >>> I see acked-by Catalin on the patches, did you post them in review somewhere? I
> >>> could not find them. Sorry
> >>
> >> I pushed them out to a temporary vdso branch on Friday and Catalin looked at
> >> that. If you'd like me to post them as well, please let me know, although
> >> I'm keen to get this stuff sorted out by -rc3 without disabling the compat
> >> vDSO altogether (i.e. [1]). In other words, if you're ok with my changes on
> >> top of yours then let's go for that, otherwise let's punt this to 5.5 and
> >> try to fix the header mess at the same time.
> >>
> > 
> > No need to repost them. I just got confused by the fact that they got acked and
> > I could not find them anywhere, hence my question.
> > 
> > I am keen to sort this thing as well, my personal preference is to not disable
> > compat vdso in 5.4.
> > 
> > I will download your tree, have a look at it and let you know my thoughts.
> > 
> 
> I tested your patches and they look fine to me. I have just one request, in the
> commit message of patch were you rename COMPATCC to CC_COMPAT could you please
> add the make command with the update variable?
> 
>    $ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- \
>         CROSS_COMPILE_COMPAT=arm-linux-gnueabihf- CC=clang \
>         CC_COMPAT=arm-linux-gnueabihf-gcc
> 
> It took me a while to understand that the command in the commit message
> (c71e88c43796 "arm64: vdso32: Don't use KBUILD_CPPFLAGS unconditionally") was
> not working because of the renaming.
> 
> Thanks!
> 
> If it is not too late you can add my reviewed-by and tested-by ;)

Thanks, Vincenzo. I'd prefer not to rebase that branch, but I'll mention
your tags in the pull request so they may end up in the merge commit.

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2019-10-08  9:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-03 17:48 [PATCH v5 0/6] arm64: vdso32: Address various issues Vincenzo Frascino
2019-10-03 17:48 ` [PATCH v5 1/6] arm64: vdso32: Fix syncconfig errors Vincenzo Frascino
2019-10-03 17:48 ` [PATCH v5 2/6] arm64: vdso32: Detect binutils support for dmb ishld Vincenzo Frascino
2019-10-03 20:18   ` Nick Desaulniers
2019-10-03 20:49     ` Will Deacon
2019-10-03 20:56       ` Nick Desaulniers
2019-10-03 20:59         ` Will Deacon
2019-10-03 21:50           ` Nick Desaulniers
2019-10-03 17:48 ` [PATCH v5 3/6] arm64: Remove gettimeofday.S Vincenzo Frascino
2019-10-03 17:48 ` [PATCH v5 4/6] arm64: vdso32: Remove jump label config option in Makefile Vincenzo Frascino
2019-10-03 17:48 ` [PATCH v5 5/6] arm64: Remove vdso_datapage.h Vincenzo Frascino
2019-10-03 17:48 ` [PATCH v5 6/6] lib: vdso: Remove CROSS_COMPILE_COMPAT_VDSO Vincenzo Frascino
2019-10-07 13:31 ` [PATCH v5 0/6] arm64: vdso32: Address various issues Will Deacon
2019-10-07 13:54   ` Vincenzo Frascino
2019-10-07 14:15     ` Will Deacon
2019-10-07 14:37       ` Vincenzo Frascino
2019-10-07 17:48         ` Vincenzo Frascino
2019-10-08  9:07           ` Will Deacon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191008090737.yari3gbtg65cuq7d@willie-the-truck \
    --to=will@kernel.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=tglx@linutronix.de \
    --cc=vincenzo.frascino@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).