Re: [PATCH v5 0/6] arm64: vdso32: Address various issues

From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Will Deacon <will@kernel.org>
Cc: ard.biesheuvel@linaro.org, catalin.marinas@arm.com,
	ndesaulniers@google.com, linux-kernel@vger.kernel.org,
	luto@kernel.org, tglx@linutronix.de,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 0/6] arm64: vdso32: Address various issues
Date: Mon, 7 Oct 2019 18:48:00 +0100	[thread overview]
Message-ID: <2b3b3255-6532-e70c-8d1a-8d60308adbe1@arm.com> (raw)
In-Reply-To: <ba8f3b9a-714f-08da-f93e-d832283697e2@arm.com>

[-- Attachment #1: Type: text/plain, Size: 2878 bytes --]

Hi Will,

On 07/10/2019 15:37, Vincenzo Frascino wrote:
> On 07/10/2019 15:15, Will Deacon wrote:
>> On Mon, Oct 07, 2019 at 02:54:29PM +0100, Vincenzo Frascino wrote:
>>> On 07/10/2019 14:31, Will Deacon wrote:
>>>> On Thu, Oct 03, 2019 at 06:48:32PM +0100, Vincenzo Frascino wrote:
>>>>> This patch series is meant to address the various compilation issues
>>>>> reported recently for arm64 vdso32 [1].
>>>>>
>>>>> From v4, the series contains a cleanup of lib/vdso Kconfig as well since
>>>>> CROSS_COMPILE_COMPAT_VDSO is not required anymore by any architecture.
>>>>
>>>> I've queued this up as fixes for 5.4, but I ended up making quite a few
>>>> additional changes to address some other issues and minor inconsistencies
>>>> I ran into. In particular, with my changes, you can now easily build the
>>>> kernel with clang but the compat vDSO with gcc. The header files still need
>>>> sorting out properly, but I think this is a decent starting point:
>>>>
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/log/?h=for-next/fixes
>>>>
>>>> Please have a look.
>>>>
>>>
>>> Thank you for letting me know, I will have a look.
>>
>> Thanks.
>>
>>> I see acked-by Catalin on the patches, did you post them in review somewhere? I
>>> could not find them. Sorry
>>
>> I pushed them out to a temporary vdso branch on Friday and Catalin looked at
>> that. If you'd like me to post them as well, please let me know, although
>> I'm keen to get this stuff sorted out by -rc3 without disabling the compat
>> vDSO altogether (i.e. [1]). In other words, if you're ok with my changes on
>> top of yours then let's go for that, otherwise let's punt this to 5.5 and
>> try to fix the header mess at the same time.
>>
> 
> No need to repost them. I just got confused by the fact that they got acked and
> I could not find them anywhere, hence my question.
> 
> I am keen to sort this thing as well, my personal preference is to not disable
> compat vdso in 5.4.
> 
> I will download your tree, have a look at it and let you know my thoughts.
> 

I tested your patches and they look fine to me. I have just one request, in the
commit message of patch were you rename COMPATCC to CC_COMPAT could you please
add the make command with the update variable?

   $ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- \
        CROSS_COMPILE_COMPAT=arm-linux-gnueabihf- CC=clang \
        CC_COMPAT=arm-linux-gnueabihf-gcc

It took me a while to understand that the command in the commit message
(c71e88c43796 "arm64: vdso32: Don't use KBUILD_CPPFLAGS unconditionally") was
not working because of the renaming.

Thanks!

If it is not too late you can add my reviewed-by and tested-by ;)

>> Will
>>
>> [1] https://lkml.kernel.org/r/20190925130926.50674-1-catalin.marinas@arm.com
>>
> 

-- 
Regards,
Vincenzo

[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 14291 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel