* [PATCH] clk: rockchip: make clk_half_divider_ops static
@ 2019-10-17 10:53 Ben Dooks (Codethink)
2019-10-28 23:38 ` Stephen Boyd
2019-11-08 14:47 ` Heiko Stübner
0 siblings, 2 replies; 3+ messages in thread
From: Ben Dooks (Codethink) @ 2019-10-17 10:53 UTC (permalink / raw)
To: linux-kernel
Cc: Heiko Stuebner, Stephen Boyd, Michael Turquette, linux-rockchip,
Ben Dooks (Codethink),
linux-clk, linux-arm-kernel
The clk_half_divider_ops is not used outside or declared
outside of drivers/clk/rockchip/clk-half-divider.c so make
it static to avoid the following warning:
drivers/clk/rockchip/clk-half-divider.c:142:22: warning: symbol 'clk_half_divider_ops' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: linux-clk@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
---
drivers/clk/rockchip/clk-half-divider.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/clk/rockchip/clk-half-divider.c b/drivers/clk/rockchip/clk-half-divider.c
index ba9f00dc9740..b333fc28c94b 100644
--- a/drivers/clk/rockchip/clk-half-divider.c
+++ b/drivers/clk/rockchip/clk-half-divider.c
@@ -139,12 +139,11 @@ static int clk_half_divider_set_rate(struct clk_hw *hw, unsigned long rate,
return 0;
}
-const struct clk_ops clk_half_divider_ops = {
+static const struct clk_ops clk_half_divider_ops = {
.recalc_rate = clk_half_divider_recalc_rate,
.round_rate = clk_half_divider_round_rate,
.set_rate = clk_half_divider_set_rate,
};
-EXPORT_SYMBOL_GPL(clk_half_divider_ops);
/**
* Register a clock branch.
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: rockchip: make clk_half_divider_ops static
2019-10-17 10:53 [PATCH] clk: rockchip: make clk_half_divider_ops static Ben Dooks (Codethink)
@ 2019-10-28 23:38 ` Stephen Boyd
2019-11-08 14:47 ` Heiko Stübner
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2019-10-28 23:38 UTC (permalink / raw)
To: Ben Dooks, linux-kernel
Cc: Heiko Stuebner, Michael Turquette, linux-rockchip,
Ben Dooks (Codethink),
linux-clk, linux-arm-kernel
Quoting Ben Dooks (Codethink) (2019-10-17 03:53:48)
> The clk_half_divider_ops is not used outside or declared
> outside of drivers/clk/rockchip/clk-half-divider.c so make
> it static to avoid the following warning:
>
> drivers/clk/rockchip/clk-half-divider.c:142:22: warning: symbol 'clk_half_divider_ops' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: rockchip: make clk_half_divider_ops static
2019-10-17 10:53 [PATCH] clk: rockchip: make clk_half_divider_ops static Ben Dooks (Codethink)
2019-10-28 23:38 ` Stephen Boyd
@ 2019-11-08 14:47 ` Heiko Stübner
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stübner @ 2019-11-08 14:47 UTC (permalink / raw)
To: Ben Dooks (Codethink)
Cc: linux-kernel, Stephen Boyd, Michael Turquette, linux-rockchip,
linux-clk, linux-arm-kernel
Am Donnerstag, 17. Oktober 2019, 12:53:48 CET schrieb Ben Dooks (Codethink):
> The clk_half_divider_ops is not used outside or declared
> outside of drivers/clk/rockchip/clk-half-divider.c so make
> it static to avoid the following warning:
>
> drivers/clk/rockchip/clk-half-divider.c:142:22: warning: symbol 'clk_half_divider_ops' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
applied for 5.5
Thanks
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-08 14:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-17 10:53 [PATCH] clk: rockchip: make clk_half_divider_ops static Ben Dooks (Codethink)
2019-10-28 23:38 ` Stephen Boyd
2019-11-08 14:47 ` Heiko Stübner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).