* Re: [PATCH] arm64: defconfig: Enable Qualcomm remoteproc dependencies
2019-10-09 0:14 [PATCH] arm64: defconfig: Enable Qualcomm remoteproc dependencies Bjorn Andersson
@ 2019-10-10 13:07 ` Alex Elder
2019-10-16 5:58 ` Vinod Koul
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Alex Elder @ 2019-10-10 13:07 UTC (permalink / raw)
To: Bjorn Andersson, Catalin Marinas, Will Deacon, Shawn Guo,
Olof Johansson, Maxime Ripard, Arnd Bergmann, Jagan Teki,
Anson Huang, Leonard Crestez, Dinh Nguyen, Marcin Juszkiewicz
Cc: linux-arm-msm, linux-kernel, linux-arm-kernel
On 10/8/19 7:14 PM, Bjorn Andersson wrote:
> Enable the the power domains, reset controllers and remote block device
> memory access drivers necessary to boot the Audio, Compute and Modem
> DSPs on Qualcomm SDM845.
>
> None of the power domains are system critical, but needs to be builtin
> as the driver core prohibits probe deferal past late initcall.
I asked Bjorn privately about the need for these to be built in,
and he clarified:
> However, Rob Herring introduced a nice feature last year that means that
> if you request a power-domain from a driver that has not yet probed at
> late_initcall that request will fail instead of returning EPROBE_DEFER.
> So compiling these as modules will, based on kernel module load order,
> cause intermittent failures to probe the consumer drivers.
So that's what "the driver core prohibits probe deferral past late
initcall" means, and better explains the issue that requires some of
these to be built-in rather than be built as kernel modules.
I was able to test with and without this applied, and I find that without
the patch the modem won't boot, and it boots successfully when used.
Tested-by: Alex Elder <elder@linaro.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> arch/arm64/configs/defconfig | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index c9a867ac32d4..42f042ba1039 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -732,10 +732,13 @@ CONFIG_RPMSG_QCOM_GLINK_SMEM=m
> CONFIG_RPMSG_QCOM_SMD=y
> CONFIG_RASPBERRYPI_POWER=y
> CONFIG_IMX_SCU_SOC=y
> +CONFIG_QCOM_AOSS_QMP=y
> CONFIG_QCOM_COMMAND_DB=y
> CONFIG_QCOM_GENI_SE=y
> CONFIG_QCOM_GLINK_SSR=m
> +CONFIG_QCOM_RMTFS_MEM=m
> CONFIG_QCOM_RPMH=y
> +CONFIG_QCOM_RPMHPD=y
> CONFIG_QCOM_SMEM=y
> CONFIG_QCOM_SMD_RPM=y
> CONFIG_QCOM_SMP2P=y
> @@ -780,6 +783,8 @@ CONFIG_PWM_ROCKCHIP=y
> CONFIG_PWM_SAMSUNG=y
> CONFIG_PWM_SUN4I=m
> CONFIG_PWM_TEGRA=m
> +CONFIG_RESET_QCOM_AOSS=y
> +CONFIG_RESET_QCOM_PDC=m
> CONFIG_RESET_TI_SCI=y
> CONFIG_PHY_XGENE=y
> CONFIG_PHY_SUN4I_USB=y
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: defconfig: Enable Qualcomm remoteproc dependencies
2019-10-09 0:14 [PATCH] arm64: defconfig: Enable Qualcomm remoteproc dependencies Bjorn Andersson
2019-10-10 13:07 ` Alex Elder
@ 2019-10-16 5:58 ` Vinod Koul
2019-10-16 6:03 ` Bjorn Andersson
2019-10-18 10:38 ` Sibi Sankar
3 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2019-10-16 5:58 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Anson Huang, Arnd Bergmann, Catalin Marinas, Alex Elder,
linux-kernel, Maxime Ripard, Marcin Juszkiewicz, Dinh Nguyen,
Jagan Teki, linux-arm-msm, Olof Johansson, Shawn Guo,
Leonard Crestez, Will Deacon, linux-arm-kernel
On 08-10-19, 17:14, Bjorn Andersson wrote:
> Enable the the power domains, reset controllers and remote block device
> memory access drivers necessary to boot the Audio, Compute and Modem
> DSPs on Qualcomm SDM845.
>
> None of the power domains are system critical, but needs to be builtin
> as the driver core prohibits probe deferal past late initcall.
Reviewed-by: Vinod Koul <vkoul@kernel.org>
Tested-by: Vinod Koul <vkoul@kernel.org>
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> arch/arm64/configs/defconfig | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index c9a867ac32d4..42f042ba1039 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -732,10 +732,13 @@ CONFIG_RPMSG_QCOM_GLINK_SMEM=m
> CONFIG_RPMSG_QCOM_SMD=y
> CONFIG_RASPBERRYPI_POWER=y
> CONFIG_IMX_SCU_SOC=y
> +CONFIG_QCOM_AOSS_QMP=y
> CONFIG_QCOM_COMMAND_DB=y
> CONFIG_QCOM_GENI_SE=y
> CONFIG_QCOM_GLINK_SSR=m
> +CONFIG_QCOM_RMTFS_MEM=m
> CONFIG_QCOM_RPMH=y
> +CONFIG_QCOM_RPMHPD=y
> CONFIG_QCOM_SMEM=y
> CONFIG_QCOM_SMD_RPM=y
> CONFIG_QCOM_SMP2P=y
> @@ -780,6 +783,8 @@ CONFIG_PWM_ROCKCHIP=y
> CONFIG_PWM_SAMSUNG=y
> CONFIG_PWM_SUN4I=m
> CONFIG_PWM_TEGRA=m
> +CONFIG_RESET_QCOM_AOSS=y
> +CONFIG_RESET_QCOM_PDC=m
> CONFIG_RESET_TI_SCI=y
> CONFIG_PHY_XGENE=y
> CONFIG_PHY_SUN4I_USB=y
> --
> 2.18.0
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: defconfig: Enable Qualcomm remoteproc dependencies
2019-10-09 0:14 [PATCH] arm64: defconfig: Enable Qualcomm remoteproc dependencies Bjorn Andersson
2019-10-10 13:07 ` Alex Elder
2019-10-16 5:58 ` Vinod Koul
@ 2019-10-16 6:03 ` Bjorn Andersson
2019-10-18 10:38 ` Sibi Sankar
3 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2019-10-16 6:03 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon, Shawn Guo, Olof Johansson,
Maxime Ripard, Arnd Bergmann, Jagan Teki, Anson Huang,
Leonard Crestez, Dinh Nguyen, Marcin Juszkiewicz
Cc: linux-arm-msm, linux-kernel, linux-arm-kernel, Alex Elder
On Tue 08 Oct 17:14 PDT 2019, Bjorn Andersson wrote:
> Enable the the power domains, reset controllers and remote block device
> memory access drivers necessary to boot the Audio, Compute and Modem
> DSPs on Qualcomm SDM845.
>
> None of the power domains are system critical, but needs to be builtin
> as the driver core prohibits probe deferal past late initcall.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Thanks Alex & Vinod!
Applied.
> ---
> arch/arm64/configs/defconfig | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index c9a867ac32d4..42f042ba1039 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -732,10 +732,13 @@ CONFIG_RPMSG_QCOM_GLINK_SMEM=m
> CONFIG_RPMSG_QCOM_SMD=y
> CONFIG_RASPBERRYPI_POWER=y
> CONFIG_IMX_SCU_SOC=y
> +CONFIG_QCOM_AOSS_QMP=y
> CONFIG_QCOM_COMMAND_DB=y
> CONFIG_QCOM_GENI_SE=y
> CONFIG_QCOM_GLINK_SSR=m
> +CONFIG_QCOM_RMTFS_MEM=m
> CONFIG_QCOM_RPMH=y
> +CONFIG_QCOM_RPMHPD=y
> CONFIG_QCOM_SMEM=y
> CONFIG_QCOM_SMD_RPM=y
> CONFIG_QCOM_SMP2P=y
> @@ -780,6 +783,8 @@ CONFIG_PWM_ROCKCHIP=y
> CONFIG_PWM_SAMSUNG=y
> CONFIG_PWM_SUN4I=m
> CONFIG_PWM_TEGRA=m
> +CONFIG_RESET_QCOM_AOSS=y
> +CONFIG_RESET_QCOM_PDC=m
> CONFIG_RESET_TI_SCI=y
> CONFIG_PHY_XGENE=y
> CONFIG_PHY_SUN4I_USB=y
> --
> 2.18.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: defconfig: Enable Qualcomm remoteproc dependencies
2019-10-09 0:14 [PATCH] arm64: defconfig: Enable Qualcomm remoteproc dependencies Bjorn Andersson
` (2 preceding siblings ...)
2019-10-16 6:03 ` Bjorn Andersson
@ 2019-10-18 10:38 ` Sibi Sankar
2019-10-18 16:53 ` Bjorn Andersson
3 siblings, 1 reply; 6+ messages in thread
From: Sibi Sankar @ 2019-10-18 10:38 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-kernel-owner, Anson Huang, Arnd Bergmann, Catalin Marinas,
Alex Elder, linux-kernel, Maxime Ripard, Marcin Juszkiewicz,
Dinh Nguyen, Jagan Teki, linux-arm-msm, Olof Johansson,
Shawn Guo, Leonard Crestez, Will Deacon, linux-arm-kernel
On 2019-10-09 05:44, Bjorn Andersson wrote:
> Enable the the power domains, reset controllers and remote block device
> memory access drivers necessary to boot the Audio, Compute and Modem
> DSPs on Qualcomm SDM845.
>
> None of the power domains are system critical, but needs to be builtin
> as the driver core prohibits probe deferal past late initcall.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Sibi Sankar <sibis@codeaurora.org>
> ---
> arch/arm64/configs/defconfig | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig
> b/arch/arm64/configs/defconfig
> index c9a867ac32d4..42f042ba1039 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -732,10 +732,13 @@ CONFIG_RPMSG_QCOM_GLINK_SMEM=m
> CONFIG_RPMSG_QCOM_SMD=y
> CONFIG_RASPBERRYPI_POWER=y
> CONFIG_IMX_SCU_SOC=y
> +CONFIG_QCOM_AOSS_QMP=y
> CONFIG_QCOM_COMMAND_DB=y
> CONFIG_QCOM_GENI_SE=y
> CONFIG_QCOM_GLINK_SSR=m
> +CONFIG_QCOM_RMTFS_MEM=m
> CONFIG_QCOM_RPMH=y
> +CONFIG_QCOM_RPMHPD=y
> CONFIG_QCOM_SMEM=y
> CONFIG_QCOM_SMD_RPM=y
> CONFIG_QCOM_SMP2P=y
> @@ -780,6 +783,8 @@ CONFIG_PWM_ROCKCHIP=y
> CONFIG_PWM_SAMSUNG=y
> CONFIG_PWM_SUN4I=m
> CONFIG_PWM_TEGRA=m
> +CONFIG_RESET_QCOM_AOSS=y
I should probably fix this ^^
> +CONFIG_RESET_QCOM_PDC=m
> CONFIG_RESET_TI_SCI=y
> CONFIG_PHY_XGENE=y
> CONFIG_PHY_SUN4I_USB=y
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: defconfig: Enable Qualcomm remoteproc dependencies
2019-10-18 10:38 ` Sibi Sankar
@ 2019-10-18 16:53 ` Bjorn Andersson
0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2019-10-18 16:53 UTC (permalink / raw)
To: Sibi Sankar
Cc: linux-kernel-owner, Anson Huang, Arnd Bergmann, Catalin Marinas,
Alex Elder, linux-kernel, Maxime Ripard, Marcin Juszkiewicz,
Dinh Nguyen, Jagan Teki, linux-arm-msm, Olof Johansson,
Shawn Guo, Leonard Crestez, Will Deacon, linux-arm-kernel
On Fri 18 Oct 03:38 PDT 2019, Sibi Sankar wrote:
> On 2019-10-09 05:44, Bjorn Andersson wrote:
[..]
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
[..]
> > @@ -780,6 +783,8 @@ CONFIG_PWM_ROCKCHIP=y
> > CONFIG_PWM_SAMSUNG=y
> > CONFIG_PWM_SUN4I=m
> > CONFIG_PWM_TEGRA=m
> > +CONFIG_RESET_QCOM_AOSS=y
>
> I should probably fix this ^^
>
Please do, afaict this driver should be tristate.
Regards,
Bjorn
> > +CONFIG_RESET_QCOM_PDC=m
> > CONFIG_RESET_TI_SCI=y
> > CONFIG_PHY_XGENE=y
> > CONFIG_PHY_SUN4I_USB=y
>
> --
> -- Sibi Sankar --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread