* [PATCH 1/3] ARM: dts: imx6qdl-zii-rdu2: Drop GPIO_ACTIVE_LOW form reg_5p0v_user_usb
@ 2019-10-22 4:04 Andrey Smirnov
2019-10-22 4:04 ` [PATCH 2/3] ARM: dts: imx6qdl-zii-rdu2: Fix accelerometer interrupt-names Andrey Smirnov
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Andrey Smirnov @ 2019-10-22 4:04 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Andrey Smirnov, Fabio Estevam, linux-kernel, Shawn Guo,
Chris Healy, Lucas Stach
Drop GPIO_ACTIVE_LOW form reg_5p0v_user_usb since it is ignored by the
gpiolib and results in a warning.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Chris Healy <cphealy@gmail.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
Cc: linux-kernel@vger.kernel.org
---
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
index 93be00a60c88..8d46f7b2722b 100644
--- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
@@ -68,7 +68,7 @@
regulator-name = "5V_USER_USB";
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
- gpio = <&gpio3 22 GPIO_ACTIVE_LOW>;
+ gpio = <&gpio3 22 0>;
startup-delay-us = <1000>;
};
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/3] ARM: dts: imx6qdl-zii-rdu2: Fix accelerometer interrupt-names
2019-10-22 4:04 [PATCH 1/3] ARM: dts: imx6qdl-zii-rdu2: Drop GPIO_ACTIVE_LOW form reg_5p0v_user_usb Andrey Smirnov
@ 2019-10-22 4:04 ` Andrey Smirnov
2019-10-22 16:04 ` Lucas Stach
2019-10-28 6:20 ` Shawn Guo
2019-10-22 4:05 ` [PATCH 3/3] ARM: dts: imx6qdl-zii-rdu2: Specify supplies for accelerometer Andrey Smirnov
2019-10-22 16:01 ` [PATCH 1/3] ARM: dts: imx6qdl-zii-rdu2: Drop GPIO_ACTIVE_LOW form reg_5p0v_user_usb Lucas Stach
2 siblings, 2 replies; 8+ messages in thread
From: Andrey Smirnov @ 2019-10-22 4:04 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Andrey Smirnov, Fabio Estevam, linux-kernel, Shawn Guo,
Chris Healy, Lucas Stach
According to Documentation/devicetree/bindings/iio/accel/mma8452.txt,
the correct interrupt-names are "INT1" and "INT2", so fix them
accordingly.
While at it, modify the node to only specify "INT2" since providing
two interrupts is not necessary or useful (the driver will only use
one).
Signed-off-by: Fabio Estevam <festevam@gmail.com>
[andrew.smirnov@gmail.com modified the patch to drop INT1]
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Chris Healy <cphealy@gmail.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
Cc: linux-kernel@vger.kernel.org
---
Original patch from Fabio can be seen here:
https://lore.kernel.org/linux-arm-kernel/20191010125300.2822-1-festevam@gmail.com/
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
index 8d46f7b2722b..a8c86e621b49 100644
--- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
@@ -358,8 +358,8 @@
compatible = "fsl,mma8451";
reg = <0x1c>;
interrupt-parent = <&gpio1>;
- interrupt-names = "int1", "int2";
- interrupts = <18 IRQ_TYPE_LEVEL_LOW>, <20 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-names = "INT2";
+ interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
};
hpa2: amp@60 {
@@ -849,7 +849,6 @@
&iomuxc {
pinctrl_accel: accelgrp {
fsl,pins = <
- MX6QDL_PAD_SD1_CMD__GPIO1_IO18 0x4001b000
MX6QDL_PAD_SD1_CLK__GPIO1_IO20 0x4001b000
>;
};
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/3] ARM: dts: imx6qdl-zii-rdu2: Specify supplies for accelerometer
2019-10-22 4:04 [PATCH 1/3] ARM: dts: imx6qdl-zii-rdu2: Drop GPIO_ACTIVE_LOW form reg_5p0v_user_usb Andrey Smirnov
2019-10-22 4:04 ` [PATCH 2/3] ARM: dts: imx6qdl-zii-rdu2: Fix accelerometer interrupt-names Andrey Smirnov
@ 2019-10-22 4:05 ` Andrey Smirnov
2019-10-22 16:03 ` Lucas Stach
2019-10-28 6:20 ` Shawn Guo
2019-10-22 16:01 ` [PATCH 1/3] ARM: dts: imx6qdl-zii-rdu2: Drop GPIO_ACTIVE_LOW form reg_5p0v_user_usb Lucas Stach
2 siblings, 2 replies; 8+ messages in thread
From: Andrey Smirnov @ 2019-10-22 4:05 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Andrey Smirnov, Fabio Estevam, linux-kernel, Shawn Guo,
Chris Healy, Lucas Stach
Specify 'vdd' and 'vddio' supplies for accelerometer to avoid warnings
during boot.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Chris Healy <cphealy@gmail.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
Cc: linux-kernel@vger.kernel.org
---
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
index a8c86e621b49..42c0a728216d 100644
--- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
@@ -360,6 +360,8 @@
interrupt-parent = <&gpio1>;
interrupt-names = "INT2";
interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
+ vdd-supply = <®_3p3v>;
+ vddio-supply = <®_3p3v>;
};
hpa2: amp@60 {
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] ARM: dts: imx6qdl-zii-rdu2: Drop GPIO_ACTIVE_LOW form reg_5p0v_user_usb
2019-10-22 4:04 [PATCH 1/3] ARM: dts: imx6qdl-zii-rdu2: Drop GPIO_ACTIVE_LOW form reg_5p0v_user_usb Andrey Smirnov
2019-10-22 4:04 ` [PATCH 2/3] ARM: dts: imx6qdl-zii-rdu2: Fix accelerometer interrupt-names Andrey Smirnov
2019-10-22 4:05 ` [PATCH 3/3] ARM: dts: imx6qdl-zii-rdu2: Specify supplies for accelerometer Andrey Smirnov
@ 2019-10-22 16:01 ` Lucas Stach
2 siblings, 0 replies; 8+ messages in thread
From: Lucas Stach @ 2019-10-22 16:01 UTC (permalink / raw)
To: Andrey Smirnov, linux-arm-kernel
Cc: Shawn Guo, Fabio Estevam, linux-kernel, Chris Healy
Am Montag, den 21.10.2019, 21:04 -0700 schrieb Andrey Smirnov:
> Drop GPIO_ACTIVE_LOW form reg_5p0v_user_usb since it is ignored by the
> gpiolib and results in a warning.
NACK. This is consistent with the regulator binding behavior and a fix
to gpiolib has been accepted to not print a warning in this case.
Regards,
Lucas
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org,
> Cc: linux-kernel@vger.kernel.org
> ---
> arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> index 93be00a60c88..8d46f7b2722b 100644
> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> @@ -68,7 +68,7 @@
> regulator-name = "5V_USER_USB";
> regulator-min-microvolt = <5000000>;
> regulator-max-microvolt = <5000000>;
> - gpio = <&gpio3 22 GPIO_ACTIVE_LOW>;
> + gpio = <&gpio3 22 0>;
> startup-delay-us = <1000>;
> };
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] ARM: dts: imx6qdl-zii-rdu2: Specify supplies for accelerometer
2019-10-22 4:05 ` [PATCH 3/3] ARM: dts: imx6qdl-zii-rdu2: Specify supplies for accelerometer Andrey Smirnov
@ 2019-10-22 16:03 ` Lucas Stach
2019-10-28 6:20 ` Shawn Guo
1 sibling, 0 replies; 8+ messages in thread
From: Lucas Stach @ 2019-10-22 16:03 UTC (permalink / raw)
To: Andrey Smirnov, linux-arm-kernel
Cc: Shawn Guo, Fabio Estevam, linux-kernel, Chris Healy
Am Montag, den 21.10.2019, 21:05 -0700 schrieb Andrey Smirnov:
> Specify 'vdd' and 'vddio' supplies for accelerometer to avoid warnings
> during boot.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org,
> Cc: linux-kernel@vger.kernel.org
> ---
> arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> index a8c86e621b49..42c0a728216d 100644
> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> @@ -360,6 +360,8 @@
> interrupt-parent = <&gpio1>;
> interrupt-names = "INT2";
> interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
> + vdd-supply = <®_3p3v>;
> + vddio-supply = <®_3p3v>;
> };
>
> hpa2: amp@60 {
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] ARM: dts: imx6qdl-zii-rdu2: Fix accelerometer interrupt-names
2019-10-22 4:04 ` [PATCH 2/3] ARM: dts: imx6qdl-zii-rdu2: Fix accelerometer interrupt-names Andrey Smirnov
@ 2019-10-22 16:04 ` Lucas Stach
2019-10-28 6:20 ` Shawn Guo
1 sibling, 0 replies; 8+ messages in thread
From: Lucas Stach @ 2019-10-22 16:04 UTC (permalink / raw)
To: Andrey Smirnov, linux-arm-kernel
Cc: Shawn Guo, Fabio Estevam, linux-kernel, Chris Healy
Am Montag, den 21.10.2019, 21:04 -0700 schrieb Andrey Smirnov:
> According to Documentation/devicetree/bindings/iio/accel/mma8452.txt,
> the correct interrupt-names are "INT1" and "INT2", so fix them
> accordingly.
>
> While at it, modify the node to only specify "INT2" since providing
> two interrupts is not necessary or useful (the driver will only use
> one).
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> [andrew.smirnov@gmail.com modified the patch to drop INT1]
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org,
> Cc: linux-kernel@vger.kernel.org
> ---
>
> Original patch from Fabio can be seen here:
>
> https://lore.kernel.org/linux-arm-kernel/20191010125300.2822-1-festevam@gmail.com/
>
> arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> index 8d46f7b2722b..a8c86e621b49 100644
> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> @@ -358,8 +358,8 @@
> compatible = "fsl,mma8451";
> reg = <0x1c>;
> interrupt-parent = <&gpio1>;
> - interrupt-names = "int1", "int2";
> - interrupts = <18 IRQ_TYPE_LEVEL_LOW>, <20 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-names = "INT2";
> + interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
> };
>
> hpa2: amp@60 {
> @@ -849,7 +849,6 @@
> &iomuxc {
> pinctrl_accel: accelgrp {
> fsl,pins = <
> - MX6QDL_PAD_SD1_CMD__GPIO1_IO18 0x4001b000
> MX6QDL_PAD_SD1_CLK__GPIO1_IO20 0x4001b000
> >;
> };
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] ARM: dts: imx6qdl-zii-rdu2: Fix accelerometer interrupt-names
2019-10-22 4:04 ` [PATCH 2/3] ARM: dts: imx6qdl-zii-rdu2: Fix accelerometer interrupt-names Andrey Smirnov
2019-10-22 16:04 ` Lucas Stach
@ 2019-10-28 6:20 ` Shawn Guo
1 sibling, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2019-10-28 6:20 UTC (permalink / raw)
To: Andrey Smirnov
Cc: linux-kernel, Fabio Estevam, Chris Healy, linux-arm-kernel, Lucas Stach
On Mon, Oct 21, 2019 at 09:04:59PM -0700, Andrey Smirnov wrote:
> According to Documentation/devicetree/bindings/iio/accel/mma8452.txt,
> the correct interrupt-names are "INT1" and "INT2", so fix them
> accordingly.
>
> While at it, modify the node to only specify "INT2" since providing
> two interrupts is not necessary or useful (the driver will only use
> one).
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> [andrew.smirnov@gmail.com modified the patch to drop INT1]
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org,
> Cc: linux-kernel@vger.kernel.org
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] ARM: dts: imx6qdl-zii-rdu2: Specify supplies for accelerometer
2019-10-22 4:05 ` [PATCH 3/3] ARM: dts: imx6qdl-zii-rdu2: Specify supplies for accelerometer Andrey Smirnov
2019-10-22 16:03 ` Lucas Stach
@ 2019-10-28 6:20 ` Shawn Guo
1 sibling, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2019-10-28 6:20 UTC (permalink / raw)
To: Andrey Smirnov
Cc: linux-kernel, Fabio Estevam, Chris Healy, linux-arm-kernel, Lucas Stach
On Mon, Oct 21, 2019 at 09:05:00PM -0700, Andrey Smirnov wrote:
> Specify 'vdd' and 'vddio' supplies for accelerometer to avoid warnings
> during boot.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org,
> Cc: linux-kernel@vger.kernel.org
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-10-28 6:21 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-22 4:04 [PATCH 1/3] ARM: dts: imx6qdl-zii-rdu2: Drop GPIO_ACTIVE_LOW form reg_5p0v_user_usb Andrey Smirnov
2019-10-22 4:04 ` [PATCH 2/3] ARM: dts: imx6qdl-zii-rdu2: Fix accelerometer interrupt-names Andrey Smirnov
2019-10-22 16:04 ` Lucas Stach
2019-10-28 6:20 ` Shawn Guo
2019-10-22 4:05 ` [PATCH 3/3] ARM: dts: imx6qdl-zii-rdu2: Specify supplies for accelerometer Andrey Smirnov
2019-10-22 16:03 ` Lucas Stach
2019-10-28 6:20 ` Shawn Guo
2019-10-22 16:01 ` [PATCH 1/3] ARM: dts: imx6qdl-zii-rdu2: Drop GPIO_ACTIVE_LOW form reg_5p0v_user_usb Lucas Stach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).