* [PATCH v2] dts: Disable DMA support on the BK4 vf610 device's fsl_lpuart driver
@ 2019-10-10 9:08 Lukasz Majewski
2019-10-25 8:55 ` Shawn Guo
0 siblings, 1 reply; 3+ messages in thread
From: Lukasz Majewski @ 2019-10-10 9:08 UTC (permalink / raw)
To: linux-kernel, Shawn Guo
Cc: Mark Rutland, devicetree, Sascha Hauer, Lukasz Majewski,
Stefan Agner, Rob Herring, Pengutronix Kernel Team, Robin Murphy,
linux-arm-kernel
This change disables the DMA support (RX/TX) on the NXP's fsl_lpuart
driver - the PIO mode is used instead. This change is necessary for better
robustness of BK4's device use cases with many potentially interrupted
short serial transfers.
Without it the driver hangs when some distortion happens on UART lines.
Signed-off-by: Lukasz Majewski <lukma@denx.de>
Suggested-by: Robin Murphy <robin.murphy@arm.com>
---
Changes for v2:
- Use /delete-property/dma-names; instead of dma-names = "","";
---
arch/arm/boot/dts/vf610-bk4.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/vf610-bk4.dts b/arch/arm/boot/dts/vf610-bk4.dts
index 0f3870d3b099..830c85476b3d 100644
--- a/arch/arm/boot/dts/vf610-bk4.dts
+++ b/arch/arm/boot/dts/vf610-bk4.dts
@@ -259,24 +259,28 @@
&uart0 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart0>;
+ /delete-property/dma-names;
status = "okay";
};
&uart1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart1>;
+ /delete-property/dma-names;
status = "okay";
};
&uart2 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart2>;
+ /delete-property/dma-names;
status = "okay";
};
&uart3 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart3>;
+ /delete-property/dma-names;
status = "okay";
};
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dts: Disable DMA support on the BK4 vf610 device's fsl_lpuart driver
2019-10-10 9:08 [PATCH v2] dts: Disable DMA support on the BK4 vf610 device's fsl_lpuart driver Lukasz Majewski
@ 2019-10-25 8:55 ` Shawn Guo
2019-10-25 10:00 ` Lukasz Majewski
0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2019-10-25 8:55 UTC (permalink / raw)
To: Lukasz Majewski
Cc: Mark Rutland, devicetree, Sascha Hauer, linux-kernel,
Stefan Agner, Rob Herring, Pengutronix Kernel Team, Robin Murphy,
linux-arm-kernel
On Thu, Oct 10, 2019 at 11:08:02AM +0200, Lukasz Majewski wrote:
> This change disables the DMA support (RX/TX) on the NXP's fsl_lpuart
> driver - the PIO mode is used instead. This change is necessary for better
> robustness of BK4's device use cases with many potentially interrupted
> short serial transfers.
>
> Without it the driver hangs when some distortion happens on UART lines.
>
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> Suggested-by: Robin Murphy <robin.murphy@arm.com>
Subject prefix should be 'ARM: dts: ...'. I fixed it up and applied the
patch.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dts: Disable DMA support on the BK4 vf610 device's fsl_lpuart driver
2019-10-25 8:55 ` Shawn Guo
@ 2019-10-25 10:00 ` Lukasz Majewski
0 siblings, 0 replies; 3+ messages in thread
From: Lukasz Majewski @ 2019-10-25 10:00 UTC (permalink / raw)
To: Shawn Guo
Cc: Mark Rutland, devicetree, Sascha Hauer, linux-kernel,
Stefan Agner, Rob Herring, Pengutronix Kernel Team, Robin Murphy,
linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 922 bytes --]
Hi Shawn,
> On Thu, Oct 10, 2019 at 11:08:02AM +0200, Lukasz Majewski wrote:
> > This change disables the DMA support (RX/TX) on the NXP's fsl_lpuart
> > driver - the PIO mode is used instead. This change is necessary for
> > better robustness of BK4's device use cases with many potentially
> > interrupted short serial transfers.
> >
> > Without it the driver hangs when some distortion happens on UART
> > lines.
> >
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > Suggested-by: Robin Murphy <robin.murphy@arm.com>
>
> Subject prefix should be 'ARM: dts: ...'. I fixed it up and applied
> the patch.
>
> Shawn
Thanks :-)
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-25 10:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-10 9:08 [PATCH v2] dts: Disable DMA support on the BK4 vf610 device's fsl_lpuart driver Lukasz Majewski
2019-10-25 8:55 ` Shawn Guo
2019-10-25 10:00 ` Lukasz Majewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).