* [PATCH] arm64: dts: zii-ultra: add i210 ethernet node
@ 2019-10-21 16:42 Lucas Stach
2019-10-28 6:15 ` Shawn Guo
0 siblings, 1 reply; 4+ messages in thread
From: Lucas Stach @ 2019-10-21 16:42 UTC (permalink / raw)
To: Shawn Guo; +Cc: Fabio Estevam, kernel, linux-arm-kernel, patchwork-lst
Used by the bootloader to patch in the correct MAC address for
the ethernet adapter.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
index 087b5b6ebe89..7933c685fe6a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
@@ -475,6 +475,17 @@
<&pcie1_refclk>;
clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus";
status = "okay";
+
+ host@0 {
+ reg = <0 0 0 0 0>;
+
+ #address-cells = <3>;
+ #size-cells = <2>;
+
+ i210: i210@0 {
+ reg = <0 0 0 0 0>;
+ };
+ };
};
&pgc_gpu {
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: zii-ultra: add i210 ethernet node
2019-10-21 16:42 [PATCH] arm64: dts: zii-ultra: add i210 ethernet node Lucas Stach
@ 2019-10-28 6:15 ` Shawn Guo
2019-10-30 16:44 ` Lucas Stach
0 siblings, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2019-10-28 6:15 UTC (permalink / raw)
To: Lucas Stach; +Cc: Fabio Estevam, kernel, linux-arm-kernel, patchwork-lst
On Mon, Oct 21, 2019 at 06:42:00PM +0200, Lucas Stach wrote:
> Used by the bootloader to patch in the correct MAC address for
> the ethernet adapter.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> index 087b5b6ebe89..7933c685fe6a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> @@ -475,6 +475,17 @@
> <&pcie1_refclk>;
> clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus";
> status = "okay";
> +
> + host@0 {
Where is the bindings documenting this child node of pcie device?
> + reg = <0 0 0 0 0>;
> +
> + #address-cells = <3>;
> + #size-cells = <2>;
> +
> + i210: i210@0 {
Can we have generic node name for it?
Shawn
> + reg = <0 0 0 0 0>;
> + };
> + };
> };
>
> &pgc_gpu {
> --
> 2.20.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: zii-ultra: add i210 ethernet node
2019-10-28 6:15 ` Shawn Guo
@ 2019-10-30 16:44 ` Lucas Stach
2019-11-04 1:04 ` Shawn Guo
0 siblings, 1 reply; 4+ messages in thread
From: Lucas Stach @ 2019-10-30 16:44 UTC (permalink / raw)
To: Shawn Guo; +Cc: Fabio Estevam, linux-arm-kernel, kernel, patchwork-lst
On Mo, 2019-10-28 at 14:15 +0800, Shawn Guo wrote:
> On Mon, Oct 21, 2019 at 06:42:00PM +0200, Lucas Stach wrote:
> > Used by the bootloader to patch in the correct MAC address for
> > the ethernet adapter.
> >
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 11
> > +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > index 087b5b6ebe89..7933c685fe6a 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > @@ -475,6 +475,17 @@
> > <&pcie1_refclk>;
> > clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus";
> > status = "okay";
> > +
> > + host@0 {
>
> Where is the bindings documenting this child node of pcie device?
This is part of the "PCI Bus Binding to: IEEE Std 1275-1994" document,
which is referenced in Documentation/devicetree/bindings/pci/pci.txt.
This is a standard PCIe topology description mapped to DT.
> > + reg = <0 0 0 0 0>;
> > +
> > + #address-cells = <3>;
> > + #size-cells = <2>;
> > +
> > + i210: i210@0 {
>
> Can we have generic node name for it?
I would like to avoid this if possible. We are sharing the code to
patch in the MAC address from the bootloader with the RDU2, which has
the same node name and the patching code looks for the specific name.
Regards,
Lucas
> Shawn
>
> > + reg = <0 0 0 0 0>;
> > + };
> > + };
> > };
> >
> > &pgc_gpu {
> > --
> > 2.20.1
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: zii-ultra: add i210 ethernet node
2019-10-30 16:44 ` Lucas Stach
@ 2019-11-04 1:04 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2019-11-04 1:04 UTC (permalink / raw)
To: Lucas Stach; +Cc: Fabio Estevam, linux-arm-kernel, kernel, patchwork-lst
On Wed, Oct 30, 2019 at 05:44:27PM +0100, Lucas Stach wrote:
> On Mo, 2019-10-28 at 14:15 +0800, Shawn Guo wrote:
> > On Mon, Oct 21, 2019 at 06:42:00PM +0200, Lucas Stach wrote:
> > > Used by the bootloader to patch in the correct MAC address for
> > > the ethernet adapter.
> > >
> > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > > ---
> > > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 11
> > > +++++++++++
> > > 1 file changed, 11 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > > b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > > index 087b5b6ebe89..7933c685fe6a 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > > @@ -475,6 +475,17 @@
> > > <&pcie1_refclk>;
> > > clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus";
> > > status = "okay";
> > > +
> > > + host@0 {
> >
> > Where is the bindings documenting this child node of pcie device?
>
> This is part of the "PCI Bus Binding to: IEEE Std 1275-1994" document,
> which is referenced in Documentation/devicetree/bindings/pci/pci.txt.
> This is a standard PCIe topology description mapped to DT.
Please resend the patch to include DT and PCI folks and list.
Shawn
>
> > > + reg = <0 0 0 0 0>;
> > > +
> > > + #address-cells = <3>;
> > > + #size-cells = <2>;
> > > +
> > > + i210: i210@0 {
> >
> > Can we have generic node name for it?
>
> I would like to avoid this if possible. We are sharing the code to
> patch in the MAC address from the bootloader with the RDU2, which has
> the same node name and the patching code looks for the specific name.
>
> Regards,
> Lucas
>
> > Shawn
> >
> > > + reg = <0 0 0 0 0>;
> > > + };
> > > + };
> > > };
> > >
> > > &pgc_gpu {
> > > --
> > > 2.20.1
> > >
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-04 1:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-21 16:42 [PATCH] arm64: dts: zii-ultra: add i210 ethernet node Lucas Stach
2019-10-28 6:15 ` Shawn Guo
2019-10-30 16:44 ` Lucas Stach
2019-11-04 1:04 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).