Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ARM: dts: e60k02: Pass the memory unit address
@ 2019-11-08 14:39 Fabio Estevam
  2019-11-09  9:19 ` Andreas Kemnade
  0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2019-11-08 14:39 UTC (permalink / raw)
  To: shawnguo; +Cc: andreas, Fabio Estevam, linux-arm-kernel

The following build warning is seen with W=1: 

  DTC     arch/arm/boot/dts/imx6sll-kobo-clarahd.dtb
arch/arm/boot/dts/e60k02.dtsi:51.9-53.4: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name

Pass the memory unit address to fix the problem.

While at it, also pass 'device_type = "memory"', which is recommended
for memory nodes.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 arch/arm/boot/dts/e60k02.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/e60k02.dtsi b/arch/arm/boot/dts/e60k02.dtsi
index 6472b056a001..a9433c8432a6 100644
--- a/arch/arm/boot/dts/e60k02.dtsi
+++ b/arch/arm/boot/dts/e60k02.dtsi
@@ -48,7 +48,8 @@
 		};
 	};
 
-	memory {
+	memory@80000000 {
+		device_type = "memory";
 		reg = <0x80000000 0x20000000>;
 	};
 
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: e60k02: Pass the memory unit address
  2019-11-08 14:39 [PATCH] ARM: dts: e60k02: Pass the memory unit address Fabio Estevam
@ 2019-11-09  9:19 ` Andreas Kemnade
  0 siblings, 0 replies; 2+ messages in thread
From: Andreas Kemnade @ 2019-11-09  9:19 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: shawnguo, linux-arm-kernel

On Fri,  8 Nov 2019 11:39:36 -0300
Fabio Estevam <festevam@gmail.com> wrote:

> The following build warning is seen with W=1: 
> 
>   DTC     arch/arm/boot/dts/imx6sll-kobo-clarahd.dtb
> arch/arm/boot/dts/e60k02.dtsi:51.9-53.4: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name
> 
> Pass the memory unit address to fix the problem.
> 
> While at it, also pass 'device_type = "memory"', which is recommended
> for memory nodes.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
As expected, it sitll works, no surprises. Thanks for cleaning up.

So I can give a
Tested-by: Andreas Kemnade <andreas@kemnade.info>

Regards,
Andreas

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-08 14:39 [PATCH] ARM: dts: e60k02: Pass the memory unit address Fabio Estevam
2019-11-09  9:19 ` Andreas Kemnade

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git