From: Mark Brown <broonie@kernel.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 1/4] arm64: Add initial support for E0PD
Date: Mon, 11 Nov 2019 17:35:24 +0000 [thread overview]
Message-ID: <20191111173524.GC4264@sirena.co.uk> (raw)
In-Reply-To: <97449111-a649-8e78-7f33-afbfae293eaf@arm.com>
[-- Attachment #1.1: Type: text/plain, Size: 710 bytes --]
On Mon, Nov 11, 2019 at 02:22:33PM +0000, Suzuki K Poulose wrote:
> On 08/11/2019 17:01, Mark Brown wrote:
> > + /*
> > + * The cpu_enable() callback gets called even on CPUs that
> > + * don't detect the feature so we need to verify if we can
> > + * enable.
> > + */
> > + if (this_cpu_has_cap(ARM64_HAS_E0PD))
> > + sysreg_clear_set(tcr_el1, 0, TCR_E0PD1);
> As mentioned in the previous version, this could set a superfluous model
> for people to do the same check for future SYSTEM_FEATURE type capabilities.
> I leave it to the maintainers.
To also reiterate the check doesn't hurt anything and avoids the
potential for future breakage if the capability gets changed (which
would be good to do).
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-11 17:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 17:01 [PATCH v8 0/4] E0PD support Mark Brown
2019-11-08 17:01 ` [PATCH v8 1/4] arm64: Add initial support for E0PD Mark Brown
2019-11-11 14:22 ` Suzuki K Poulose
2019-11-11 17:35 ` Mark Brown [this message]
2019-11-08 17:01 ` [PATCH v8 2/4] arm64: Factor out checks for KASLR in KPTI code into separate function Mark Brown
2019-11-11 14:31 ` Suzuki K Poulose
2019-11-08 17:01 ` [PATCH v8 3/4] arm64: Don't use KPTI where we have E0PD Mark Brown
2019-11-11 14:36 ` Suzuki K Poulose
2019-11-11 16:36 ` Mark Brown
2019-11-11 17:36 ` Suzuki K Poulose
2019-11-08 17:01 ` [PATCH v8 4/4] arm64: Use a variable to store non-global mappings decision Mark Brown
2019-11-11 14:39 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111173524.GC4264@sirena.co.uk \
--to=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).