From: Maxime Ripard <mripard@kernel.org>
To: Stefan Mavrodiev <stefan@olimex.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-sunxi@googlegroups.com,
open list <linux-kernel@vger.kernel.org>,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
"moderated list:ARM/Allwinner sunXi SoC support"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/1] arm64: dts: allwinner: a64: olinuxino: Add VCC-PG supply
Date: Tue, 26 Nov 2019 17:27:21 +0100 [thread overview]
Message-ID: <20191126162721.qi7scp3vadxn7k2i@gilmour.lan> (raw)
In-Reply-To: <20191126110508.15264-1-stefan@olimex.com>
[-- Attachment #1.1: Type: text/plain, Size: 971 bytes --]
Hi Stefan,
On Tue, Nov 26, 2019 at 01:05:08PM +0200, Stefan Mavrodiev wrote:
> On A64-OLinuXino boards, PG9 is used for USB1 enable/disable. The
> port is supplied by DLDO4, which is disabled by default. The patch
> adds the regulator as vcc-pg, which is later used by the pinctrl.
>
> Signed-off-by: Stefan Mavrodiev <stefan@olimex.com>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> index 01a9a52edae4..c9d8c9c4ef20 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> @@ -163,6 +163,10 @@
> status = "okay";
> };
>
> +&pio {
> + vcc-pg-supply=<®_dldo4>;
The equal sign should have spaces around it.
Also, can you please list all the bank supplies while you're at it?
Thanks!
Maxime
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-26 16:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 11:05 [PATCH 1/1] arm64: dts: allwinner: a64: olinuxino: Add VCC-PG supply Stefan Mavrodiev
2019-11-26 16:27 ` Maxime Ripard [this message]
2019-11-27 7:07 ` Stefan Mavrodiev
2019-11-28 10:33 ` Maxime Ripard
2019-11-29 7:22 ` Stefan Mavrodiev
2019-11-29 7:34 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126162721.qi7scp3vadxn7k2i@gilmour.lan \
--to=mripard@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=stefan@olimex.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).